From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNWANTED_LANGUAGE_BODY, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4387C4361B for ; Mon, 14 Dec 2020 14:36:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 631EA222BB for ; Mon, 14 Dec 2020 14:36:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727777AbgLNOg3 (ORCPT ); Mon, 14 Dec 2020 09:36:29 -0500 Received: from mail.kernel.org ([198.145.29.99]:37406 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2406215AbgLNOgX (ORCPT ); Mon, 14 Dec 2020 09:36:23 -0500 Date: Mon, 14 Dec 2020 15:35:40 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1607956542; bh=PduyduJ87ItDILEPk7/W38JfCRlCsHM+uffWVaujy0Q=; h=From:To:Cc:Subject:References:In-Reply-To:From; b=Cx7yJum3WsEDzK0IzokkpImFi0fq1fi+b2gQBRhRzo5E7/8VCTGo9mtGANM2ycgIw kR21sXJ1qm9tP//qtBW8ngOd6TvYlGxn0LiqftApiGwdH0gnfK/8X/Lh/OkE/f1ayx a55rCyISL2dDqvtIE2D1I3eCd99W8v9YQlFP/59eB/0KrfmVVD/0u3ZWrvoifXdveX F+k8Yo7H66OlxwAfMpLCgUJR4f5NbbOxnOaPWXSLucg2lKKdKTYLx0Qr7sjCn/e1V2 Vedu9bU/3GXXKQvQSVOpaX6Q2RTUVMmrysf8pW3f+zsHhUD6UFWFA59kdfzoYxlM2c +PUFcJXv6Sihw== From: Sebastian Reichel To: Tomi Valkeinen Cc: Laurent Pinchart , Nikhil Devshatwar , dri-devel@lists.freedesktop.org, linux-omap@vger.kernel.org, Sekhar Nori , Tony Lindgren , hns@goldelico.com, Sam Ravnborg Subject: Re: [PATCH v5 09/29] drm/omap: dsi: cleanup dispc channel usage Message-ID: <20201214143540.t3ozpc2mipgniuin@earth.universe> References: <20201208122855.254819-1-tomi.valkeinen@ti.com> <20201208122855.254819-10-tomi.valkeinen@ti.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ur6oq4h5b3dgkdyk" Content-Disposition: inline In-Reply-To: <20201208122855.254819-10-tomi.valkeinen@ti.com> Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org --ur6oq4h5b3dgkdyk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Tue, Dec 08, 2020 at 02:28:35PM +0200, Tomi Valkeinen wrote: > The "channel" usage in omap dsi driver is confusing. As the first step, > change "channel" to "dispc_channel" when dealing with the dispc channel. >=20 > Signed-off-by: Tomi Valkeinen > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/gpu/drm/omapdrm/dss/dsi.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) >=20 > diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/= dss/dsi.c > index c78ae99c8742..cf0dc4872d14 100644 > --- a/drivers/gpu/drm/omapdrm/dss/dsi.c > +++ b/drivers/gpu/drm/omapdrm/dss/dsi.c > @@ -3978,10 +3978,10 @@ static int dsi_configure_dispc_clocks(struct dsi_= data *dsi) > =20 > static int dsi_display_init_dispc(struct dsi_data *dsi) > { > - enum omap_channel channel =3D dsi->output.dispc_channel; > + enum omap_channel dispc_channel =3D dsi->output.dispc_channel; > int r; > =20 > - dss_select_lcd_clk_source(dsi->dss, channel, dsi->module_id =3D=3D 0 ? > + dss_select_lcd_clk_source(dsi->dss, dispc_channel, dsi->module_id =3D= =3D 0 ? > DSS_CLK_SRC_PLL1_1 : > DSS_CLK_SRC_PLL2_1); > =20 > @@ -4017,19 +4017,19 @@ static int dsi_display_init_dispc(struct dsi_data= *dsi) > dss_mgr_unregister_framedone_handler(&dsi->output, > dsi_framedone_irq_callback, dsi); > err: > - dss_select_lcd_clk_source(dsi->dss, channel, DSS_CLK_SRC_FCK); > + dss_select_lcd_clk_source(dsi->dss, dispc_channel, DSS_CLK_SRC_FCK); > return r; > } > =20 > static void dsi_display_uninit_dispc(struct dsi_data *dsi) > { > - enum omap_channel channel =3D dsi->output.dispc_channel; > + enum omap_channel dispc_channel =3D dsi->output.dispc_channel; > =20 > if (dsi->mode =3D=3D OMAP_DSS_DSI_CMD_MODE) > dss_mgr_unregister_framedone_handler(&dsi->output, > dsi_framedone_irq_callback, dsi); > =20 > - dss_select_lcd_clk_source(dsi->dss, channel, DSS_CLK_SRC_FCK); > + dss_select_lcd_clk_source(dsi->dss, dispc_channel, DSS_CLK_SRC_FCK); > } > =20 > static int dsi_configure_dsi_clocks(struct dsi_data *dsi) > @@ -4846,12 +4846,12 @@ static int dsi_set_config(struct omap_dss_device = *dssdev, > } > =20 > /* > - * Return a hardcoded channel for the DSI output. This should work for > + * Return a hardcoded dispc channel for the DSI output. This should work= for > * current use cases, but this can be later expanded to either resolve > * the channel in some more dynamic manner, or get the channel as a user > * parameter. > */ > -static enum omap_channel dsi_get_channel(struct dsi_data *dsi) > +static enum omap_channel dsi_get_dispc_channel(struct dsi_data *dsi) > { > switch (dsi->data->model) { > case DSI_MODEL_OMAP3: > @@ -5403,7 +5403,7 @@ static int dsi_init_output(struct dsi_data *dsi) > =20 > out->type =3D OMAP_DISPLAY_TYPE_DSI; > out->name =3D dsi->module_id =3D=3D 0 ? "dsi.0" : "dsi.1"; > - out->dispc_channel =3D dsi_get_channel(dsi); > + out->dispc_channel =3D dsi_get_dispc_channel(dsi); > out->dsi_ops =3D &dsi_ops; > out->of_port =3D 0; > out->bus_flags =3D DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE > --=20 > Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. > Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki >=20 --ur6oq4h5b3dgkdyk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAl/XeDwACgkQ2O7X88g7 +pqOYw/+LOaXw7WWIwzdRo2u8ok5X6RPR8OzTXR9bV1XTZ8DCdOyOZwE4Vmdy09a Sy6j+3P4Nrnv7qUxKQvsMnjQa7ZCaS85eZJ7z0AramS7cjaGdoEqbMrbdegXTcHv vsrxDEh0bnOeDiveRIK2jrXobY6zU37FiJ+wJ5hOVlTq0X6jUat6FY4c37ppMIQ9 AabxW7Bh6COkK5vPMPojBY8EebztM34eguJN0Hqj6D7D8KznxeGl42GptiApHlw4 8wo3LokCNM16GvRzLdjlc/NLEnTd3obuWIvTCssgRX1fojnTitbpa/HN9Ok/Dq5u tZ1RrqgeyMd2NUcAa4mrKfDC30WykNskRdRXTZKxh3WgSpokXcvnS3g3Lyk/sKku qcXudzoL4SsVAiPAwM9k41SoSOFBl3pwFEIya60cndGC3jzzLW+e9FFMavvFA/Rt 0NMkhUGPT5rLAbn6qCc1u7aMPd1CPhqjF8q5sXe3qLSaZ5rDXaV0rXw/sFNZ4Vw9 Xu1Qy+3fcn1JtDdUc5AOA/OZzp3nzH0WMhg0ha4JiYx7TGcYwC8zM7CLL55YK/mY c24RpM3Psex8N9XeO1kzI0BGZrmIUXb+NVtRuH6dJX3H1ZoD1G2kANgkbyRKgDhT 7NqPkoJ3ypCu3V3fxV9hh9bc22FlsqpRB3aj5DgzLne1AEZB9n8= =xFgR -----END PGP SIGNATURE----- --ur6oq4h5b3dgkdyk--