From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22016C2BB40 for ; Mon, 14 Dec 2020 16:17:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E28D7227C3 for ; Mon, 14 Dec 2020 16:17:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2440212AbgLNQRK (ORCPT ); Mon, 14 Dec 2020 11:17:10 -0500 Received: from mail.kernel.org ([198.145.29.99]:52006 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2440130AbgLNQRF (ORCPT ); Mon, 14 Dec 2020 11:17:05 -0500 Date: Mon, 14 Dec 2020 17:16:22 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1607962584; bh=iX3wJNojy8Tn3EAolSVHVqtoto9+JA9K8OCtneBQVFU=; h=From:To:Cc:Subject:References:In-Reply-To:From; b=r53wLGWF8TIi4rPbrRnFI+s0prOQHVTQr3dKVEyH4mYmDqVsbM8YMCfbZn3icgSc/ Crvr5JUzlXPCyk5khsqluovoUs00MCRMDLlOT1THJ+8AEfjipQ3PiOX4wjDOQLujTw YHEcaLlhCzRr9lCCOHP9LxohO7JJs23UkknWCy2W8tYPnhWptbfMuXOJfVsF3QNsNu jz3L6tqSzjWmB703lAUfN2EgbZKqI1XEjEAIzw6ILxUBLQEh5MMD1Tj1jdZPp8ZtJZ 8zaLfn/22ZPxogAcYwuoUMHF3dzu3l23j3vsVKgm9UlAvWMWmxn3HAgYct3qCYfhdn vTmYUniPARDSA== From: Sebastian Reichel To: Tomi Valkeinen Cc: Laurent Pinchart , Nikhil Devshatwar , dri-devel@lists.freedesktop.org, linux-omap@vger.kernel.org, Sekhar Nori , Tony Lindgren , hns@goldelico.com, Sam Ravnborg Subject: Re: [PATCH v5 20/29] drm/omap: dsi: move enable/disable to bridge enable/disable Message-ID: <20201214161622.eubzet3kxh2lblsk@earth.universe> References: <20201208122855.254819-1-tomi.valkeinen@ti.com> <20201208122855.254819-21-tomi.valkeinen@ti.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="pcni7sjl27fryd6g" Content-Disposition: inline In-Reply-To: <20201208122855.254819-21-tomi.valkeinen@ti.com> Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org --pcni7sjl27fryd6g Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Tue, Dec 08, 2020 at 02:28:46PM +0200, Tomi Valkeinen wrote: > Clean up the code by inlining dsi_enable_video_outputs and > dsi_disable_video_outputs functions. >=20 > Signed-off-by: Tomi Valkeinen > Reviewed-by: Laurent Pinchart > --- Reviewed-by: Sebastian Reichel -- Sebastian > drivers/gpu/drm/omapdrm/dss/dsi.c | 55 +++++++++++++------------------ > 1 file changed, 22 insertions(+), 33 deletions(-) >=20 > diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/= dss/dsi.c > index da3ff9e236bd..44b8e42b52ec 100644 > --- a/drivers/gpu/drm/omapdrm/dss/dsi.c > +++ b/drivers/gpu/drm/omapdrm/dss/dsi.c > @@ -3336,20 +3336,6 @@ static void dsi_disable_video_output(struct omap_d= ss_device *dssdev, int vc) > dsi_display_uninit_dispc(dsi); > } > =20 > -static void dsi_disable_video_outputs(struct omap_dss_device *dssdev) > -{ > - struct dsi_data *dsi =3D to_dsi_data(dssdev); > - > - dsi_bus_lock(dsi); > - dsi->video_enabled =3D false; > - > - dsi_disable_video_output(dssdev, VC_VIDEO); > - > - dsi_display_disable(dssdev); > - > - dsi_bus_unlock(dsi); > -} > - > static void dsi_update_screen_dispc(struct dsi_data *dsi) > { > unsigned int bytespp; > @@ -3796,23 +3782,6 @@ static void dsi_display_enable(struct omap_dss_dev= ice *dssdev) > _dsi_display_enable(dsi); > } > =20 > -static void dsi_enable_video_outputs(struct omap_dss_device *dssdev) > -{ > - struct dsi_data *dsi =3D to_dsi_data(dssdev); > - > - dsi_bus_lock(dsi); > - > - dsi_display_enable(dssdev); > - > - dsi_enable_video_output(dssdev, VC_VIDEO); > - > - dsi->video_enabled =3D true; > - > - dsi_set_ulps_auto(dsi, true); > - > - dsi_bus_unlock(dsi); > -} > - > static void _dsi_display_disable(struct dsi_data *dsi, > bool disconnect_lanes, bool enter_ulps) > { > @@ -4974,15 +4943,35 @@ static void dsi_bridge_mode_set(struct drm_bridge= *bridge, > static void dsi_bridge_enable(struct drm_bridge *bridge) > { > struct dsi_data *dsi =3D drm_bridge_to_dsi(bridge); > + struct omap_dss_device *dssdev =3D &dsi->output; > =20 > - dsi_enable_video_outputs(&dsi->output); > + dsi_bus_lock(dsi); > + > + dsi_display_enable(dssdev); > + > + dsi_enable_video_output(dssdev, VC_VIDEO); > + > + dsi->video_enabled =3D true; > + > + dsi_set_ulps_auto(dsi, true); > + > + dsi_bus_unlock(dsi); > } > =20 > static void dsi_bridge_disable(struct drm_bridge *bridge) > { > struct dsi_data *dsi =3D drm_bridge_to_dsi(bridge); > + struct omap_dss_device *dssdev =3D &dsi->output; > + > + dsi_bus_lock(dsi); > + > + dsi->video_enabled =3D false; > + > + dsi_disable_video_output(dssdev, VC_VIDEO); > =20 > - dsi_disable_video_outputs(&dsi->output); > + dsi_display_disable(dssdev); > + > + dsi_bus_unlock(dsi); > } > =20 > static const struct drm_bridge_funcs dsi_bridge_funcs =3D { > --=20 > Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. > Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki >=20 --pcni7sjl27fryd6g Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAl/Xj9YACgkQ2O7X88g7 +pry2A/+I/MELetbVYBuhahY5jt+rIpgIvGLdt8TUUIsjEFgA2VgNCzGHff9JUwB 2XggGiP5iztnw3iOlNNGXC53XRW0DBed3sSUFE7W6TyGOZ7Lg3a1zn39IluCsx2A VYQZuyJmIdyROgVJyTaeuYQETL5zdpaSQqO0r8WC5cvA9iXfBy7j5GWDqZnXgHdw p8vsEZEGsH8eYx1k+Fy4nlLKNC8i4luxscZZ/nG8/qUcfeu7+FIrz7Eu+qE1GqNm fTfArPnibnnDGRwH6m6ANvc08qKO86nKfZ3YSZrX/sEEjqMCY1C16aWQ/jUT/Q33 2qRwrBjwp9PKnyWcBHrJmpXs4KFI8Buo8j/gm8y/IUJGSLXOch61q/GIYmHajztK OClEJNflATx9n6HUh1t0F89pxISU0cFSuSMaYI//zQRJ4LG+GccLjgWqMi80otSC 8IlMXqoc7iOFgJi+uJ6XTTSkCmv1TqK/Ym0xLQNXQTzWfgGrU1n3IZglLhJHMWOf 2lJI1Iw1oS1RsWUe5cTaHxmewNoH0PEWnwuySmxgiPPIVkDL7XEnRGmGcLGGWq8Q AhHI0fECohC6Nn8O7gNK/nxXaWtqEiVw3HCP+PU4Th6XGMAlppjmyVc0sceB/Z2w BZhI65WrXa3tEuI9Qys67lqHGh6TsapvmaO+uIJbVXY+kRzyuXc= =QV+F -----END PGP SIGNATURE----- --pcni7sjl27fryd6g--