linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 0/4] AM64: Add PCIe bindings and driver support
@ 2021-01-04 12:40 Kishon Vijay Abraham I
  2021-01-04 12:41 ` [PATCH v2 1/4] dt-bindings: PCI: ti,j721e: Add binding to represent refclk to the connector Kishon Vijay Abraham I
                   ` (3 more replies)
  0 siblings, 4 replies; 7+ messages in thread
From: Kishon Vijay Abraham I @ 2021-01-04 12:40 UTC (permalink / raw)
  To: Bjorn Helgaas, Rob Herring, Tom Joseph, Lorenzo Pieralisi,
	Kishon Vijay Abraham I, Nadeem Athani
  Cc: linux-pci, devicetree, linux-kernel, linux-omap, linux-arm-kernel

AM64 uses the same PCIe controller as in J7200, however AM642 EVM
doesn't have a clock generator (unlike J7200 base board). Here
the clock from the SERDES has to be routed to the PCIE connector.
This series provides an option for the pci-j721e.c driver to
drive reference clock output to the connector.

v1 of the patch series can be found @ [1]

Changes from v1:
*) Fixed missing initialization of "ret" variable in the error path.

[1] -> http://lore.kernel.org/r/20201224115658.2795-1-kishon@ti.com

Kishon Vijay Abraham I (4):
  dt-bindings: PCI: ti,j721e: Add binding to represent refclk to the
    connector
  dt-bindings: pci: ti,j721e: Add host mode dt-bindings for TI's AM64
    SoC
  dt-bindings: pci: ti,j721e: Add endpoint mode dt-bindings for TI's
    AM64 SoC
  PCI: j721e: Add support to provide refclk to PCIe connector

 .../bindings/pci/ti,j721e-pci-ep.yaml         | 10 ++++---
 .../bindings/pci/ti,j721e-pci-host.yaml       | 27 ++++++++++++++-----
 drivers/pci/controller/cadence/pci-j721e.c    | 18 +++++++++++++
 3 files changed, 45 insertions(+), 10 deletions(-)

-- 
2.17.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH v2 1/4] dt-bindings: PCI: ti,j721e: Add binding to represent refclk to the connector
  2021-01-04 12:40 [PATCH v2 0/4] AM64: Add PCIe bindings and driver support Kishon Vijay Abraham I
@ 2021-01-04 12:41 ` Kishon Vijay Abraham I
  2021-01-11 22:31   ` Rob Herring
  2021-01-04 12:41 ` [PATCH v2 2/4] dt-bindings: pci: ti,j721e: Add host mode dt-bindings for TI's AM64 SoC Kishon Vijay Abraham I
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 7+ messages in thread
From: Kishon Vijay Abraham I @ 2021-01-04 12:41 UTC (permalink / raw)
  To: Bjorn Helgaas, Rob Herring, Tom Joseph, Lorenzo Pieralisi,
	Kishon Vijay Abraham I, Nadeem Athani
  Cc: linux-pci, devicetree, linux-kernel, linux-omap, linux-arm-kernel

Add binding to represent refclk to the PCIe connector.

Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
---
 .../bindings/pci/ti,j721e-pci-host.yaml         | 17 +++++++++++++----
 1 file changed, 13 insertions(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
index 0880a613ece6..7607018a115b 100644
--- a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
+++ b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
@@ -46,12 +46,21 @@ properties:
     maxItems: 1
 
   clocks:
-    maxItems: 1
-    description: clock-specifier to represent input to the PCIe
+    minItems: 1
+    maxItems: 2
+    description: clock-specifier to represent input to the PCIe for 1 item.
+      2nd item if present represents reference clock to the connector.
 
   clock-names:
-    items:
-      - const: fck
+    oneOf:
+      - description: Represent input clock to the PCIe
+        items:
+          - const: fck
+      - description: Represent input clock to the PCIe and reference clock to
+          the connector.
+        items:
+          - const: fck
+          - const: pcie_refclk
 
   vendor-id:
     const: 0x104c
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH v2 2/4] dt-bindings: pci: ti,j721e: Add host mode dt-bindings for TI's AM64 SoC
  2021-01-04 12:40 [PATCH v2 0/4] AM64: Add PCIe bindings and driver support Kishon Vijay Abraham I
  2021-01-04 12:41 ` [PATCH v2 1/4] dt-bindings: PCI: ti,j721e: Add binding to represent refclk to the connector Kishon Vijay Abraham I
@ 2021-01-04 12:41 ` Kishon Vijay Abraham I
  2021-01-11 22:37   ` Rob Herring
  2021-01-04 12:41 ` [PATCH v2 3/4] dt-bindings: pci: ti,j721e: Add endpoint " Kishon Vijay Abraham I
  2021-01-04 12:41 ` [PATCH v2 4/4] PCI: j721e: Add support to provide refclk to PCIe connector Kishon Vijay Abraham I
  3 siblings, 1 reply; 7+ messages in thread
From: Kishon Vijay Abraham I @ 2021-01-04 12:41 UTC (permalink / raw)
  To: Bjorn Helgaas, Rob Herring, Tom Joseph, Lorenzo Pieralisi,
	Kishon Vijay Abraham I, Nadeem Athani
  Cc: linux-pci, devicetree, linux-kernel, linux-omap, linux-arm-kernel

Add host mode dt-bindings for TI's AM64 SoC. This is the same IP used in
J7200, however AM64 is a non-coherent architecture.

Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
---
 .../devicetree/bindings/pci/ti,j721e-pci-host.yaml     | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
index 7607018a115b..77118dba415e 100644
--- a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
+++ b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
@@ -16,12 +16,17 @@ allOf:
 properties:
   compatible:
     oneOf:
-      - description: PCIe controller in J7200
+      - const: ti,am64-pcie-host
+      - const: ti,j7200-pcie-host
+      - const: ti,j721e-pcie-host
+      - description: PCIe controller in AM64
         items:
+          - const: ti,am64-pcie-host
           - const: ti,j7200-pcie-host
           - const: ti,j721e-pcie-host
-      - description: PCIe controller in J721E
+      - description: PCIe controller in J7200
         items:
+          - const: ti,j7200-pcie-host
           - const: ti,j721e-pcie-host
 
   reg:
@@ -87,7 +92,6 @@ required:
   - vendor-id
   - device-id
   - msi-map
-  - dma-coherent
   - dma-ranges
   - ranges
   - reset-gpios
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH v2 3/4] dt-bindings: pci: ti,j721e: Add endpoint mode dt-bindings for TI's AM64 SoC
  2021-01-04 12:40 [PATCH v2 0/4] AM64: Add PCIe bindings and driver support Kishon Vijay Abraham I
  2021-01-04 12:41 ` [PATCH v2 1/4] dt-bindings: PCI: ti,j721e: Add binding to represent refclk to the connector Kishon Vijay Abraham I
  2021-01-04 12:41 ` [PATCH v2 2/4] dt-bindings: pci: ti,j721e: Add host mode dt-bindings for TI's AM64 SoC Kishon Vijay Abraham I
@ 2021-01-04 12:41 ` Kishon Vijay Abraham I
  2021-01-04 12:41 ` [PATCH v2 4/4] PCI: j721e: Add support to provide refclk to PCIe connector Kishon Vijay Abraham I
  3 siblings, 0 replies; 7+ messages in thread
From: Kishon Vijay Abraham I @ 2021-01-04 12:41 UTC (permalink / raw)
  To: Bjorn Helgaas, Rob Herring, Tom Joseph, Lorenzo Pieralisi,
	Kishon Vijay Abraham I, Nadeem Athani
  Cc: linux-pci, devicetree, linux-kernel, linux-omap, linux-arm-kernel

Add endpoint mode dt-bindings for TI's AM64 SoC. This is the same IP
used in J7200, however AM64 is a non-coherent architecture.

Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
---
 .../devicetree/bindings/pci/ti,j721e-pci-ep.yaml       | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/pci/ti,j721e-pci-ep.yaml b/Documentation/devicetree/bindings/pci/ti,j721e-pci-ep.yaml
index d06f0c4464c6..447c8fe0f09e 100644
--- a/Documentation/devicetree/bindings/pci/ti,j721e-pci-ep.yaml
+++ b/Documentation/devicetree/bindings/pci/ti,j721e-pci-ep.yaml
@@ -16,12 +16,17 @@ allOf:
 properties:
   compatible:
     oneOf:
-      - description: PCIe EP controller in J7200
+      - const: ti,am64-pcie-ep
+      - const: ti,j7200-pcie-ep
+      - const: ti,j721e-pcie-ep
+      - description: PCIe EP controller in AM64
         items:
+          - const: ti,am64-pcie-ep
           - const: ti,j7200-pcie-ep
           - const: ti,j721e-pcie-ep
-      - description: PCIe EP controller in J721E
+      - description: PCIe EP controller in J7200
         items:
+          - const: ti,j7200-pcie-ep
           - const: ti,j721e-pcie-ep
 
   reg:
@@ -66,7 +71,6 @@ required:
   - power-domains
   - clocks
   - clock-names
-  - dma-coherent
   - max-functions
   - phys
   - phy-names
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH v2 4/4] PCI: j721e: Add support to provide refclk to PCIe connector
  2021-01-04 12:40 [PATCH v2 0/4] AM64: Add PCIe bindings and driver support Kishon Vijay Abraham I
                   ` (2 preceding siblings ...)
  2021-01-04 12:41 ` [PATCH v2 3/4] dt-bindings: pci: ti,j721e: Add endpoint " Kishon Vijay Abraham I
@ 2021-01-04 12:41 ` Kishon Vijay Abraham I
  3 siblings, 0 replies; 7+ messages in thread
From: Kishon Vijay Abraham I @ 2021-01-04 12:41 UTC (permalink / raw)
  To: Bjorn Helgaas, Rob Herring, Tom Joseph, Lorenzo Pieralisi,
	Kishon Vijay Abraham I, Nadeem Athani
  Cc: linux-pci, devicetree, linux-kernel, linux-omap, linux-arm-kernel

Add support to provide refclk to PCIe connector.

Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
---
 drivers/pci/controller/cadence/pci-j721e.c | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/drivers/pci/controller/cadence/pci-j721e.c b/drivers/pci/controller/cadence/pci-j721e.c
index dac1ac8a7615..2e73729c7388 100644
--- a/drivers/pci/controller/cadence/pci-j721e.c
+++ b/drivers/pci/controller/cadence/pci-j721e.c
@@ -6,6 +6,7 @@
  * Author: Kishon Vijay Abraham I <kishon@ti.com>
  */
 
+#include <linux/clk.h>
 #include <linux/delay.h>
 #include <linux/gpio/consumer.h>
 #include <linux/io.h>
@@ -50,6 +51,7 @@ enum link_status {
 
 struct j721e_pcie {
 	struct device		*dev;
+	struct clk		*refclk;
 	u32			mode;
 	u32			num_lanes;
 	struct cdns_pcie	*cdns_pcie;
@@ -310,6 +312,7 @@ static int j721e_pcie_probe(struct platform_device *pdev)
 	struct cdns_pcie_ep *ep;
 	struct gpio_desc *gpiod;
 	void __iomem *base;
+	struct clk *clk;
 	u32 num_lanes;
 	u32 mode;
 	int ret;
@@ -408,6 +411,20 @@ static int j721e_pcie_probe(struct platform_device *pdev)
 			goto err_get_sync;
 		}
 
+		clk = devm_clk_get_optional(dev, "pcie_refclk");
+		if (IS_ERR(clk)) {
+			dev_err(dev, "failed to get pcie_refclk\n");
+			ret = PTR_ERR(clk);
+			goto err_pcie_setup;
+		}
+
+		ret = clk_prepare_enable(clk);
+		if (ret) {
+			dev_err(dev, "failed to enable pcie_refclk\n");
+			goto err_get_sync;
+		}
+		pcie->refclk = clk;
+
 		/*
 		 * "Power Sequencing and Reset Signal Timings" table in
 		 * PCI EXPRESS CARD ELECTROMECHANICAL SPECIFICATION, REV. 3.0
@@ -476,6 +493,7 @@ static int j721e_pcie_remove(struct platform_device *pdev)
 	struct cdns_pcie *cdns_pcie = pcie->cdns_pcie;
 	struct device *dev = &pdev->dev;
 
+	clk_disable_unprepare(pcie->refclk);
 	cdns_pcie_disable_phy(cdns_pcie);
 	pm_runtime_put(dev);
 	pm_runtime_disable(dev);
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH v2 1/4] dt-bindings: PCI: ti,j721e: Add binding to represent refclk to the connector
  2021-01-04 12:41 ` [PATCH v2 1/4] dt-bindings: PCI: ti,j721e: Add binding to represent refclk to the connector Kishon Vijay Abraham I
@ 2021-01-11 22:31   ` Rob Herring
  0 siblings, 0 replies; 7+ messages in thread
From: Rob Herring @ 2021-01-11 22:31 UTC (permalink / raw)
  To: Kishon Vijay Abraham I
  Cc: Bjorn Helgaas, Tom Joseph, Lorenzo Pieralisi, Nadeem Athani,
	linux-pci, devicetree, linux-kernel, linux-omap,
	linux-arm-kernel

On Mon, Jan 04, 2021 at 06:11:00PM +0530, Kishon Vijay Abraham I wrote:
> Add binding to represent refclk to the PCIe connector.
> 
> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> ---
>  .../bindings/pci/ti,j721e-pci-host.yaml         | 17 +++++++++++++----
>  1 file changed, 13 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
> index 0880a613ece6..7607018a115b 100644
> --- a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
> +++ b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
> @@ -46,12 +46,21 @@ properties:
>      maxItems: 1
>  
>    clocks:
> -    maxItems: 1
> -    description: clock-specifier to represent input to the PCIe
> +    minItems: 1
> +    maxItems: 2
> +    description: clock-specifier to represent input to the PCIe for 1 item.
> +      2nd item if present represents reference clock to the connector.
>  
>    clock-names:
> -    items:
> -      - const: fck
> +    oneOf:
> +      - description: Represent input clock to the PCIe
> +        items:
> +          - const: fck
> +      - description: Represent input clock to the PCIe and reference clock to
> +          the connector.
> +        items:
> +          - const: fck
> +          - const: pcie_refclk

Can be just:

minItems: 1
items:
  - const: fck
  - const: pcie_refclk

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v2 2/4] dt-bindings: pci: ti,j721e: Add host mode dt-bindings for TI's AM64 SoC
  2021-01-04 12:41 ` [PATCH v2 2/4] dt-bindings: pci: ti,j721e: Add host mode dt-bindings for TI's AM64 SoC Kishon Vijay Abraham I
@ 2021-01-11 22:37   ` Rob Herring
  0 siblings, 0 replies; 7+ messages in thread
From: Rob Herring @ 2021-01-11 22:37 UTC (permalink / raw)
  To: Kishon Vijay Abraham I
  Cc: Bjorn Helgaas, Tom Joseph, Lorenzo Pieralisi, Nadeem Athani,
	linux-pci, devicetree, linux-kernel, linux-omap,
	linux-arm-kernel

On Mon, Jan 04, 2021 at 06:11:01PM +0530, Kishon Vijay Abraham I wrote:
> Add host mode dt-bindings for TI's AM64 SoC. This is the same IP used in
> J7200, however AM64 is a non-coherent architecture.
> 
> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> ---
>  .../devicetree/bindings/pci/ti,j721e-pci-host.yaml     | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
> index 7607018a115b..77118dba415e 100644
> --- a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
> +++ b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml
> @@ -16,12 +16,17 @@ allOf:
>  properties:
>    compatible:
>      oneOf:
> -      - description: PCIe controller in J7200
> +      - const: ti,am64-pcie-host

No, either you have fallback or you don't. 

> +      - const: ti,j7200-pcie-host
> +      - const: ti,j721e-pcie-host
> +      - description: PCIe controller in AM64
>          items:
> +          - const: ti,am64-pcie-host
>            - const: ti,j7200-pcie-host
>            - const: ti,j721e-pcie-host

2 fallbacks is probably not too useful. Do those really enable 
anything?

> -      - description: PCIe controller in J721E
> +      - description: PCIe controller in J7200
>          items:
> +          - const: ti,j7200-pcie-host
>            - const: ti,j721e-pcie-host
>  
>    reg:
> @@ -87,7 +92,6 @@ required:
>    - vendor-id
>    - device-id
>    - msi-map
> -  - dma-coherent
>    - dma-ranges
>    - ranges
>    - reset-gpios
> -- 
> 2.17.1
> 

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2021-01-11 22:38 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-04 12:40 [PATCH v2 0/4] AM64: Add PCIe bindings and driver support Kishon Vijay Abraham I
2021-01-04 12:41 ` [PATCH v2 1/4] dt-bindings: PCI: ti,j721e: Add binding to represent refclk to the connector Kishon Vijay Abraham I
2021-01-11 22:31   ` Rob Herring
2021-01-04 12:41 ` [PATCH v2 2/4] dt-bindings: pci: ti,j721e: Add host mode dt-bindings for TI's AM64 SoC Kishon Vijay Abraham I
2021-01-11 22:37   ` Rob Herring
2021-01-04 12:41 ` [PATCH v2 3/4] dt-bindings: pci: ti,j721e: Add endpoint " Kishon Vijay Abraham I
2021-01-04 12:41 ` [PATCH v2 4/4] PCI: j721e: Add support to provide refclk to PCIe connector Kishon Vijay Abraham I

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).