From: Kalle Valo <kvalo@codeaurora.org>
To: Tony Lindgren <tony@atomide.com>
Cc: Eyal Reizer <eyalr@ti.com>, Guy Mishol <guym@ti.com>,
Raz Bouganim <r-bouganim@ti.com>,
linux-wireless@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH] wlcore: Fix command execute failure 19 for wl12xx
Date: Thu, 14 Jan 2021 17:34:46 +0000 (UTC) [thread overview]
Message-ID: <20210114173446.6942CC43462@smtp.codeaurora.org> (raw)
In-Reply-To: <20201231085343.24337-1-tony@atomide.com>
Tony Lindgren <tony@atomide.com> wrote:
> We can currently get a "command execute failure 19" error on beacon loss
> if the signal is weak:
>
> wlcore: Beacon loss detected. roles:0xff
> wlcore: Connection loss work (role_id: 0).
> ...
> wlcore: ERROR command execute failure 19
> ...
> WARNING: CPU: 0 PID: 1552 at drivers/net/wireless/ti/wlcore/main.c:803
> ...
> (wl12xx_queue_recovery_work.part.0 [wlcore])
> (wl12xx_cmd_role_start_sta [wlcore])
> (wl1271_op_bss_info_changed [wlcore])
> (ieee80211_prep_connection [mac80211])
>
> Error 19 is defined as CMD_STATUS_WRONG_NESTING from the wlcore firmware,
> and seems to mean that the firmware no longer wants to see the quirk
> handling for WLCORE_QUIRK_START_STA_FAILS done.
>
> This quirk got added with commit 18eab430700d ("wlcore: workaround
> start_sta problem in wl12xx fw"), and it seems that this already got fixed
> in the firmware long time ago back in 2012 as wl18xx never had this quirk
> in place to start with.
>
> As we no longer even support firmware that early, to me it seems that it's
> safe to just drop WLCORE_QUIRK_START_STA_FAILS to fix the error. Looks
> like earlier firmware got disabled back in 2013 with commit 0e284c074ef9
> ("wl12xx: increase minimum singlerole firmware version required").
>
> If it turns out we still need WLCORE_QUIRK_START_STA_FAILS with any
> firmware that the driver works with, we can simply revert this patch and
> add extra checks for firmware version used.
>
> With this fix wlcore reconnects properly after a beacon loss.
>
> Cc: Raz Bouganim <r-bouganim@ti.com>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
Failed to apply to wireless-drivers-next:
fatal: sha1 information is lacking or useless (drivers/net/wireless/ti/wl12xx/main.c).
error: could not build fake ancestor
Applying: wlcore: Fix command execute failure 19 for wl12xx
Patch failed at 0001 wlcore: Fix command execute failure 19 for wl12xx
The copy of the patch that failed is found in: .git/rebase-apply/patch
Patch set to Changes Requested.
--
https://patchwork.kernel.org/project/linux-wireless/patch/20201231085343.24337-1-tony@atomide.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2021-01-14 17:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-31 8:53 [PATCH] wlcore: Fix command execute failure 19 for wl12xx Tony Lindgren
2021-01-14 17:34 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210114173446.6942CC43462@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=eyalr@ti.com \
--cc=guym@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=r-bouganim@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).