* [PATCH 1/2] ARM: dts: am335x-pocketbeagle: unique gpio-line-names
@ 2021-01-27 0:03 Drew Fustini
2021-01-27 0:03 ` [PATCH 2/2] ARM: dts: am335x-boneblack.dts: " Drew Fustini
` (4 more replies)
0 siblings, 5 replies; 11+ messages in thread
From: Drew Fustini @ 2021-01-27 0:03 UTC (permalink / raw)
To: bcousson, Tony Lindgren, Rob Herring, linux-omap, devicetree,
linux-kernel, Jason Kridner, Robert Nelson, Bjorn Andersson,
Linus Walleij, Bartosz Golaszewski, linux-gpio
Cc: Drew Fustini
Based on linux-gpio discussion [1], it is best practice to make the
gpio-line-names unique. Generic names like "[ethernet]" are replaced
with the name of the unique signal on the AM3358 SoC ball corresponding
to the gpio line. "[NC]" is also renamed to the standard "NC" name to
represent "not connected".
[1] https://lore.kernel.org/linux-gpio/20201216195357.GA2583366@x1/
Signed-off-by: Drew Fustini <drew@beagleboard.org>
---
arch/arm/boot/dts/am335x-pocketbeagle.dts | 140 +++++++++++-----------
1 file changed, 70 insertions(+), 70 deletions(-)
diff --git a/arch/arm/boot/dts/am335x-pocketbeagle.dts b/arch/arm/boot/dts/am335x-pocketbeagle.dts
index d526c5941c9b..209cdd17dc1e 100644
--- a/arch/arm/boot/dts/am335x-pocketbeagle.dts
+++ b/arch/arm/boot/dts/am335x-pocketbeagle.dts
@@ -61,51 +61,51 @@ vmmcsd_fixed: fixedregulator0 {
&gpio0 {
gpio-line-names =
- "[NC]",
- "[NC]",
+ "NC",
+ "NC",
"P1.08 [SPI0_CLK]",
"P1.10 [SPI0_MISO]",
"P1.12 [SPI0_MOSI]",
"P1.06 [SPI0_CS]",
"[MMC0_CD]",
"P2.29 [SPI1_CLK]",
- "[SYSBOOT]",
- "[SYSBOOT]",
- "[SYSBOOT]",
- "[SYSBOOT]",
+ "[SYSBOOT 12]",
+ "[SYSBOOT 13]",
+ "[SYSBOOT 14]",
+ "[SYSBOOT 15]",
"P1.26 [I2C2_SDA]",
"P1.28 [I2C2_SCL]",
"P2.11 [I2C1_SDA]",
"P2.09 [I2C1_SCL]",
- "[NC]",
- "[NC]",
- "[NC]",
+ "NC",
+ "NC",
+ "NC",
"P2.31 [SPI1_CS]",
"P1.20 [PRU0.16]",
- "[NC]",
- "[NC]",
+ "NC",
+ "NC",
"P2.03",
- "[NC]",
- "[NC]",
+ "NC",
+ "NC",
"P1.34",
"P2.19",
- "[NC]",
- "[NC]",
+ "NC",
+ "NC",
"P2.05 [UART4_RX]",
"P2.07 [UART4_TX]";
};
&gpio1 {
gpio-line-names =
- "[NC]",
- "[NC]",
- "[NC]",
- "[NC]",
- "[NC]",
- "[NC]",
- "[NC]",
- "[NC]",
- "[NC]",
+ "NC",
+ "NC",
+ "NC",
+ "NC",
+ "NC",
+ "NC",
+ "NC",
+ "NC",
+ "NC",
"P2.25 [SPI1_MOSI]",
"P1.32 [UART0_RX]",
"P1.30 [UART0_TX]",
@@ -113,10 +113,10 @@ &gpio1 {
"P2.33",
"P2.22",
"P2.18",
- "[NC]",
- "[NC]",
+ "NC",
+ "NC",
"P2.01 [PWM1A]",
- "[NC]",
+ "NC",
"P2.10",
"[USR LED 0]",
"[USR LED 1]",
@@ -126,35 +126,35 @@ &gpio1 {
"P2.04",
"P2.02",
"P2.08",
- "[NC]",
- "[NC]",
- "[NC]";
+ "NC",
+ "NC",
+ "NC";
};
&gpio2 {
gpio-line-names =
"P2.20",
"P2.17",
- "[NC]",
- "[NC]",
- "[NC]",
+ "NC",
+ "NC",
+ "NC",
"[EEPROM_WP]",
- "[SYSBOOT]",
- "[SYSBOOT]",
- "[SYSBOOT]",
- "[SYSBOOT]",
- "[SYSBOOT]",
- "[SYSBOOT]",
- "[SYSBOOT]",
- "[SYSBOOT]",
- "[SYSBOOT]",
- "[SYSBOOT]",
- "[SYSBOOT]",
- "[SYSBOOT]",
- "[NC]",
- "[NC]",
- "[NC]",
- "[NC]",
+ "[SYSBOOT 0]",
+ "[SYSBOOT 1]",
+ "[SYSBOOT 2]",
+ "[SYSBOOT 3]",
+ "[SYSBOOT 4]",
+ "[SYSBOOT 5]",
+ "[SYSBOOT 6]",
+ "[SYSBOOT 7]",
+ "[SYSBOOT 8]",
+ "[SYSBOOT 9]",
+ "[SYSBOOT 10]",
+ "[SYSBOOT 11]",
+ "NC",
+ "NC",
+ "NC",
+ "NC",
"P2.35 [AIN5]",
"P1.02 [AIN6]",
"P1.35 [PRU1.10]",
@@ -169,19 +169,19 @@ &gpio2 {
&gpio3 {
gpio-line-names =
- "[NC]",
- "[NC]",
- "[NC]",
- "[NC]",
- "[NC]",
+ "NC",
+ "NC",
+ "NC",
+ "NC",
+ "NC",
"[I2C0_SDA]",
"[I2C0_SCL]",
- "[JTAG]",
- "[JTAG]",
- "[NC]",
- "[NC]",
- "[NC]",
- "[NC]",
+ "[JTAG EMU0]",
+ "[JTAG EMU1]",
+ "NC",
+ "NC",
+ "NC",
+ "NC",
"P1.03 [USB1]",
"P1.36 [PWM0A]",
"P1.33 [PRU0.1]",
@@ -191,16 +191,16 @@ &gpio3 {
"P2.34 [PRU0.5]",
"P2.28 [PRU0.6]",
"P1.29 [PRU0.7]",
- "[NC]",
- "[NC]",
- "[NC]",
- "[NC]",
- "[NC]",
- "[NC]",
- "[NC]",
- "[NC]",
- "[NC]",
- "[NC]";
+ "NC",
+ "NC",
+ "NC",
+ "NC",
+ "NC",
+ "NC",
+ "NC",
+ "NC",
+ "NC",
+ "NC";
};
&am33xx_pinmux {
--
2.25.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 2/2] ARM: dts: am335x-boneblack.dts: unique gpio-line-names
2021-01-27 0:03 [PATCH 1/2] ARM: dts: am335x-pocketbeagle: unique gpio-line-names Drew Fustini
@ 2021-01-27 0:03 ` Drew Fustini
2021-01-28 12:01 ` Linus Walleij
2021-02-01 9:45 ` Bartosz Golaszewski
2021-01-28 12:01 ` [PATCH 1/2] ARM: dts: am335x-pocketbeagle: " Linus Walleij
` (3 subsequent siblings)
4 siblings, 2 replies; 11+ messages in thread
From: Drew Fustini @ 2021-01-27 0:03 UTC (permalink / raw)
To: bcousson, Tony Lindgren, Rob Herring, linux-omap, devicetree,
linux-kernel, Jason Kridner, Robert Nelson, Bjorn Andersson,
Linus Walleij, Bartosz Golaszewski, linux-gpio
Cc: Drew Fustini
Based on linux-gpio discussion [1], it is best practice to make the
gpio-line-names unique. Generic names like "[ethernet]" are replaced
with the name of the unique signal on the AM3358 SoC ball corresponding
to the gpio line. "[NC]" is also renamed to the standard "NC" name to
represent "not connected".
[1] https://lore.kernel.org/linux-gpio/20201216195357.GA2583366@x1/
Signed-off-by: Drew Fustini <drew@beagleboard.org>
---
arch/arm/boot/dts/am335x-boneblack.dts | 130 ++++++++++++-------------
1 file changed, 65 insertions(+), 65 deletions(-)
diff --git a/arch/arm/boot/dts/am335x-boneblack.dts b/arch/arm/boot/dts/am335x-boneblack.dts
index b4feb85e171a..ad9d32c7ec44 100644
--- a/arch/arm/boot/dts/am335x-boneblack.dts
+++ b/arch/arm/boot/dts/am335x-boneblack.dts
@@ -26,54 +26,54 @@ oppnitro-1000000000 {
&gpio0 {
gpio-line-names =
- "[ethernet]",
- "[ethernet]",
+ "[mdio_data]",
+ "[mdio_clk]",
"P9_22 [spi0_sclk]",
"P9_21 [spi0_d0]",
"P9_18 [spi0_d1]",
"P9_17 [spi0_cs0]",
- "[sd card]",
+ "[mmc0_cd]",
"P8_42A [ecappwm0]",
- "P8_35 [hdmi]",
- "P8_33 [hdmi]",
- "P8_31 [hdmi]",
- "P8_32 [hdmi]",
+ "P8_35 [lcd d12]",
+ "P8_33 [lcd d13]",
+ "P8_31 [lcd d14]",
+ "P8_32 [lcd d15]",
"P9_20 [i2c2_sda]",
"P9_19 [i2c2_scl]",
"P9_26 [uart1_rxd]",
"P9_24 [uart1_txd]",
- "[ethernet]",
- "[ethernet]",
- "[usb]",
- "[hdmi]",
+ "[rmii1_txd3]",
+ "[rmii1_txd2]",
+ "[usb0_drvvbus]",
+ "[hdmi cec]",
"P9_41B",
- "[ethernet]",
+ "[rmii1_txd1]",
"P8_19 [ehrpwm2a]",
"P8_13 [ehrpwm2b]",
- "[NC]",
- "[NC]",
+ "NC",
+ "NC",
"P8_14",
"P8_17",
- "[ethernet]",
- "[ethernet]",
+ "[rmii1_txd0]",
+ "[rmii1_refclk]",
"P9_11 [uart4_rxd]",
"P9_13 [uart4_txd]";
};
&gpio1 {
gpio-line-names =
- "P8_25 [emmc]",
- "[emmc]",
- "P8_5 [emmc]",
- "P8_6 [emmc]",
- "P8_23 [emmc]",
- "P8_22 [emmc]",
- "P8_3 [emmc]",
- "P8_4 [emmc]",
- "[NC]",
- "[NC]",
- "[NC]",
- "[NC]",
+ "P8_25 [mmc1_dat0]",
+ "[mmc1_dat1]",
+ "P8_5 [mmc1_dat2]",
+ "P8_6 [mmc1_dat3]",
+ "P8_23 [mmc1_dat4]",
+ "P8_22 [mmc1_dat5]",
+ "P8_3 [mmc1_dat6]",
+ "P8_4 [mmc1_dat7]",
+ "NC",
+ "NC",
+ "NC",
+ "NC",
"P8_12",
"P8_11",
"P8_16",
@@ -82,13 +82,13 @@ &gpio1 {
"P9_23",
"P9_14 [ehrpwm1a]",
"P9_16 [ehrpwm1b]",
- "[emmc]",
+ "[emmc rst]",
"[usr0 led]",
"[usr1 led]",
"[usr2 led]",
"[usr3 led]",
- "[hdmi]",
- "[usb]",
+ "[hdmi irq]",
+ "[usb vbus oc]",
"[hdmi audio]",
"P9_12",
"P8_26",
@@ -116,38 +116,38 @@ &gpio2 {
"P8_38 [hdmi]",
"P8_36 [hdmi]",
"P8_34 [hdmi]",
- "[ethernet]",
- "[ethernet]",
- "[ethernet]",
- "[ethernet]",
+ "[rmii1_rxd3]",
+ "[rmii1_rxd2]",
+ "[rmii1_rxd1]",
+ "[rmii1_rxd0]",
"P8_27 [hdmi]",
"P8_29 [hdmi]",
"P8_28 [hdmi]",
"P8_30 [hdmi]",
- "[emmc]",
- "[emmc]",
- "[emmc]",
- "[emmc]",
- "[emmc]",
- "[emmc]";
+ "[mmc0_dat3]",
+ "[mmc0_dat2]",
+ "[mmc0_dat1]",
+ "[mmc0_dat0]",
+ "[mmc0_clk]",
+ "[mmc0_cmd]";
};
&gpio3 {
gpio-line-names =
- "[ethernet]",
- "[ethernet]",
- "[ethernet]",
- "[ethernet]",
- "[ethernet]",
- "[i2c0]",
- "[i2c0]",
- "[emu]",
- "[emu]",
- "[ethernet]",
- "[ethernet]",
- "[NC]",
- "[NC]",
- "[usb]",
+ "[mii col]",
+ "[mii crs]",
+ "[mii rx err]",
+ "[mii tx en]",
+ "[mii rx dv]",
+ "[i2c0 sda]",
+ "[i2c0 scl]",
+ "[jtag emu0]",
+ "[jtag emu1]",
+ "[mii tx clk]",
+ "[mii rx clk]",
+ "NC",
+ "NC",
+ "[usb vbus en]",
"P9_31 [spi1_sclk]",
"P9_29 [spi1_d0]",
"P9_30 [spi1_d1]",
@@ -156,14 +156,14 @@ &gpio3 {
"P9_27",
"P9_41A",
"P9_25",
- "[NC]",
- "[NC]",
- "[NC]",
- "[NC]",
- "[NC]",
- "[NC]",
- "[NC]",
- "[NC]",
- "[NC]",
- "[NC]";
+ "NC",
+ "NC",
+ "NC",
+ "NC",
+ "NC",
+ "NC",
+ "NC",
+ "NC",
+ "NC",
+ "NC";
};
--
2.25.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH 1/2] ARM: dts: am335x-pocketbeagle: unique gpio-line-names
2021-01-27 0:03 [PATCH 1/2] ARM: dts: am335x-pocketbeagle: unique gpio-line-names Drew Fustini
2021-01-27 0:03 ` [PATCH 2/2] ARM: dts: am335x-boneblack.dts: " Drew Fustini
@ 2021-01-28 12:01 ` Linus Walleij
2021-02-01 9:44 ` Bartosz Golaszewski
` (2 subsequent siblings)
4 siblings, 0 replies; 11+ messages in thread
From: Linus Walleij @ 2021-01-28 12:01 UTC (permalink / raw)
To: Drew Fustini
Cc: Benoît Cousson, Tony Lindgren, Rob Herring, Linux-OMAP,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
linux-kernel, Jason Kridner, Robert Nelson, Bjorn Andersson,
Bartosz Golaszewski, open list:GPIO SUBSYSTEM
On Wed, Jan 27, 2021 at 1:04 AM Drew Fustini <drew@beagleboard.org> wrote:
> Based on linux-gpio discussion [1], it is best practice to make the
> gpio-line-names unique. Generic names like "[ethernet]" are replaced
> with the name of the unique signal on the AM3358 SoC ball corresponding
> to the gpio line. "[NC]" is also renamed to the standard "NC" name to
> represent "not connected".
>
> [1] https://lore.kernel.org/linux-gpio/20201216195357.GA2583366@x1/
>
> Signed-off-by: Drew Fustini <drew@beagleboard.org>
This certainly looks better!
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 2/2] ARM: dts: am335x-boneblack.dts: unique gpio-line-names
2021-01-27 0:03 ` [PATCH 2/2] ARM: dts: am335x-boneblack.dts: " Drew Fustini
@ 2021-01-28 12:01 ` Linus Walleij
2021-02-01 9:45 ` Bartosz Golaszewski
1 sibling, 0 replies; 11+ messages in thread
From: Linus Walleij @ 2021-01-28 12:01 UTC (permalink / raw)
To: Drew Fustini
Cc: Benoît Cousson, Tony Lindgren, Rob Herring, Linux-OMAP,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
linux-kernel, Jason Kridner, Robert Nelson, Bjorn Andersson,
Bartosz Golaszewski, open list:GPIO SUBSYSTEM
On Wed, Jan 27, 2021 at 1:05 AM Drew Fustini <drew@beagleboard.org> wrote:
> Based on linux-gpio discussion [1], it is best practice to make the
> gpio-line-names unique. Generic names like "[ethernet]" are replaced
> with the name of the unique signal on the AM3358 SoC ball corresponding
> to the gpio line. "[NC]" is also renamed to the standard "NC" name to
> represent "not connected".
>
> [1] https://lore.kernel.org/linux-gpio/20201216195357.GA2583366@x1/
>
> Signed-off-by: Drew Fustini <drew@beagleboard.org>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 1/2] ARM: dts: am335x-pocketbeagle: unique gpio-line-names
2021-01-27 0:03 [PATCH 1/2] ARM: dts: am335x-pocketbeagle: unique gpio-line-names Drew Fustini
2021-01-27 0:03 ` [PATCH 2/2] ARM: dts: am335x-boneblack.dts: " Drew Fustini
2021-01-28 12:01 ` [PATCH 1/2] ARM: dts: am335x-pocketbeagle: " Linus Walleij
@ 2021-02-01 9:44 ` Bartosz Golaszewski
2021-02-04 6:58 ` Tony Lindgren
2021-03-24 12:00 ` Tony Lindgren
4 siblings, 0 replies; 11+ messages in thread
From: Bartosz Golaszewski @ 2021-02-01 9:44 UTC (permalink / raw)
To: Drew Fustini
Cc: Benoit Cousson, Tony Lindgren, Rob Herring, Linux-OMAP,
linux-devicetree, LKML, Jason Kridner, Robert Nelson,
Bjorn Andersson, Linus Walleij, linux-gpio
On Wed, Jan 27, 2021 at 1:04 AM Drew Fustini <drew@beagleboard.org> wrote:
>
> Based on linux-gpio discussion [1], it is best practice to make the
> gpio-line-names unique. Generic names like "[ethernet]" are replaced
> with the name of the unique signal on the AM3358 SoC ball corresponding
> to the gpio line. "[NC]" is also renamed to the standard "NC" name to
> represent "not connected".
>
> [1] https://lore.kernel.org/linux-gpio/20201216195357.GA2583366@x1/
>
> Signed-off-by: Drew Fustini <drew@beagleboard.org>
> ---
Reviewed-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 2/2] ARM: dts: am335x-boneblack.dts: unique gpio-line-names
2021-01-27 0:03 ` [PATCH 2/2] ARM: dts: am335x-boneblack.dts: " Drew Fustini
2021-01-28 12:01 ` Linus Walleij
@ 2021-02-01 9:45 ` Bartosz Golaszewski
1 sibling, 0 replies; 11+ messages in thread
From: Bartosz Golaszewski @ 2021-02-01 9:45 UTC (permalink / raw)
To: Drew Fustini
Cc: Benoit Cousson, Tony Lindgren, Rob Herring, Linux-OMAP,
linux-devicetree, LKML, Jason Kridner, Robert Nelson,
Bjorn Andersson, Linus Walleij, linux-gpio
On Wed, Jan 27, 2021 at 1:05 AM Drew Fustini <drew@beagleboard.org> wrote:
>
> Based on linux-gpio discussion [1], it is best practice to make the
> gpio-line-names unique. Generic names like "[ethernet]" are replaced
> with the name of the unique signal on the AM3358 SoC ball corresponding
> to the gpio line. "[NC]" is also renamed to the standard "NC" name to
> represent "not connected".
>
> [1] https://lore.kernel.org/linux-gpio/20201216195357.GA2583366@x1/
>
> Signed-off-by: Drew Fustini <drew@beagleboard.org>
> ---
Reviewed-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 1/2] ARM: dts: am335x-pocketbeagle: unique gpio-line-names
2021-01-27 0:03 [PATCH 1/2] ARM: dts: am335x-pocketbeagle: unique gpio-line-names Drew Fustini
` (2 preceding siblings ...)
2021-02-01 9:44 ` Bartosz Golaszewski
@ 2021-02-04 6:58 ` Tony Lindgren
2021-02-04 7:46 ` Drew Fustini
2021-03-24 12:00 ` Tony Lindgren
4 siblings, 1 reply; 11+ messages in thread
From: Tony Lindgren @ 2021-02-04 6:58 UTC (permalink / raw)
To: Drew Fustini
Cc: bcousson, Rob Herring, linux-omap, devicetree, linux-kernel,
Jason Kridner, Robert Nelson, Bjorn Andersson, Linus Walleij,
Bartosz Golaszewski, linux-gpio
* Drew Fustini <drew@beagleboard.org> [210127 02:04]:
> Based on linux-gpio discussion [1], it is best practice to make the
> gpio-line-names unique. Generic names like "[ethernet]" are replaced
> with the name of the unique signal on the AM3358 SoC ball corresponding
> to the gpio line. "[NC]" is also renamed to the standard "NC" name to
> represent "not connected".
>
> [1] https://lore.kernel.org/linux-gpio/20201216195357.GA2583366@x1/
So are these needed for v5.12 as fixes, or can these wait until after
the merge window for v5.13?
Regards,
Tony
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 1/2] ARM: dts: am335x-pocketbeagle: unique gpio-line-names
2021-02-04 6:58 ` Tony Lindgren
@ 2021-02-04 7:46 ` Drew Fustini
2021-02-12 8:31 ` Linus Walleij
0 siblings, 1 reply; 11+ messages in thread
From: Drew Fustini @ 2021-02-04 7:46 UTC (permalink / raw)
To: Tony Lindgren
Cc: bcousson, Rob Herring, linux-omap, devicetree, linux-kernel,
Jason Kridner, Robert Nelson, Bjorn Andersson, Linus Walleij,
Bartosz Golaszewski, linux-gpio
On Thu, Feb 04, 2021 at 08:58:20AM +0200, Tony Lindgren wrote:
> * Drew Fustini <drew@beagleboard.org> [210127 02:04]:
> > Based on linux-gpio discussion [1], it is best practice to make the
> > gpio-line-names unique. Generic names like "[ethernet]" are replaced
> > with the name of the unique signal on the AM3358 SoC ball corresponding
> > to the gpio line. "[NC]" is also renamed to the standard "NC" name to
> > represent "not connected".
> >
> > [1] https://lore.kernel.org/linux-gpio/20201216195357.GA2583366@x1/
>
> So are these needed for v5.12 as fixes, or can these wait until after
> the merge window for v5.13?
>
> Regards,
>
> Tony
I suppose it depends on if/when the patches to make gpio lines unique
go in. I believe the last response from Linus W. was in mid-December
and indicated he holding off merging as it was immature [1]
Thanks,
Drew
[1] https://lore.kernel.org/linux-gpio/CACRpkdbXRHCDGX-YBbNY7cMob0dZNhi1ETA3QnC71ZtOYB30JQ@mail.gmail.com/
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 1/2] ARM: dts: am335x-pocketbeagle: unique gpio-line-names
2021-02-04 7:46 ` Drew Fustini
@ 2021-02-12 8:31 ` Linus Walleij
0 siblings, 0 replies; 11+ messages in thread
From: Linus Walleij @ 2021-02-12 8:31 UTC (permalink / raw)
To: Drew Fustini
Cc: Tony Lindgren, Benoît Cousson, Rob Herring, Linux-OMAP,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
linux-kernel, Jason Kridner, Robert Nelson, Bjorn Andersson,
Bartosz Golaszewski, open list:GPIO SUBSYSTEM
On Thu, Feb 4, 2021 at 8:47 AM Drew Fustini <drew@beagleboard.org> wrote:
> On Thu, Feb 04, 2021 at 08:58:20AM +0200, Tony Lindgren wrote:
> > * Drew Fustini <drew@beagleboard.org> [210127 02:04]:
> > > Based on linux-gpio discussion [1], it is best practice to make the
> > > gpio-line-names unique. Generic names like "[ethernet]" are replaced
> > > with the name of the unique signal on the AM3358 SoC ball corresponding
> > > to the gpio line. "[NC]" is also renamed to the standard "NC" name to
> > > represent "not connected".
> > >
> > > [1] https://lore.kernel.org/linux-gpio/20201216195357.GA2583366@x1/
> >
> > So are these needed for v5.12 as fixes, or can these wait until after
> > the merge window for v5.13?
> >
> > Regards,
> >
> > Tony
>
> I suppose it depends on if/when the patches to make gpio lines unique
> go in. I believe the last response from Linus W. was in mid-December
> and indicated he holding off merging as it was immature [1]
There is no hurry with that plus I hold that patch back indefinately
as it seems. I want to make line names unique for devices not
probing from DT but DT devices, I dunno.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 1/2] ARM: dts: am335x-pocketbeagle: unique gpio-line-names
2021-01-27 0:03 [PATCH 1/2] ARM: dts: am335x-pocketbeagle: unique gpio-line-names Drew Fustini
` (3 preceding siblings ...)
2021-02-04 6:58 ` Tony Lindgren
@ 2021-03-24 12:00 ` Tony Lindgren
2021-03-24 22:33 ` Drew Fustini
4 siblings, 1 reply; 11+ messages in thread
From: Tony Lindgren @ 2021-03-24 12:00 UTC (permalink / raw)
To: Drew Fustini
Cc: bcousson, Rob Herring, linux-omap, devicetree, linux-kernel,
Jason Kridner, Robert Nelson, Bjorn Andersson, Linus Walleij,
Bartosz Golaszewski, linux-gpio
Hi,
* Drew Fustini <drew@beagleboard.org> [210127 02:04]:
> Based on linux-gpio discussion [1], it is best practice to make the
> gpio-line-names unique. Generic names like "[ethernet]" are replaced
> with the name of the unique signal on the AM3358 SoC ball corresponding
> to the gpio line. "[NC]" is also renamed to the standard "NC" name to
> represent "not connected".
Applying this one into omap-for-v5.13/dt thanks. However the second patch
does not apply against v5.12-rc2, Drew can you please repost the second
patch?
Regards,
Tony
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 1/2] ARM: dts: am335x-pocketbeagle: unique gpio-line-names
2021-03-24 12:00 ` Tony Lindgren
@ 2021-03-24 22:33 ` Drew Fustini
0 siblings, 0 replies; 11+ messages in thread
From: Drew Fustini @ 2021-03-24 22:33 UTC (permalink / raw)
To: Tony Lindgren
Cc: bcousson, Rob Herring, linux-omap, devicetree, linux-kernel,
Jason Kridner, Robert Nelson, Bjorn Andersson, Linus Walleij,
Bartosz Golaszewski, linux-gpio
On Wed, Mar 24, 2021 at 02:00:52PM +0200, Tony Lindgren wrote:
> Hi,
>
> * Drew Fustini <drew@beagleboard.org> [210127 02:04]:
> > Based on linux-gpio discussion [1], it is best practice to make the
> > gpio-line-names unique. Generic names like "[ethernet]" are replaced
> > with the name of the unique signal on the AM3358 SoC ball corresponding
> > to the gpio line. "[NC]" is also renamed to the standard "NC" name to
> > represent "not connected".
>
> Applying this one into omap-for-v5.13/dt thanks. However the second patch
> does not apply against v5.12-rc2, Drew can you please repost the second
> patch?
>
> Regards,
>
> Tony
Hi Tony, I have posted a new patch that applies okay to mainline.
Thanks,
Drew
[1] https://lore.kernel.org/linux-gpio/20210324222201.674905-1-drew@beagleboard.org/T/#u
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2021-03-24 22:34 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-27 0:03 [PATCH 1/2] ARM: dts: am335x-pocketbeagle: unique gpio-line-names Drew Fustini
2021-01-27 0:03 ` [PATCH 2/2] ARM: dts: am335x-boneblack.dts: " Drew Fustini
2021-01-28 12:01 ` Linus Walleij
2021-02-01 9:45 ` Bartosz Golaszewski
2021-01-28 12:01 ` [PATCH 1/2] ARM: dts: am335x-pocketbeagle: " Linus Walleij
2021-02-01 9:44 ` Bartosz Golaszewski
2021-02-04 6:58 ` Tony Lindgren
2021-02-04 7:46 ` Drew Fustini
2021-02-12 8:31 ` Linus Walleij
2021-03-24 12:00 ` Tony Lindgren
2021-03-24 22:33 ` Drew Fustini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).