From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB85FC433E9 for ; Tue, 9 Feb 2021 17:39:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 834C364E7E for ; Tue, 9 Feb 2021 17:39:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233175AbhBIRjS (ORCPT ); Tue, 9 Feb 2021 12:39:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53838 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233300AbhBIRhQ (ORCPT ); Tue, 9 Feb 2021 12:37:16 -0500 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DD050C061797; Tue, 9 Feb 2021 09:36:35 -0800 (PST) Received: by mail-ed1-x534.google.com with SMTP id g10so24910780eds.2; Tue, 09 Feb 2021 09:36:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=3IKSUC2PbMBLcmAxJNHDlsNxrnoGLUkLdRWIm40sEpc=; b=LGw97nE1cdPwc3VbbdI7b3jcHyQ5rDSJXCpydItAPA5Duy7SnDry4v7J4PxhT0geS6 Q4VfKF0h844R3hVgCo54tdyExYyz5Mey9SqemYKef05Yhwl4eX8VZhJCjjGd2Xa90O01 PnHKbpH7BtHXyaPZdZzcY8cS02pRNsKUyPv6GdpdSnLDmd10xlE6NysARS0+T9Q2KY8d x+HvCxriBjgv2a78wFPePpW0sqjFfX106VbA50dcMre5AA483PPmKFWlhW2zJyqeYOF0 C+PC6bAZ12wwNYmvAyxSoUAZXPDe8phSMQd5gPunsSFUMFjEqG1rYCstOM4qG53nb86p roMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=3IKSUC2PbMBLcmAxJNHDlsNxrnoGLUkLdRWIm40sEpc=; b=TKcPyy6FzhnpwokROG+zMzAruQU3MC6unz5LtIjLiBBHtIJI2MZMAMQ7fHrUYZwN6o lERcjUkzdhD+3kSNH616dIkJVwPJnPTNg1YwHdoqvnksFJfd/ym4SjRdw2UqolK7wMlh I0Mx+uZozasC2OppyoQYH8AsKOm1KSgGpjT2AeG+Yi2OtRBaFTybIa3mQgRClMUe6Dnn jx56y6zdbtQfEB5ZFCKXKspJK/fVhsS9rW34qaRBEjZNokpJqqm+Ck2vCnRqMOrfmBvi ljIAH+NxzCpkX+wev3deLrdTnNraGIddZRQr2LzvT/RAHvvJnoifmv8xTlnHMIY/MV/9 x/EA== X-Gm-Message-State: AOAM5311dDX1xkSa2OF3ZOGmv5j8Lfqp8ctotWyfH9cnXBnSQRYlAjNj oKRh8AAmceLbXZY7IEqGaEk= X-Google-Smtp-Source: ABdhPJzwBwXcr3FNir+11tzCbCmVt5tv5onkeBPfFP5BzJvTttLymfdZC3IkFLRtUk/UOK6Q6I7vng== X-Received: by 2002:aa7:c58e:: with SMTP id g14mr24696022edq.318.1612892194600; Tue, 09 Feb 2021 09:36:34 -0800 (PST) Received: from skbuf (5-12-227-87.residential.rdsnet.ro. [5.12.227.87]) by smtp.gmail.com with ESMTPSA id z16sm6721317ejd.102.2021.02.09.09.36.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Feb 2021 09:36:33 -0800 (PST) Date: Tue, 9 Feb 2021 19:36:31 +0200 From: Vladimir Oltean To: Jakub Kicinski , "David S. Miller" Cc: Andrew Lunn , Vivien Didelot , Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bridge@lists.linux-foundation.org, Roopa Prabhu , Nikolay Aleksandrov , Jiri Pirko , Ido Schimmel , Claudiu Manoil , Alexandre Belloni , UNGLinuxDriver@microchip.com, Vadym Kochan , Taras Chornyi , Grygorii Strashko , Ioana Ciornei , Ivan Vecera , linux-omap@vger.kernel.org Subject: Re: [PATCH v2 net-next 03/11] net: bridge: don't print in br_switchdev_set_port_flag Message-ID: <20210209173631.c75cdjxphwzipeg5@skbuf> References: <20210209151936.97382-1-olteanv@gmail.com> <20210209151936.97382-4-olteanv@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210209151936.97382-4-olteanv@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org On Tue, Feb 09, 2021 at 05:19:28PM +0200, Vladimir Oltean wrote: > From: Vladimir Oltean > > Currently br_switchdev_set_port_flag has two options for error handling > and neither is good: > - The driver returns -EOPNOTSUPP in PRE_BRIDGE_FLAGS if it doesn't > support offloading that flag, and this gets silently ignored and > converted to an errno of 0. Nobody does this. > - The driver returns some other error code, like -EINVAL, in > PRE_BRIDGE_FLAGS, and br_switchdev_set_port_flag shouts loudly. > > The problem is that we'd like to offload some port flags during bridge > join and leave, but also not have the bridge shout at us if those fail. > But on the other hand we'd like the user to know that we can't offload > something when they set that through netlink. And since we can't have > the driver return -EOPNOTSUPP or -EINVAL depending on whether it's > called by the user or internally by the bridge, let's just add an extack > argument to br_switchdev_set_port_flag and propagate it to its callers. > Then, when we need offloading to really fail silently, this can simply > be passed a NULL argument. > > Signed-off-by: Vladimir Oltean > --- The build fails because since I started working on v2 and until I sent it, Jakub merged net into net-next which contained this fix: https://patchwork.kernel.org/project/netdevbpf/patch/20210207194733.1811529-1-olteanv@gmail.com/ for which I couldn't change prototype due to it missing in net-next. I think I would like to rather wait to gather some feedback first before respinning v3, if possible.