From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60A93C433E0 for ; Wed, 10 Feb 2021 18:46:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 275AD64E2A for ; Wed, 10 Feb 2021 18:46:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234216AbhBJSqM (ORCPT ); Wed, 10 Feb 2021 13:46:12 -0500 Received: from mail.baikalelectronics.com ([87.245.175.226]:35120 "EHLO mail.baikalelectronics.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234272AbhBJSoA (ORCPT ); Wed, 10 Feb 2021 13:44:00 -0500 Date: Wed, 10 Feb 2021 21:43:11 +0300 From: Serge Semin To: Florian Fainelli CC: Serge Semin , Felipe Balbi , Bjorn Andersson , Krzysztof Kozlowski , Rob Herring , Greg Kroah-Hartman , , Vineet Gupta , Rafal Milecki , Wei Xu , Thomas Bogendoerfer , Michael Ellerman , Jason Cooper , Santosh Shilimkar , Shawn Guo , Benoit Cousson , Patrice Chotard , Maxime Ripard , Khuong Dinh , Andy Gross , Alexey Brodkin , Hauke Mehrtens , Maxime Coquelin , Alexandre Torgue , Amelie Delaunay , Vladimir Zapolskiy , Paul Cercueil , Matthias Brugger , Benjamin Herrenschmidt , Paul Mackerras , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Kukjin Kim , Li Yang , Tony Lindgren , Chen-Yu Tsai , Jun Li , , , , , , , , , , , , Subject: Re: [PATCH RESEND v6 00/10] dt-bindings: usb: Harmonize xHCI/EHCI/OHCI/DWC3 nodes name Message-ID: <20210210184311.ouc6zft675kybyjx@mobilestation> References: <20210210172850.20849-1-Sergey.Semin@baikalelectronics.ru> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: MAIL.baikal.int (192.168.51.25) To mail (192.168.51.25) Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org On Wed, Feb 10, 2021 at 10:21:47AM -0800, Florian Fainelli wrote: > On 2/10/21 9:28 AM, Serge Semin wrote: > > As the subject states this series is an attempt to harmonize the xHCI, > > EHCI, OHCI and DWC USB3 DT nodes with the DT schema introduced in the > > framework of the patchset [1]. > > > > Firstly as Krzysztof suggested we've deprecated a support of DWC USB3 > > controllers with "synopsys,"-vendor prefix compatible string in favor of > > the ones with valid "snps,"-prefix. It's done in all the DTS files, > > which have been unfortunate to define such nodes. > > > > Secondly we suggest to fix the snps,quirk-frame-length-adjustment property > > declaration in the Amlogic meson-g12-common.dtsi DTS file, since it has > > been erroneously declared as boolean while having uint32 type. Neil said > > it was ok to init that property with 0x20 value. > > > > Thirdly the main part of the patchset concern fixing the xHCI, EHCI/OHCI > > and DWC USB3 DT nodes name as in accordance with their DT schema the > > corresponding node name is suppose to comply with the Generic USB HCD DT > > schema, which requires the USB nodes to have the name acceptable by the > > regexp: "^usb(@.*)?". Such requirement had been applicable even before we > > introduced the new DT schema in [1], but as we can see it hasn't been > > strictly implemented for a lot the DTS files. Since DT schema is now > > available the automated DTS validation shall make sure that the rule isn't > > violated. > > > > Note most of these patches have been a part of the last three patches of > > [1]. But since there is no way to have them merged in in a combined > > manner, I had to move them to the dedicated series and split them up so to > > be accepted by the corresponding subsystem maintainers one-by-one. > > > > [1] Link: https://lore.kernel.org/linux-usb/20201014101402.18271-1-Sergey.Semin@baikalelectronics.ru/ > > Changelog v1: > > - As Krzysztof suggested I've created a script which checked whether the > > node names had been also updated in all the depended dts files. As a > > result I found two more files which should have been also modified: > > arch/arc/boot/dts/{axc003.dtsi,axc003_idu.dtsi} > > - Correct the USB DWC3 nodes name found in > > arch/arm64/boot/dts/apm/{apm-storm.dtsi,apm-shadowcat.dtsi} too. > > > > Link: https://lore.kernel.org/linux-usb/20201020115959.2658-1-Sergey.Semin@baikalelectronics.ru > > Changelog v2: > > - Drop the patch: > > [PATCH 01/29] usb: dwc3: Discard synopsys,dwc3 compatibility string > > and get back the one which marks the "synopsys,dwc3" compatible string > > as deprecated into the DT schema related series. > > - Drop the patches: > > [PATCH 03/29] arm: dts: am437x: Correct DWC USB3 compatible string > > [PATCH 04/29] arm: dts: exynos: Correct DWC USB3 compatible string > > [PATCH 07/29] arm: dts: bcm53x: Harmonize EHCI/OHCI DT nodes name > > [PATCH 08/29] arm: dts: stm32: Harmonize EHCI/OHCI DT nodes name > > [PATCH 16/29] arm: dts: bcm5301x: Harmonize xHCI DT nodes name > > [PATCH 19/29] arm: dts: exynos: Harmonize DWC USB3 DT nodes name > > [PATCH 21/29] arm: dts: ls1021a: Harmonize DWC USB3 DT nodes name > > [PATCH 22/29] arm: dts: omap5: Harmonize DWC USB3 DT nodes name > > [PATCH 24/29] arm64: dts: allwinner: h6: Harmonize DWC USB3 DT nodes name > > [PATCH 26/29] arm64: dts: exynos: Harmonize DWC USB3 DT nodes name > > [PATCH 27/29] arm64: dts: layerscape: Harmonize DWC USB3 DT nodes name > > since they have been applied to the corresponding maintainers repos. > > - Fix drivers/usb/dwc3/dwc3-qcom.c to be looking for the "usb@"-prefixed > > sub-node and falling back to the "dwc3@"-prefixed one on failure. > > > > Link: https://lore.kernel.org/linux-usb/20201111091552.15593-1-Sergey.Semin@baikalelectronics.ru > > Changelog v3: > > - Drop the patches: > > [PATCH v2 04/18] arm: dts: hisi-x5hd2: Harmonize EHCI/OHCI DT nodes name > > [PATCH v2 06/18] arm64: dts: hisi: Harmonize EHCI/OHCI DT nodes name > > [PATCH v2 07/18] mips: dts: jz47x: Harmonize EHCI/OHCI DT nodes name > > [PATCH v2 08/18] mips: dts: sead3: Harmonize EHCI/OHCI DT nodes name > > [PATCH v2 09/18] mips: dts: ralink: mt7628a: Harmonize EHCI/OHCI DT nodes name > > [PATCH v2 11/18] arm64: dts: marvell: cp11x: Harmonize xHCI DT nodes name > > [PATCH v2 12/18] arm: dts: marvell: armada-375: Harmonize DWC USB3 DT nodes name > > [PATCH v2 16/18] arm64: dts: hi3660: Harmonize DWC USB3 DT nodes name > > since they have been applied to the corresponding maintainers repos. > > > > Link: https://lore.kernel.org/linux-usb/20201205155621.3045-1-Sergey.Semin@baikalelectronics.ru > > Changelog v4: > > - Just resend. > > > > Link: https://lore.kernel.org/linux-usb/20201210091756.18057-1-Sergey.Semin@baikalelectronics.ru/ > > Changelog v5: > > - Drop the patch: > > [PATCH v4 02/10] arm64: dts: amlogic: meson-g12: Set FL-adj property value > > since it has been applied to the corresponding maintainers repos. > > - Get back the patch: > > [PATCH 21/29] arm: dts: ls1021a: Harmonize DWC USB3 DT nodes name > > as it has been missing in the kernel 5.11-rc7 > > - Rebase onto the kernel 5.11-rc7 > > > > Link: https://lore.kernel.org/lkml/20210208135154.6645-1-Sergey.Semin@baikalelectronics.ru/ > > Changelog v6: > > - Just resend and add linux-usb.vger.kernel.org to the list of Ccecipients. > > > If this needs to go on, can you drop the people who already took your > patches (trying to lower my email amount to something manageable). > Thank you. Ah, sorry for the noise. I'll clean the Cc-list up in the next attempt to have this finally fully accepted. -Sergey > -- > Florian