From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74A6FC433E0 for ; Fri, 12 Feb 2021 09:21:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4986960231 for ; Fri, 12 Feb 2021 09:21:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230021AbhBLJVP (ORCPT ); Fri, 12 Feb 2021 04:21:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56506 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229497AbhBLJVB (ORCPT ); Fri, 12 Feb 2021 04:21:01 -0500 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C3355C061756 for ; Fri, 12 Feb 2021 01:20:20 -0800 (PST) Received: by mail-wm1-x330.google.com with SMTP id n10so321859wmq.0 for ; Fri, 12 Feb 2021 01:20:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=bqamNlgMJwnX1NfLFZzeEkJ+qDBnsfEzOwlb2Z22/gs=; b=QFvzjb1GkmDAeWGmn0HBsLlJ5qWtRzXU3LQZdoxoTZf9a7D0uxaXnwTzEi3yg3K+R6 0KxRGJAJ40ru1Jy+eFG3H628g1eUsLyx62qGM9QYm3wRfMsp2GN045FaOhN8hM++OVa6 9FmtkdB8GGwPPcX3fBFQiEzdjM0yiklqoeJZS3RxJdYdeWoU6cxjyqVMcdmt0asZRjlD cWNvyF51ci/nq/9S/KpoRK3wKuMMN2LcrjgBWQ355U+hBe1RHZKPgxjejrHDvUIK/QRZ UUHuVY3UTJBxhEoGoYvYIDX2kMO8XxAv52ByEvaY6JnnjJacsF9cwmlvuWp1vrsd08GC 9DTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=bqamNlgMJwnX1NfLFZzeEkJ+qDBnsfEzOwlb2Z22/gs=; b=O79EnK3Vvz/fsBjy/z51r4nYj7EYna14PrwlsezioOI1csy3MAvL8CINFUWPkIyVKq 5SuIwxSanK+rOMjDT/5lrjoy7MXaaXpz6Uw4piLPBpMlqOLC8ulXtuZQ5rUGtuHznX1g cZ/AVBzSvvcchPeUGvZoEIoN9EcRwPjHOn2f4MAdz9EZG2lGla1ZhE4l1KQE5LSuFsWb 1MQXjjun3hhOnlHYVFr/SdhBboN78FpLUfNGPpNQnTBpjyYad9dmDH7/pkzHAz5/2BdM r6dml+td1Cp23UbERjEVP/PzSYby0eHCl+eZji6yZam9v1t5zKESoN9qEIJtNJpuJISP +GHw== X-Gm-Message-State: AOAM5338d96rV2hgyAHO0BB9Uya9zdPwtY2H6sxgiNXC6cx/fLdHlYhc GkfJJ7lvKyoNWB2BpZk9F1wFvg== X-Google-Smtp-Source: ABdhPJzfB+2m0CuwIvKupkk6mtJvy2bOkvYMQcFwy8G4Q2gLr8baAJCjDmApyqiyqqb9nNKw9aR0fQ== X-Received: by 2002:a1c:113:: with SMTP id 19mr1795873wmb.7.1613121619466; Fri, 12 Feb 2021 01:20:19 -0800 (PST) Received: from dell ([91.110.221.187]) by smtp.gmail.com with ESMTPSA id x4sm9178784wrn.64.2021.02.12.01.20.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Feb 2021 01:20:19 -0800 (PST) Date: Fri, 12 Feb 2021 09:20:16 +0000 From: Lee Jones To: Stephen Boyd Cc: linux-kernel@vger.kernel.org, Ahmad Fatoum , Andy Gross , Avi Fishman , Benjamin Fair , Bjorn Andersson , Boris BREZILLON , Chen-Yu Tsai , Emilio =?iso-8859-1?Q?L=F3pez?= , Fabio Estevam , Geert Uytterhoeven , Jan Kotas , Jernej Skrabec , Jonathan Hunter , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-omap@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-tegra@vger.kernel.org, Loc Ho , Maxime Ripard , Michael Turquette , Michal Simek , Nancy Yuen , Nuvoton Technologies , NXP Linux Team , openbmc@lists.ozlabs.org, Patrick Venture , Pengutronix Kernel Team , Peter De Schrijver , Philipp Zabel , Prashant Gaikwad , Rajan Vaja , Rajeev Kumar , Richard Woodruff , Russell King , Sascha Hauer , Shawn Guo , Shiraz Hashim , =?iso-8859-1?Q?S=F6ren?= Brinkmann , Tali Perry , Tero Kristo , Thierry Reding , Tomer Maimon , Viresh Kumar Subject: Re: [PATCH 00/21] [Set 2] Rid W=1 warnings from Clock Message-ID: <20210212092016.GF4572@dell> References: <20210126124540.3320214-1-lee.jones@linaro.org> <161307643148.1254594.6590013599999468609@swboyd.mtv.corp.google.com> <20210211211054.GD4572@dell> <161309925025.1254594.6210738031889810500@swboyd.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <161309925025.1254594.6210738031889810500@swboyd.mtv.corp.google.com> Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org On Thu, 11 Feb 2021, Stephen Boyd wrote: > Quoting Lee Jones (2021-02-11 13:10:54) > > On Thu, 11 Feb 2021, Stephen Boyd wrote: > > > > > Quoting Lee Jones (2021-01-26 04:45:19) > > > > This set is part of a larger effort attempting to clean-up W=1 > > > > kernel builds, which are currently overwhelmingly riddled with > > > > niggly little warnings. > > > > > > > > This is the last set. Clock is clean after this. > > > > > > Is it possible to slam in some patch that makes W=1 the default for the > > > clk directory? I'm trying to avoid seeing this patch series again. > > > > One of my main goals of this project is that everyone (contributors, > > maintainers auto-builder robots etc) will be enabling W=1 builds > > *locally*. > > > > This isn't something you'll want to do at a global (i.e. in Mainline) > > level. That's kinda the point of W=1. > > > > Agreed, but is it possible to pass W=1 in the drivers/clk/Makefile? That would circumvent the point of W=1. Level-1 warnings are deemed, and I'm paraphrasing/making this up "not worth rejecting pull-requests over". In contrast, if Linus catches any W=0 warnings at pull-time, he will reject the pull-request as 'untested'. W=1 is defiantly something you'll want to enable locally though, and subsequently push back on contributors submitting code adding new ones. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog