linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: Stephen Boyd <sboyd@kernel.org>
Cc: linux-kernel@vger.kernel.org,
	"Ahmad Fatoum" <a.fatoum@pengutronix.de>,
	"Andy Gross" <agross@kernel.org>,
	"Avi Fishman" <avifishman70@gmail.com>,
	"Benjamin Fair" <benjaminfair@google.com>,
	"Bjorn Andersson" <bjorn.andersson@linaro.org>,
	"Boris BREZILLON" <boris.brezillon@free-electrons.com>,
	"Chen-Yu Tsai" <wens@csie.org>,
	"Emilio López" <emilio@elopez.com.ar>,
	"Fabio Estevam" <festevam@gmail.com>,
	"Geert Uytterhoeven" <geert+renesas@glider.be>,
	"Jan Kotas" <jank@cadence.com>,
	"Jernej Skrabec" <jernej.skrabec@siol.net>,
	"Jonathan Hunter" <jonathanh@nvidia.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
	linux-omap@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
	linux-tegra@vger.kernel.org, "Loc Ho" <lho@apm.com>,
	"Maxime Ripard" <mripard@kernel.org>,
	"Michael Turquette" <mturquette@baylibre.com>,
	"Michal Simek" <michal.simek@xilinx.com>,
	"Nancy Yuen" <yuenn@google.com>,
	"Nuvoton Technologies" <tali.perry@nuvoton.com>,
	"NXP Linux Team" <linux-imx@nxp.com>,
	openbmc@lists.ozlabs.org, "Patrick Venture" <venture@google.com>,
	"Pengutronix Kernel Team" <kernel@pengutronix.de>,
	"Peter De Schrijver" <pdeschrijver@nvidia.com>,
	"Philipp Zabel" <p.zabel@pengutronix.de>,
	"Prashant Gaikwad" <pgaikwad@nvidia.com>,
	"Rajan Vaja" <rajan.vaja@xilinx.com>,
	"Rajeev Kumar" <rajeev-dlh.kumar@st.com>,
	"Richard Woodruff" <r-woodruff2@ti.com>,
	"Russell King" <linux@armlinux.org.uk>,
	"Sascha Hauer" <s.hauer@pengutronix.de>,
	"Shawn Guo" <shawnguo@kernel.org>,
	"Shiraz Hashim" <shiraz.linux.kernel@gmail.com>,
	"Sören Brinkmann" <soren.brinkmann@xilinx.com>,
	"Tali Perry" <tali.perry1@gmail.com>,
	"Tero Kristo" <kristo@kernel.org>,
	"Thierry Reding" <thierry.reding@gmail.com>,
	"Tomer Maimon" <tmaimon77@gmail.com>,
	"Viresh Kumar" <vireshk@kernel.org>
Subject: Re: [PATCH 00/21] [Set 2] Rid W=1 warnings from Clock
Date: Fri, 12 Feb 2021 21:25:03 +0000	[thread overview]
Message-ID: <20210212212503.GC179940@dell> (raw)
In-Reply-To: <161316374113.1254594.14156657225822268891@swboyd.mtv.corp.google.com>

On Fri, 12 Feb 2021, Stephen Boyd wrote:

> Quoting Lee Jones (2021-02-12 01:20:16)
> > On Thu, 11 Feb 2021, Stephen Boyd wrote:
> > 
> > > Quoting Lee Jones (2021-02-11 13:10:54)
> > > > On Thu, 11 Feb 2021, Stephen Boyd wrote:
> > > > 
> > > > > Quoting Lee Jones (2021-01-26 04:45:19)
> > > > > > This set is part of a larger effort attempting to clean-up W=1
> > > > > > kernel builds, which are currently overwhelmingly riddled with
> > > > > > niggly little warnings.
> > > > > > 
> > > > > > This is the last set.  Clock is clean after this.
> > > > > 
> > > > > Is it possible to slam in some patch that makes W=1 the default for the
> > > > > clk directory? I'm trying to avoid seeing this patch series again.
> > > > 
> > > > One of my main goals of this project is that everyone (contributors,
> > > > maintainers auto-builder robots etc) will be enabling W=1 builds
> > > > *locally*.
> > > > 
> > > > This isn't something you'll want to do at a global (i.e. in Mainline)
> > > > level.  That's kinda the point of W=1.
> > > > 
> > > 
> > > Agreed, but is it possible to pass W=1 in the drivers/clk/Makefile?
> > 
> > That would circumvent the point of W=1.  Level-1 warnings are deemed,
> > and I'm paraphrasing/making this up "not worth rejecting pull-requests
> > over".  In contrast, if Linus catches any W=0 warnings at pull-time,
> > he will reject the pull-request as 'untested'.
> > 
> > W=1 is defiantly something you'll want to enable locally though, and
> > subsequently push back on contributors submitting code adding new
> > ones.
> > 
> 
> Why should I install a land mine for others to trip over? Won't that
> just take them more time because they won't know to compile with W=1 and
> then will have to go for another round of review while I push back on
> them submitting new warnings?

The alternative is to not worry about it and review the slow drip of
fixes that will occur as a result.  The issues I just fixed were built
up over years.  They won't get to that level again.

In my mind contributors should be compiling their submissions with W=1
enabled by default.  I'm fairly sure the auto-builders do this now.

Once W=1 warnings are down to an acceptable level in the kernel as a
whole, we can provide some guidance in SubmittingPatches (or similar)
on how to enable them (hint: you add "W=1" on the compile line).

Enabling W=1 in the default build will only serve to annoy Linus IMHO.
If he wants them to be enabled by default, they wouldn't be W=1 in the
first place, they'd be W=0 which *is* the default build.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

  reply	other threads:[~2021-02-12 21:25 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-26 12:45 [PATCH 00/21] [Set 2] Rid W=1 warnings from Clock Lee Jones
2021-01-26 12:45 ` [PATCH 02/21] clk: ti: clkt_dpll: Fix some kernel-doc misdemeanours Lee Jones
2021-02-11 19:54   ` Stephen Boyd
2021-01-26 12:45 ` [PATCH 03/21] clk: ti: dpll3xxx: Fix some kernel-doc headers and promote other worthy ones Lee Jones
2021-02-11 19:54   ` Stephen Boyd
2021-01-26 12:45 ` [PATCH 10/21] clk: ti: dpll44xx: Fix some potential doc-rot Lee Jones
2021-02-11 19:56   ` Stephen Boyd
2021-02-03  8:31 ` [PATCH 00/21] [Set 2] Rid W=1 warnings from Clock Lee Jones
2021-02-05 18:55   ` Stephen Boyd
2021-02-05 19:19     ` Lee Jones
2021-02-08  6:45 ` Tero Kristo
2021-02-11 20:47 ` Stephen Boyd
2021-02-11 21:10   ` Lee Jones
2021-02-12  3:07     ` Stephen Boyd
2021-02-12  9:20       ` Lee Jones
2021-02-12 21:02         ` Stephen Boyd
2021-02-12 21:25           ` Lee Jones [this message]
2021-02-12 21:26             ` Lee Jones
2021-02-12 22:05               ` Stephen Boyd
2021-02-12 22:37                 ` Lee Jones
2021-02-13  0:06                   ` Stephen Boyd
2021-02-13 16:04                     ` Andrew Lunn
     [not found]                       ` <161333644244.1254594.4498059850307971318@swboyd.mtv.corp.google.com>
2021-02-14 21:20                         ` Andrew Lunn
2021-02-15  8:49                           ` Lee Jones
2021-02-15 17:45                             ` Jakub Kicinski
2021-02-16  8:20                               ` Lee Jones
2021-02-17 18:08                                 ` Jakub Kicinski
2021-02-18  9:31                                   ` Lee Jones
2021-02-13 15:58       ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210212212503.GC179940@dell \
    --to=lee.jones@linaro.org \
    --cc=a.fatoum@pengutronix.de \
    --cc=agross@kernel.org \
    --cc=avifishman70@gmail.com \
    --cc=benjaminfair@google.com \
    --cc=bjorn.andersson@linaro.org \
    --cc=boris.brezillon@free-electrons.com \
    --cc=emilio@elopez.com.ar \
    --cc=festevam@gmail.com \
    --cc=geert+renesas@glider.be \
    --cc=jank@cadence.com \
    --cc=jernej.skrabec@siol.net \
    --cc=jonathanh@nvidia.com \
    --cc=kernel@pengutronix.de \
    --cc=kristo@kernel.org \
    --cc=lho@apm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=michal.simek@xilinx.com \
    --cc=mripard@kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=openbmc@lists.ozlabs.org \
    --cc=p.zabel@pengutronix.de \
    --cc=pdeschrijver@nvidia.com \
    --cc=pgaikwad@nvidia.com \
    --cc=r-woodruff2@ti.com \
    --cc=rajan.vaja@xilinx.com \
    --cc=rajeev-dlh.kumar@st.com \
    --cc=s.hauer@pengutronix.de \
    --cc=sboyd@kernel.org \
    --cc=shawnguo@kernel.org \
    --cc=shiraz.linux.kernel@gmail.com \
    --cc=soren.brinkmann@xilinx.com \
    --cc=tali.perry1@gmail.com \
    --cc=tali.perry@nuvoton.com \
    --cc=thierry.reding@gmail.com \
    --cc=tmaimon77@gmail.com \
    --cc=venture@google.com \
    --cc=vireshk@kernel.org \
    --cc=wens@csie.org \
    --cc=yuenn@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).