Linux-OMAP Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH 0/2] Two omap4/5 fixes
@ 2021-03-08 11:56 Tony Lindgren
  2021-03-08 11:56 ` [PATCH 1/2] ARM: dts: Drop duplicate sha2md5_fck to fix clk_disable race Tony Lindgren
  2021-03-08 11:56 ` [PATCH 2/2] ARM: dts: Fix moving mmc devices with aliases for omap4 & 5 Tony Lindgren
  0 siblings, 2 replies; 3+ messages in thread
From: Tony Lindgren @ 2021-03-08 11:56 UTC (permalink / raw)
  To: linux-omap; +Cc: Benoît Cousson, devicetree

Hi all,

Here two fixes noticed while testing my pending patches to drop legacy
data in favor of device tree data for omap4/5.

Regards,

Tony


Tony Lindgren (2):
  ARM: dts: Drop duplicate sha2md5_fck to fix clk_disable race
  ARM: dts: Fix moving mmc devices with aliases for omap4 & 5

 arch/arm/boot/dts/omap4.dtsi           | 5 +++++
 arch/arm/boot/dts/omap44xx-clocks.dtsi | 8 --------
 arch/arm/boot/dts/omap5.dtsi           | 5 +++++
 3 files changed, 10 insertions(+), 8 deletions(-)

-- 
2.30.1

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 1/2] ARM: dts: Drop duplicate sha2md5_fck to fix clk_disable race
  2021-03-08 11:56 [PATCH 0/2] Two omap4/5 fixes Tony Lindgren
@ 2021-03-08 11:56 ` Tony Lindgren
  2021-03-08 11:56 ` [PATCH 2/2] ARM: dts: Fix moving mmc devices with aliases for omap4 & 5 Tony Lindgren
  1 sibling, 0 replies; 3+ messages in thread
From: Tony Lindgren @ 2021-03-08 11:56 UTC (permalink / raw)
  To: linux-omap; +Cc: Benoît Cousson, devicetree

We have a duplicate legacy clock defined for sha2md5_fck that can
sometimes race with clk_disable() with the dts configured clock
for OMAP4_SHA2MD5_CLKCTRL when unused clocks are disabled during
boot causing an "Unhandled fault: imprecise external abort".

Signed-off-by: Tony Lindgren <tony@atomide.com>
---
 arch/arm/boot/dts/omap44xx-clocks.dtsi | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/arch/arm/boot/dts/omap44xx-clocks.dtsi b/arch/arm/boot/dts/omap44xx-clocks.dtsi
--- a/arch/arm/boot/dts/omap44xx-clocks.dtsi
+++ b/arch/arm/boot/dts/omap44xx-clocks.dtsi
@@ -770,14 +770,6 @@ per_abe_nc_fclk: per_abe_nc_fclk@108 {
 		ti,max-div = <2>;
 	};
 
-	sha2md5_fck: sha2md5_fck@15c8 {
-		#clock-cells = <0>;
-		compatible = "ti,gate-clock";
-		clocks = <&l3_div_ck>;
-		ti,bit-shift = <1>;
-		reg = <0x15c8>;
-	};
-
 	usb_phy_cm_clk32k: usb_phy_cm_clk32k@640 {
 		#clock-cells = <0>;
 		compatible = "ti,gate-clock";
-- 
2.30.1

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 2/2] ARM: dts: Fix moving mmc devices with aliases for omap4 & 5
  2021-03-08 11:56 [PATCH 0/2] Two omap4/5 fixes Tony Lindgren
  2021-03-08 11:56 ` [PATCH 1/2] ARM: dts: Drop duplicate sha2md5_fck to fix clk_disable race Tony Lindgren
@ 2021-03-08 11:56 ` Tony Lindgren
  1 sibling, 0 replies; 3+ messages in thread
From: Tony Lindgren @ 2021-03-08 11:56 UTC (permalink / raw)
  To: linux-omap; +Cc: Benoît Cousson, devicetree

Fix moving mmc devices with dts aliases as discussed on the lists.
Without this we now have internal eMMC mmc1 show up as mmc2 compared
to the earlier order of devices.

Signed-off-by: Tony Lindgren <tony@atomide.com>
---
 arch/arm/boot/dts/omap4.dtsi | 5 +++++
 arch/arm/boot/dts/omap5.dtsi | 5 +++++
 2 files changed, 10 insertions(+)

diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi
--- a/arch/arm/boot/dts/omap4.dtsi
+++ b/arch/arm/boot/dts/omap4.dtsi
@@ -22,6 +22,11 @@ aliases {
 		i2c1 = &i2c2;
 		i2c2 = &i2c3;
 		i2c3 = &i2c4;
+		mmc0 = &mmc1;
+		mmc1 = &mmc2;
+		mmc2 = &mmc3;
+		mmc3 = &mmc4;
+		mmc4 = &mmc5;
 		serial0 = &uart1;
 		serial1 = &uart2;
 		serial2 = &uart3;
diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi
--- a/arch/arm/boot/dts/omap5.dtsi
+++ b/arch/arm/boot/dts/omap5.dtsi
@@ -25,6 +25,11 @@ aliases {
 		i2c2 = &i2c3;
 		i2c3 = &i2c4;
 		i2c4 = &i2c5;
+		mmc0 = &mmc1;
+		mmc1 = &mmc2;
+		mmc2 = &mmc3;
+		mmc3 = &mmc4;
+		mmc4 = &mmc5;
 		serial0 = &uart1;
 		serial1 = &uart2;
 		serial2 = &uart3;
-- 
2.30.1

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-08 11:56 [PATCH 0/2] Two omap4/5 fixes Tony Lindgren
2021-03-08 11:56 ` [PATCH 1/2] ARM: dts: Drop duplicate sha2md5_fck to fix clk_disable race Tony Lindgren
2021-03-08 11:56 ` [PATCH 2/2] ARM: dts: Fix moving mmc devices with aliases for omap4 & 5 Tony Lindgren

Linux-OMAP Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-omap/0 linux-omap/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-omap linux-omap/ https://lore.kernel.org/linux-omap \
		linux-omap@vger.kernel.org
	public-inbox-index linux-omap

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-omap


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git