linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 0/3] Fix pinctrl-single pcs_pin_dbg_show()
@ 2021-03-16 20:24 Hanna Hawa
  2021-03-16 20:24 ` [PATCH v2 1/3] pinctrl: pinctrl-single: remove unused variable Hanna Hawa
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Hanna Hawa @ 2021-03-16 20:24 UTC (permalink / raw)
  To: tony, haojian.zhuang, linus.walleij
  Cc: dwmw, benh, ronenk, talel, jonnyc, hanochu, tgershi,
	linux-arm-kernel, linux-omap, linux-gpio, linux-kernel, hhhawa

These patches fix the pcs_pin_dbg_show() function for the scenario where
a single register controls multiple pins (i.e. bits_per_mux != 0).
Additionally, the common formula is moved to a separate function to
allow reuse.

Changes since v1:
-----------------
- remove unused variable in In function 'pcs_allocate_pin_table'
  (Reported-by: kernel test robot <lkp@intel.com>)

Hanna Hawa (3):
  pinctrl: pinctrl-single: remove unused variable
  pinctrl: pinctrl-single: remove unused parameter
  pinctrl: pinctrl-single: fix pcs_pin_dbg_show() when bits_per_mux != 0

 drivers/pinctrl/pinctrl-single.c | 76 ++++++++++++++++++++------------
 1 file changed, 47 insertions(+), 29 deletions(-)

-- 
2.17.1


^ permalink raw reply	[flat|nested] 7+ messages in thread
* [PATCH v2 0/3] Fix pinctrl-single pcs_pin_dbg_show()
@ 2021-03-17 21:41 Hanna Hawa
  0 siblings, 0 replies; 7+ messages in thread
From: Hanna Hawa @ 2021-03-17 21:41 UTC (permalink / raw)
  To: andy.shevchenko, tony, haojian.zhuang, linus.walleij
  Cc: dwmw, benh, ronenk, talel, jonnyc, hanochu, tgershi,
	linux-arm-kernel, linux-omap, linux-gpio, linux-kernel, hhhawa

These patches fix the pcs_pin_dbg_show() function for the scenario where
a single register controls multiple pins (i.e. bits_per_mux is not zero)
Additionally, the common formula is moved to a separate function to
allow reuse.

Changes since v2:
-----------------
- move read() register to be outside of if condition (as it common
  read()).
- Remove extra parentheses
- replace offset variable by direct return statements

Changes since v1:
-----------------
- remove unused variable in In function 'pcs_allocate_pin_table'
  (Reported-by: kernel test robot <lkp@intel.com>)

Hanna Hawa (3):
  pinctrl: pinctrl-single: remove unused variable
  pinctrl: pinctrl-single: remove unused parameter
  pinctrl: pinctrl-single: fix pcs_pin_dbg_show() when bits_per_mux is
    not zero

 drivers/pinctrl/pinctrl-single.c | 67 +++++++++++++++++++-------------
 1 file changed, 39 insertions(+), 28 deletions(-)

-- 
2.17.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2021-03-17 21:43 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-16 20:24 [PATCH v2 0/3] Fix pinctrl-single pcs_pin_dbg_show() Hanna Hawa
2021-03-16 20:24 ` [PATCH v2 1/3] pinctrl: pinctrl-single: remove unused variable Hanna Hawa
2021-03-16 20:24 ` [PATCH v2 2/3] pinctrl: pinctrl-single: remove unused parameter Hanna Hawa
2021-03-16 20:24 ` [PATCH v2 3/3] pinctrl: pinctrl-single: fix pcs_pin_dbg_show() when bits_per_mux != 0 Hanna Hawa
2021-03-17 12:27   ` Andy Shevchenko
2021-03-17 19:35     ` Hawa, Hanna
2021-03-17 21:41 [PATCH v2 0/3] Fix pinctrl-single pcs_pin_dbg_show() Hanna Hawa

This is a public inbox, see mirroring instructions
on how to clone and mirror all data and code used for this inbox