From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EF23C433E0 for ; Tue, 23 Mar 2021 23:21:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2C4DC619F1 for ; Tue, 23 Mar 2021 23:21:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234216AbhCWXUs (ORCPT ); Tue, 23 Mar 2021 19:20:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51262 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229670AbhCWXUT (ORCPT ); Tue, 23 Mar 2021 19:20:19 -0400 Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [IPv6:2607:f8b0:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 25FAFC061763 for ; Tue, 23 Mar 2021 16:20:18 -0700 (PDT) Received: by mail-pf1-x434.google.com with SMTP id l3so15941791pfc.7 for ; Tue, 23 Mar 2021 16:20:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=2mPqZ8T3s6ATLiDuP1AsIgNdhiWZsvEH4M6lDW4cfTI=; b=FkYfaAkO0Z6/s4JItNqmcW1gokGmTqNJc9DB36xytboCFozRTY5w7JdrA4JFNrrqUc PScrQdfFxWrPte+4sTO//YvN7fQwHcV4zIOKvLkNX+zkTewbGEUrY0GEDOiEQUF4vYuU aFAGddHODC9RZFrFAz47xwrt5Rc5jXEikRcLR5EzlVCiEtalcSZHIkFUV2dR22EvrkrX 0xQkfBA3CaMmqYlEvQNU41R3KeX7PtTHWJztwsyq20bzwZz7nyLoXhDTLGfFphS2wpwu 5p3iYee6HWfEVuxS+9Mfdy0BB3mLXec96LfugcFuNmiAtUKDyBgTj9/PwhGHdbLPB8XF 4C/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=2mPqZ8T3s6ATLiDuP1AsIgNdhiWZsvEH4M6lDW4cfTI=; b=VHJUtcCIAiRRi8f70AAn6adQMZn+FpU7A3MItI0+TrkrJvGYvacG8ixwVx9cTUB7a5 C3xtgi7NXDl0W34rxgTZv9gHgcGITZhsyPR8BNBZQp98kWAk+IuE/CrV/emDn9Que11X 2rKhZotxk28cQqQvGTVX4wNsy7Q9B6gtWsg+pw4UBuwT7a8OJCw5KCPU+VXAYW+4unE4 XL/IDJpMUNzRYQixklv9ENclZj6o9TMOecO1PFc4K11zM8ZWDVO/+PS6hkYjkgbknauy mhEApgFTSuteY+1xF3qsNgIsv2nK402CLhVBdxZYcKn2gjbHxmJLdH+j8HU0j/j3NgEy z0yQ== X-Gm-Message-State: AOAM530Ui+zt3q/TWP2Lg1sScAZrZs6HIrPrfv6zIunbjTQz0nbDG4s8 uQArL+PVwOnTBbrwViPtYAG0XQ== X-Google-Smtp-Source: ABdhPJxNQ1MKjV1GEOTfkga2yU4EzySf+ImHzG//t/vH8JyfFvC/Ow4Oj+kKSp7Y3MjTm9kaPF1qEw== X-Received: by 2002:a17:902:8e89:b029:e6:ef44:6a54 with SMTP id bg9-20020a1709028e89b02900e6ef446a54mr756979plb.7.1616541617252; Tue, 23 Mar 2021 16:20:17 -0700 (PDT) Received: from xps15 (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id 22sm230405pjl.31.2021.03.23.16.20.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Mar 2021 16:20:16 -0700 (PDT) Date: Tue, 23 Mar 2021 17:20:14 -0600 From: Mathieu Poirier To: Suman Anna Cc: Bjorn Andersson , Grzegorz Jaszczyk , Jan Kiszka , Lokesh Vutla , Vignesh Raghavendra , linux-remoteproc@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] remoteproc: pru: Fix firmware loading crashes on K3 SoCs Message-ID: <20210323232014.GA1782475@xps15> References: <20210315205859.19590-1-s-anna@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210315205859.19590-1-s-anna@ti.com> Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org On Mon, Mar 15, 2021 at 03:58:59PM -0500, Suman Anna wrote: > The K3 PRUs are 32-bit processors and in general have some limitations > in using the standard ARMv8 memcpy function for loading firmware segments, > so the driver already uses a custom memcpy implementation. This added > logic however is limited to only IRAMs at the moment, but the loading > into Data RAMs is not completely ok either and does generate a kernel > crash for unaligned accesses. > > Fix these crashes by removing the existing IRAM logic limitation and > extending the custom memcpy usage to Data RAMs as well for all K3 SoCs. > > Fixes: 1d39f4d19921 ("remoteproc: pru: Add support for various PRU cores on K3 AM65x SoCs") > Signed-off-by: Suman Anna Probably a good idea to CC stable as well... Reviewed-by: Mathieu Poirier > --- > drivers/remoteproc/pru_rproc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/remoteproc/pru_rproc.c b/drivers/remoteproc/pru_rproc.c > index 2667919d76b3..16979c1cd2f4 100644 > --- a/drivers/remoteproc/pru_rproc.c > +++ b/drivers/remoteproc/pru_rproc.c > @@ -585,7 +585,7 @@ pru_rproc_load_elf_segments(struct rproc *rproc, const struct firmware *fw) > break; > } > > - if (pru->data->is_k3 && is_iram) { > + if (pru->data->is_k3) { > ret = pru_rproc_memcpy(ptr, elf_data + phdr->p_offset, > filesz); > if (ret) { > -- > 2.30.1 >