From: Wolfram Sang <wsa@kernel.org>
To: Li Huafei <lihuafei1@huawei.com>
Cc: vigneshr@ti.com, tony@atomide.com, aaro.koskinen@iki.fi,
linux-omap@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org, yangjihong1@huawei.com,
zhangjinhao2@huawei.com
Subject: Re: [PATCH -next] i2c: omap: fix PM reference leak in omap_i2c_probe()
Date: Wed, 14 Apr 2021 10:01:19 +0200 [thread overview]
Message-ID: <20210414080119.GH2180@ninjato> (raw)
In-Reply-To: <20210408125648.136519-1-lihuafei1@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 517 bytes --]
On Thu, Apr 08, 2021 at 08:56:48PM +0800, Li Huafei wrote:
> pm_runtime_get_sync will increment pm usage counter even it failed.
> Forgetting to putting operation will result in reference leak here. Fix
> it by replacing it with pm_runtime_resume_and_get to keep usage counter
> balanced.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Li Huafei <lihuafei1@huawei.com>
Thanks, yet I applied this series now:
http://patchwork.ozlabs.org/project/linux-i2c/list/?series=217733&state=*
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2021-04-14 8:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 12:56 [PATCH -next] i2c: omap: fix PM reference leak in omap_i2c_probe() Li Huafei
2021-04-10 7:00 ` Vignesh Raghavendra
2021-04-14 8:01 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210414080119.GH2180@ninjato \
--to=wsa@kernel.org \
--cc=aaro.koskinen@iki.fi \
--cc=lihuafei1@huawei.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
--cc=vigneshr@ti.com \
--cc=yangjihong1@huawei.com \
--cc=zhangjinhao2@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).