From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9775EC4743C for ; Fri, 4 Jun 2021 16:59:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 743D0613B4 for ; Fri, 4 Jun 2021 16:59:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229809AbhFDRBl (ORCPT ); Fri, 4 Jun 2021 13:01:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52724 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229778AbhFDRBk (ORCPT ); Fri, 4 Jun 2021 13:01:40 -0400 Received: from mail.andi.de1.cc (mail.andi.de1.cc [IPv6:2a01:238:4321:8900:456f:ecd6:43e:202c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1F37BC061766; Fri, 4 Jun 2021 09:59:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=kemnade.info; s=20180802; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=fyoH9XSGLFwuTw5EZijjPB3huxIWStyfrRD0HZEDmpk=; b=lz8Wh0F0dlMv0vNhTtN3f39VWo nfsa+X01BHqfr4S1aKb0G0Otac73ejlkoQno40L8Yehul7b/+b8esPpkT2mAVJGHQOlK6NlCbVw+y 0UDrCGqp6F3qpN7FniKJk3CgUoD29/OxHWMwbzf5oPbaaNMuzAem42aGLiP0imhwHu+Q=; Received: from p200300ccff0b2a001a3da2fffebfd33a.dip0.t-ipconnect.de ([2003:cc:ff0b:2a00:1a3d:a2ff:febf:d33a] helo=aktux) by mail.andi.de1.cc with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1lpDAe-0000uR-L8; Fri, 04 Jun 2021 18:59:49 +0200 Date: Fri, 4 Jun 2021 18:59:43 +0200 From: Andreas Kemnade To: Tony Lindgren Cc: Bin Liu , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-omap@vger.kernel.org, letux-kernel@openphoenux.org Subject: Re: [PATCH] usb: musb: Check devctl status again for a spurious session request Message-ID: <20210604185943.3efa2a19@aktux> In-Reply-To: References: <20210518150615.53464-1-tony@atomide.com> <20210527211501.70d176b4@aktux> <20210604103533.6392beeb@aktux> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org On Fri, 4 Jun 2021 12:39:54 +0300 Tony Lindgren wrote: > * Andreas Kemnade [210604 08:35]: > > I inserted some more dev-dbg > > [ 60.241790] PM: suspend entry (deep) > > [ 60.245513] Filesystems sync: 0.000 seconds > > [ 60.251312] Freezing user space processes ... (elapsed 0.001 seconds) done. > > [ 60.260040] OOM killer disabled. > > [ 60.263275] Freezing remaining freezable tasks ... (elapsed 0.001 seconds) done. > > [ 60.272338] printk: Suspending console(s) (use no_console_suspend to debug) > > [ 60.281311] musb-omap2430 480ab000.usb_otg_hs: omap2430 runtime_resume > > -> this is triggered by what? > > I think that comes from the pm_runtime_get_sync() in musb_suspend(). > > > [ 60.281341] twl4030_usb 48070000.i2c:twl@48:twl4030-usb: twl4030_usb_runtime_resume > > -> and here something stays on... > > > > [ 60.346374] twl4030_usb 48070000.i2c:twl@48:twl4030-usb: twl4030_phy_power_on > > [ 60.796630] musb-hdrc musb-hdrc.0.auto: musb_suspend begin > > [ 60.796722] musb-hdrc musb-hdrc.0.auto: musb_suspend end > > [ 60.796752] musb-omap2430 480ab000.usb_otg_hs: omap2430 suspend > > [ 60.796783] musb-omap2430 480ab000.usb_otg_hs: omap2430 runtime_suspend > > [ 60.796783] twl4030_usb 48070000.i2c:twl@48:twl4030-usb: twl4030_phy_power_off > > [ 60.796813] twl4030_usb 48070000.i2c:twl@48:twl4030-usb: twl4030_usb_suspend > > [ 60.806549] Disabling non-boot CPUs ... > > [ 60.806579] Successfully put all powerdomains to target state > > Well since commit 88d26136a256 ("PM: Prevent runtime suspend during system resume") > nothing gets runtime idled during suspend with the extra pm_runtime_get_noresume() > call in device_prepare() that does not get released until in device_complete(). > > > forcing omap2430 runtime on before suspend: > > [ 160.467742] musb-omap2430 480ab000.usb_otg_hs: omap2430 runtime_resume > > [ 165.001495] PM: suspend entry (deep) > > [ 165.005218] Filesystems sync: 0.000 seconds > > [ 165.010284] Freezing user space processes ... (elapsed 0.001 seconds) done. > > [ 165.018981] OOM killer disabled. > > [ 165.022247] Freezing remaining freezable tasks ... (elapsed 0.001 seconds) done. > > [ 165.031311] printk: Suspending console(s) (use no_console_suspend to debug) > > [ 165.040496] musb-hdrc musb-hdrc.0.auto: musb_suspend begin > > [ 165.040618] musb-hdrc musb-hdrc.0.auto: musb_suspend end > > [ 165.040618] musb-omap2430 480ab000.usb_otg_hs: omap2430 suspend > > [ 165.040649] musb-omap2430 480ab000.usb_otg_hs: omap2430 runtime_suspend > > [ 165.040679] twl4030_usb 48070000.i2c:twl@48:twl4030-usb: twl4030_usb_suspend > > [ 165.050506] Disabling non-boot CPUs ... > > [ 165.050537] Successfully put all powerdomains to target state > > That's interesting. Hmm so we bail out early based on glue->is_runtime_suspended, > and omap3 is still probing devices with omap_device.c instead of ti-sysc.c, so > sounds like the duplicate calls you noticed might cause the issue. > > Does the following patch fix things for you or does something else break again? :) > sigh,.. ok, it breaks something. gadget (at least ecm) only works if musb/phy stuff is loaded, ecm configured via configfs rmmod omap2430 modprube 2430 until the next usb disconnect and another rmmod/modprobe is required. The following musb patches were applied additional to that one you added to this mail on top of 5.13-rc4. usb: musb: fix MUSB_QUIRK_B_DISCONNECT_99 handling usb: musb: Add missing PM suspend and resume functions for 2430 glue usb: musb: Check devctl status again for a spurious session request Regards, Andreas