From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: "Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Pali Rohár" <pali@kernel.org>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Joyce Ooi" <joyce.ooi@intel.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Jim Quinlan" <jim2101024@gmail.com>,
"Nicolas Saenz Julienne" <nsaenz@kernel.org>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
"Tom Joseph" <tjoseph@cadence.com>,
"Shawn Guo" <shawn.guo@linaro.org>,
"Rahul Tanwar" <rtanwar@maxlinear.com>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
"Serge Semin" <Sergey.Semin@baikalelectronics.ru>,
"Vidya Sagar" <vidyas@nvidia.com>,
"Jisheng Zhang" <jszhang@kernel.org>,
"Miaoqian Lin" <linmq006@gmail.com>,
"Ray Jui" <rjui@broadcom.com>,
"Scott Branden" <sbranden@broadcom.com>,
"Ryder Lee" <ryder.lee@mediatek.com>,
"Jianjun Wang" <jianjun.wang@mediatek.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Sergio Paracuellos" <sergio.paracuellos@gmail.com>,
"Shawn Lin" <shawn.lin@rock-chips.com>,
"Heiko Stuebner" <heiko@sntech.de>,
"Toan Le" <toan@os.amperecomputing.com>
Cc: Rob Herring <robh@kernel.org>,
linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
kernel@pengutronix.de,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
linux-rpi-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
linux-mediatek@lists.infradead.org,
linux-rockchip@lists.infradead.org
Subject: [PATCH 00/15] PCI: Convert to platform remove callback returning void
Date: Tue, 21 Mar 2023 20:31:53 +0100 [thread overview]
Message-ID: <20230321193208.366561-1-u.kleine-koenig@pengutronix.de> (raw)
Hello,
this series adapts the platform drivers below drivers/pci to use the
.remove_new() callback. Compared to the traditional .remove() callback
.remove_new() returns no value. This is a good thing because the driver core
doesn't (and cannot) cope for errors during remove. The only effect of a
non-zero return value in .remove() is that the driver core emits a warning. The
device is removed anyhow and an early return from .remove() usually yields a
resource leak.
By changing the remove callback to return void driver authors cannot
reasonably assume any more that there is some kind of cleanup later.
All drivers were easy to convert as they all returned zero in their
remove callback. Only for iproc the conversion wasn't trivial, the other
were converted using coccinelle.
There are no interdependencies between these patches. So even if there
are some concerns for individual patches, I ask you to apply the
remaining set. Then I only have to care for the review feedback of the
refused patches. (Having said that I don't expect any serious objection,
just things like squashing or separating patches, or maybe I picked a
wrong subject prefix.)
Best regards
Uwe
Uwe Kleine-König (15):
PCI: aardvark: Convert to platform remove callback returning void
PCI: altera: Convert to platform remove callback returning void
PCI: altera-msi: Convert to platform remove callback returning void
PCI: brcmstb: Convert to platform remove callback returning void
PCI: cadence/j721e: Convert to platform remove callback returning void
PCI: dwc/*: Convert to platform remove callback returning void
PCI: hisi-error: Convert to platform remove callback returning void
PCI: iproc: Convert to platform remove callback returning void
PCI: mediatek: Convert to platform remove callback returning void
PCI: mediatek-gen3: Convert to platform remove callback returning void
PCI: mt7621: Convert to platform remove callback returning void
PCI: mvebu: Convert to platform remove callback returning void
PCI: rockchip-host: Convert to platform remove callback returning void
PCI: tegra: Convert to platform remove callback returning void
PCI: xgene-msi: Convert to platform remove callback returning void
drivers/pci/controller/cadence/pci-j721e.c | 6 ++----
drivers/pci/controller/dwc/pcie-bt1.c | 6 ++----
drivers/pci/controller/dwc/pcie-histb.c | 6 ++----
drivers/pci/controller/dwc/pcie-intel-gw.c | 6 ++----
drivers/pci/controller/dwc/pcie-qcom-ep.c | 8 +++-----
drivers/pci/controller/dwc/pcie-tegra194.c | 8 +++-----
drivers/pci/controller/pci-aardvark.c | 6 ++----
drivers/pci/controller/pci-mvebu.c | 6 ++----
drivers/pci/controller/pci-tegra.c | 6 ++----
drivers/pci/controller/pci-xgene-msi.c | 6 ++----
drivers/pci/controller/pcie-altera-msi.c | 5 ++---
drivers/pci/controller/pcie-altera.c | 6 ++----
drivers/pci/controller/pcie-brcmstb.c | 6 ++----
drivers/pci/controller/pcie-hisi-error.c | 6 ++----
drivers/pci/controller/pcie-iproc-platform.c | 6 +++---
drivers/pci/controller/pcie-iproc.c | 4 +---
drivers/pci/controller/pcie-iproc.h | 2 +-
drivers/pci/controller/pcie-mediatek-gen3.c | 6 ++----
drivers/pci/controller/pcie-mediatek.c | 6 ++----
drivers/pci/controller/pcie-mt7621.c | 6 ++----
drivers/pci/controller/pcie-rockchip-host.c | 6 ++----
21 files changed, 43 insertions(+), 80 deletions(-)
base-commit: fe15c26ee26efa11741a7b632e9f23b01aca4cc6
--
2.39.2
next reply other threads:[~2023-03-21 19:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 19:31 Uwe Kleine-König [this message]
2023-03-21 19:31 ` [PATCH 05/15] PCI: cadence/j721e: Convert to platform remove callback returning void Uwe Kleine-König
2023-05-30 14:07 ` [PATCH 00/15] PCI: " Uwe Kleine-König
2023-06-02 21:37 ` Bjorn Helgaas
2023-06-06 16:02 ` Uwe Kleine-König
2023-06-24 14:23 ` Krzysztof Wilczyński
2023-06-11 13:24 ` Pali Rohár
2023-06-12 16:19 ` Bjorn Helgaas
2023-06-12 18:17 ` Pali Rohár
2023-06-24 14:19 ` Krzysztof Wilczyński
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230321193208.366561-1-u.kleine-koenig@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=Sergey.Semin@baikalelectronics.ru \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bhelgaas@google.com \
--cc=f.fainelli@gmail.com \
--cc=heiko@sntech.de \
--cc=jianjun.wang@mediatek.com \
--cc=jim2101024@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=joyce.ooi@intel.com \
--cc=jszhang@kernel.org \
--cc=kernel@pengutronix.de \
--cc=kw@linux.com \
--cc=linmq006@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-tegra@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=nsaenz@kernel.org \
--cc=pali@kernel.org \
--cc=rjui@broadcom.com \
--cc=robh@kernel.org \
--cc=rtanwar@maxlinear.com \
--cc=ryder.lee@mediatek.com \
--cc=sbranden@broadcom.com \
--cc=sergio.paracuellos@gmail.com \
--cc=shawn.guo@linaro.org \
--cc=shawn.lin@rock-chips.com \
--cc=thierry.reding@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=tjoseph@cadence.com \
--cc=toan@os.amperecomputing.com \
--cc=vidyas@nvidia.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).