From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 626D8C7EE2A for ; Wed, 17 May 2023 09:14:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229669AbjEQJOZ (ORCPT ); Wed, 17 May 2023 05:14:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58060 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229833AbjEQJOY (ORCPT ); Wed, 17 May 2023 05:14:24 -0400 Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id A1A1040EA; Wed, 17 May 2023 02:14:20 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 883A58117; Wed, 17 May 2023 09:14:19 +0000 (UTC) Date: Wed, 17 May 2023 12:14:18 +0300 From: Tony Lindgren To: Krzysztof Kozlowski Cc: Conor Dooley , Linus Walleij , Krzysztof Kozlowski , Nishanth Menon , linux-arm-kernel@lists.infradead.org, Vignesh Raghavendra , Rob Herring , devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-omap@vger.kernel.org Subject: Re: [PATCH v4 2/2] dt-bindings: pinctrl: Update pinctrl-single to use yaml Message-ID: <20230517091418.GT14287@atomide.com> References: <20230510095330.30742-1-tony@atomide.com> <20230510095330.30742-2-tony@atomide.com> <20230510124836.thqtol6qac762ggx@krzk-bin> <20230517080013.GS14287@atomide.com> <6e8ab385-8d4f-b1fc-e964-64149c085dd9@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6e8ab385-8d4f-b1fc-e964-64149c085dd9@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org * Krzysztof Kozlowski [230517 08:23]: > On 17/05/2023 10:00, Tony Lindgren wrote: > > Hi, > > > > * Krzysztof Kozlowski [230510 12:48]: > >> On Wed, 10 May 2023 12:53:29 +0300, Tony Lindgren wrote: > >>> Update binding for yaml and remove the old related txt bindings. Note that > >>> we are also adding the undocumented pinctrl-single,slew-rate property. And > >>> we only use the first example from the old binding. > > ... > >> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > >> on your patch (DT_CHECKER_FLAGS is new in v5.13): > >> > >> yamllint warnings/errors: > >> > >> dtschema/dtc warnings/errors: > >> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pinctrl/pinctrl-single.example.dtb: pinmux@4a100040: #pinctrl-cells: [[2]] is not of type 'object' > >> From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml > >> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pinctrl/pinctrl-single.example.dtb: pinmux@4a100040: #pinctrl-cells: [[2]] is not of type 'object' > >> From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml > >> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pinctrl/pinctrl-single.example.dtb: pinmux@4a100040: pinctrl-single,register-width: [[16]] is not of type 'object' > >> From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml > >> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pinctrl/pinctrl-single.example.dtb: pinmux@4a100040: pinctrl-single,register-width: [[16]] is not of type 'object' > >> From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml > >> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pinctrl/pinctrl-single.example.dtb: pinmux@4a100040: pinctrl-single,function-mask: [[65535]] is not of type 'object' > >> From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml > >> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pinctrl/pinctrl-single.example.dtb: pinmux@4a100040: pinctrl-single,function-mask: [[65535]] is not of type 'object' > >> From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml > >> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pinctrl/pinctrl-single.example.dtb: pinmux@4a100040: pinctrl-single,gpio-range: [[1, 0, 3, 0]] is not of type 'object' > >> From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml > >> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pinctrl/pinctrl-single.example.dtb: pinmux@4a100040: pinctrl-single,gpio-range: [[1, 0, 3, 0]] is not of type 'object' > >> From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml > > > > Looks like these are happening because of the patternProperties match for > > pin, will need to add more patterns like like -pin|_pin instead. > > It would be great if you can change _pin to -pin in all DTS. Underscores > are unwelcome. Yes np, I have a hackish script to change things to use -pins node naming for pin groups. Will send out patches this week. Regards, Tony