linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Aaro Koskinen <aaro.koskinen@iki.fi>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Janusz Krzysztofik <jmkrzyszt@gmail.com>,
	Tony Lindgren <tony@atomide.com>,
	linux-omap@vger.kernel.org
Subject: Re: [PATCH] ARM: omap1: Make serial wakeup GPIOs use descriptors
Date: Wed, 17 May 2023 22:06:48 +0300	[thread overview]
Message-ID: <20230517190648.GF271152@darkstar.musicnaut.iki.fi> (raw)
In-Reply-To: <20230517180344.GE271152@darkstar.musicnaut.iki.fi>

Hi,

On Wed, May 17, 2023 at 09:03:49PM +0300, Aaro Koskinen wrote:
> This patch (now also in gpio-descriptors-omap branch) does not
> compile:
> 
> On Sun, Apr 30, 2023 at 07:51:30PM +0200, Linus Walleij wrote:
> > +		pr_err("No interrupt for UART%d wake GPIO\n" idx + 1);
> 
> Comma is missing.                                          ^^^

And when tested something goes wrong:

[    2.555725] (NULL device *): using lookup tables for GPIO lookup
[    2.561950] (NULL device *): No GPIO consumer wakeup found
[    2.567871] Unable to get UART wakeup GPIO descriptor
[    2.573272] (NULL device *): using lookup tables for GPIO lookup
[    2.579498] (NULL device *): No GPIO consumer wakeup found
[    2.585357] Unable to get UART wakeup GPIO descriptor
[    2.590576] (NULL device *): using lookup tables for GPIO lookup
[    2.596954] (NULL device *): No GPIO consumer wakeup found
[    2.602813] Unable to get UART wakeup GPIO descriptor

There are now two tables with the NULL device - one in the board file,
and another in serial.c. Maybe that does not work?

A.

  reply	other threads:[~2023-05-17 19:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-30 17:51 [PATCH] ARM: omap1: Make serial wakeup GPIOs use descriptors Linus Walleij
2023-05-17 18:03 ` Aaro Koskinen
2023-05-17 19:06   ` Aaro Koskinen [this message]
2023-05-17 21:02     ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230517190648.GF271152@darkstar.musicnaut.iki.fi \
    --to=aaro.koskinen@iki.fi \
    --cc=jmkrzyszt@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).