From: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"kernel@pengutronix.de" <kernel@pengutronix.de>
Subject: Re: [PATCH 19/97] usb: dwc3-omap: Convert to platform remove callback returning void
Date: Tue, 23 May 2023 00:22:32 +0000 [thread overview]
Message-ID: <20230523002226.ew37ize2edvyc26b@synopsys.com> (raw)
In-Reply-To: <20230517230239.187727-20-u.kleine-koenig@pengutronix.de>
On Thu, May 18, 2023, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart from
> emitting a warning) and this typically results in resource leaks. To improve
> here there is a quest to make the remove callback return void. In the first
> step of this quest all drivers are converted to .remove_new() which already
> returns void. Eventually after all drivers are converted, .remove_new() is
> renamed to .remove().
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> drivers/usb/dwc3/dwc3-omap.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/usb/dwc3/dwc3-omap.c b/drivers/usb/dwc3/dwc3-omap.c
> index efaf0db595f4..d5c77db4daa9 100644
> --- a/drivers/usb/dwc3/dwc3-omap.c
> +++ b/drivers/usb/dwc3/dwc3-omap.c
> @@ -534,7 +534,7 @@ static int dwc3_omap_probe(struct platform_device *pdev)
> return ret;
> }
>
> -static int dwc3_omap_remove(struct platform_device *pdev)
> +static void dwc3_omap_remove(struct platform_device *pdev)
> {
> struct dwc3_omap *omap = platform_get_drvdata(pdev);
>
> @@ -543,8 +543,6 @@ static int dwc3_omap_remove(struct platform_device *pdev)
> of_platform_depopulate(omap->dev);
> pm_runtime_put_sync(&pdev->dev);
> pm_runtime_disable(&pdev->dev);
> -
> - return 0;
> }
>
> static const struct of_device_id of_dwc3_match[] = {
> @@ -611,7 +609,7 @@ static const struct dev_pm_ops dwc3_omap_dev_pm_ops = {
>
> static struct platform_driver dwc3_omap_driver = {
> .probe = dwc3_omap_probe,
> - .remove = dwc3_omap_remove,
> + .remove_new = dwc3_omap_remove,
> .driver = {
> .name = "omap-dwc3",
> .of_match_table = of_dwc3_match,
> --
> 2.39.2
>
Acked-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Thanks,
Thinh
next prev parent reply other threads:[~2023-05-23 0:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 23:01 [PATCH 00/97] usb: Convert to platform remove callback returning void Uwe Kleine-König
2023-05-17 23:01 ` [PATCH 19/97] usb: dwc3-omap: " Uwe Kleine-König
2023-05-23 0:22 ` Thinh Nguyen [this message]
2023-05-17 23:01 ` [PATCH 52/97] usb: ehci-omap: " Uwe Kleine-König
2023-05-17 23:02 ` [PATCH 68/97] usb: ohci-omap: " Uwe Kleine-König
2023-05-28 11:37 ` [PATCH 00/97] usb: " Greg Kroah-Hartman
2023-05-28 11:39 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230523002226.ew37ize2edvyc26b@synopsys.com \
--to=thinh.nguyen@synopsys.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).