* [PATCH] ARM: omap: Fix checkpatch issues
@ 2023-05-30 18:24 Franziska Naepelt
2023-05-31 5:27 ` Tony Lindgren
0 siblings, 1 reply; 2+ messages in thread
From: Franziska Naepelt @ 2023-05-30 18:24 UTC (permalink / raw)
To: linux-omap
Cc: aaro.koskinen, jmkrzyszt, tony, linux, linux-arm-kernel,
linux-kernel, Franziska Naepelt
This removes the following checkpatch issues:
- ERROR: space required after that ',' (ctx:VxV)
- WARNING: Comparisons should place the constant on the right side of the test
Signed-off-by: Franziska Naepelt <franziska.naepelt@gmail.com>
---
arch/arm/mach-omap1/sram-init.c | 2 +-
arch/arm/mach-omap2/sram.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/mach-omap1/sram-init.c b/arch/arm/mach-omap1/sram-init.c
index 26427d6be896..4cd4b50130ba 100644
--- a/arch/arm/mach-omap1/sram-init.c
+++ b/arch/arm/mach-omap1/sram-init.c
@@ -23,7 +23,7 @@
#define OMAP1_SRAM_PA 0x20000000
#define SRAM_BOOTLOADER_SZ 0x80
-#define ROUND_DOWN(value,boundary) ((value) & (~((boundary)-1)))
+#define ROUND_DOWN(value, boundary) ((value) & (~((boundary)-1)))
static void __iomem *omap_sram_base;
static unsigned long omap_sram_start;
diff --git a/arch/arm/mach-omap2/sram.c b/arch/arm/mach-omap2/sram.c
index 815d390109d2..e4c012ac4d28 100644
--- a/arch/arm/mach-omap2/sram.c
+++ b/arch/arm/mach-omap2/sram.c
@@ -45,7 +45,7 @@
#define GP_DEVICE 0x300
-#define ROUND_DOWN(value,boundary) ((value) & (~((boundary)-1)))
+#define ROUND_DOWN(value, boundary) ((value) & (~((boundary)-1)))
static unsigned long omap_sram_start;
static unsigned long omap_sram_size;
@@ -118,7 +118,7 @@ static void omap_sram_reset(void)
*/
static int is_sram_locked(void)
{
- if (OMAP2_DEVICE_TYPE_GP == omap_type()) {
+ if (omap_type() == OMAP2_DEVICE_TYPE_GP) {
/* RAMFW: R/W access to all initiators for all qualifier sets */
if (cpu_is_omap242x()) {
writel_relaxed(0xFF, OMAP24XX_VA_REQINFOPERM0); /* all q-vects */
base-commit: 7877cb91f1081754a1487c144d85dc0d2e2e7fc4
--
2.39.2 (Apple Git-143)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ARM: omap: Fix checkpatch issues
2023-05-30 18:24 [PATCH] ARM: omap: Fix checkpatch issues Franziska Naepelt
@ 2023-05-31 5:27 ` Tony Lindgren
0 siblings, 0 replies; 2+ messages in thread
From: Tony Lindgren @ 2023-05-31 5:27 UTC (permalink / raw)
To: Franziska Naepelt
Cc: linux-omap, aaro.koskinen, jmkrzyszt, linux, linux-arm-kernel,
linux-kernel, Franziska Naepelt
* Franziska Naepelt <franziska.naepelt@googlemail.com> [230530 21:26]:
> This removes the following checkpatch issues:
> - ERROR: space required after that ',' (ctx:VxV)
> - WARNING: Comparisons should place the constant on the right side of the test
Thanks applying into omap-for-v6.5/cleanup.
Tony
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-05-31 5:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-30 18:24 [PATCH] ARM: omap: Fix checkpatch issues Franziska Naepelt
2023-05-31 5:27 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).