From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58BA4C64E7A for ; Tue, 1 Dec 2020 11:39:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E9C9F2085B for ; Tue, 1 Dec 2020 11:39:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="t1FjgA+i" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730562AbgLALjA (ORCPT ); Tue, 1 Dec 2020 06:39:00 -0500 Received: from fllv0016.ext.ti.com ([198.47.19.142]:55718 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727838AbgLALjA (ORCPT ); Tue, 1 Dec 2020 06:39:00 -0500 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 0B1BbGV0069247; Tue, 1 Dec 2020 05:37:16 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1606822636; bh=jEq7ysfM/MmVZ2xizqReURrPG2TOZjPsyQUB6CXL2CQ=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=t1FjgA+iMGxkySYKNOTQMqmYhT2Omol3aisv1vYqNs19ZWzuq5wLqrI0uZ4WrXfWs X3WiC1RTtR9F62mZzusBD3zYNRYieRMAJ8r5eL3bkDq6hT3GsH+oc9ZzHHRRWIjH1B qz9ZxFKd8WJKwVLI0VlpQ+8hSZW1DJ4vzcpnuhns= Received: from DFLE114.ent.ti.com (dfle114.ent.ti.com [10.64.6.35]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 0B1BbG8j089583 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 1 Dec 2020 05:37:16 -0600 Received: from DFLE111.ent.ti.com (10.64.6.32) by DFLE114.ent.ti.com (10.64.6.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Tue, 1 Dec 2020 05:37:15 -0600 Received: from lelv0326.itg.ti.com (10.180.67.84) by DFLE111.ent.ti.com (10.64.6.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Tue, 1 Dec 2020 05:37:15 -0600 Received: from [192.168.2.6] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 0B1BbDtP074868; Tue, 1 Dec 2020 05:37:14 -0600 Subject: Re: [PATCH v4 71/80] drm/omap: dsi: move structs & defines to dsi.h To: Laurent Pinchart CC: Sebastian Reichel , Nikhil Devshatwar , , , Sekhar Nori , Tony Lindgren , References: <20201124124538.660710-1-tomi.valkeinen@ti.com> <20201124124538.660710-72-tomi.valkeinen@ti.com> <20201201003112.GP25713@pendragon.ideasonboard.com> From: Tomi Valkeinen Message-ID: <213843e4-3d14-7dc1-0250-8c9f254d02fb@ti.com> Date: Tue, 1 Dec 2020 13:37:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201201003112.GP25713@pendragon.ideasonboard.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org On 01/12/2020 02:31, Laurent Pinchart wrote: > Hi Tomi, > > Thank you for the patch. > > On Tue, Nov 24, 2020 at 02:45:29PM +0200, Tomi Valkeinen wrote: >> Move structs and defines to a private dsi.h header file to make dsi.c a >> bit easier to navigate. Also move the (now) private structs and defines >> from omapdss.h to dsi.h. > > I usually tend to keep structures used by a single .c file in that file, > but it's a matter of personal preference I suppose. We already had dsi.h. After all the recent changes, it was now only used by dsi.c. So I could have moved everything from there to dsi.c. But dsi.c was pretty crowded already, and I had trouble navigating it, so I thought it's better to move structs and macros from dsi.c to dsi.h. >> +struct dsi_reg { u16 module; u16 idx; }; > > How about using the common kernel coding style ? > > struct dsi_reg { > u16 module; > u16 idx; > }; Ok. Tomi -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki