From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9850EC43461 for ; Mon, 7 Sep 2020 16:12:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5C3D62177B for ; Mon, 7 Sep 2020 16:12:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="v5W+SMP/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730318AbgIGQKV (ORCPT ); Mon, 7 Sep 2020 12:10:21 -0400 Received: from fllv0015.ext.ti.com ([198.47.19.141]:39414 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729916AbgIGOd1 (ORCPT ); Mon, 7 Sep 2020 10:33:27 -0400 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 087EXOUX079209; Mon, 7 Sep 2020 09:33:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1599489204; bh=KCPnGV1i/mXb3dwVsRcfzbm3+yvLIM1pM8h2rceZWm4=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=v5W+SMP/ll1uyPqrH7gdBF4EFtvlq87kJLQ2ypsZqIFeP+2a3giWkZuWe7JUi60SE Mi3/0tXELvzSlDLYJ49yQOV5r0EDi7RdDunMKs6JCYsbbSmuIk8uG3+S4VuU2q+PLl fZVUoX5ufMMAY7QYgdGnLs1UcUiG3/qBdmQ86FRM= Received: from DFLE112.ent.ti.com (dfle112.ent.ti.com [10.64.6.33]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTP id 087EXOZc004527; Mon, 7 Sep 2020 09:33:24 -0500 Received: from DFLE109.ent.ti.com (10.64.6.30) by DFLE112.ent.ti.com (10.64.6.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Mon, 7 Sep 2020 09:33:24 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DFLE109.ent.ti.com (10.64.6.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Mon, 7 Sep 2020 09:33:24 -0500 Received: from [10.250.100.73] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 087EXMIG052342; Mon, 7 Sep 2020 09:33:22 -0500 Subject: Re: [PATCH net-next 9/9] net: ethernet: ti: ale: add support for multi port k3 cpsw versions To: Jakub Kicinski CC: "David S. Miller" , , Vignesh Raghavendra , Murali Karicheri , Sekhar Nori , , References: <20200904230924.9971-1-grygorii.strashko@ti.com> <20200904230924.9971-10-grygorii.strashko@ti.com> <20200904171022.63f103fa@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> From: Grygorii Strashko Message-ID: <282d021a-976f-df42-6e20-4af8d6812a19@ti.com> Date: Mon, 7 Sep 2020 17:33:21 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200904171022.63f103fa@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org Hi Jakub, On 05/09/2020 03:10, Jakub Kicinski wrote: > On Sat, 5 Sep 2020 02:09:24 +0300 Grygorii Strashko wrote: >> The TI J721E (CPSW9g) ALE version is similar, in general, to Sitara AM3/4/5 >> CPSW ALE, but has more extended functions and different ALE VLAN entry >> format. >> >> This patch adds support for for multi port TI J721E (CPSW9g) ALE variant. > > and: > > drivers/net/ethernet/ti/cpsw_ale.c:195:28: warning: symbol 'vlan_entry_k3_cpswxg' was not declared. Should it be static? > Thank you for your report, I've posted v2. I've had to install latest sparse version (0.6.2) manually to make it work properly. -- Best regards, grygorii