From: Alexander Sverdlin <alexander.sverdlin@gmail.com>
To: Arnd Bergmann <arnd@kernel.org>, soc@kernel.org
Cc: Arnd Bergmann <arnd@arndb.de>,
Russell King <linux@armlinux.org.uk>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Hartley Sweeten <hsweeten@visionengravers.com>,
Andre Przywara <andre.przywara@arm.com>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Vladimir Zapolskiy <vz@mleia.com>,
Aaro Koskinen <aaro.koskinen@iki.fi>,
Janusz Krzysztofik <jmkrzyszt@gmail.com>,
Tony Lindgren <tony@atomide.com>, Andrew Lunn <andrew@lunn.ch>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Gregory Clement <gregory.clement@bootlin.com>,
Daniel Mack <daniel@zonque.org>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Robert Jarzmik <robert.jarzmik@free.fr>,
Viresh Kumar <vireshk@kernel.org>,
Shiraz Hashim <shiraz.linux.kernel@gmail.com>,
Sudeep Holla <sudeep.holla@arm.com>,
Lorenzo Pieralisi <lpieralisi@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alan Stern <stern@rowland.harvard.edu>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
linux-clk@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH 02/13] ARM: ep93xx: fix missing-prototype warnings
Date: Tue, 16 May 2023 17:51:46 +0200 [thread overview]
Message-ID: <2abeb4d11e8274bc337e504c6b0b42e86899150a.camel@gmail.com> (raw)
In-Reply-To: <20230516153109.514251-3-arnd@kernel.org>
Hi Arnd!
On Tue, 2023-05-16 at 17:30 +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> ep93xx_clocksource_read() is only called from the file it is declared in,
> while ep93xx_timer_init() is declared in a header that is not included here.
>
> arch/arm/mach-ep93xx/timer-ep93xx.c:120:13: error: no previous prototype for 'ep93xx_timer_init'
> arch/arm/mach-ep93xx/timer-ep93xx.c:63:5: error: no previous prototype for 'ep93xx_clocksource_read'
>
> Fixes: 000bc17817bf ("ARM: ep93xx: switch to GENERIC_CLOCKEVENTS")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Alexander Sverdlin <alexander.sverdlin@gmail.com>
> ---
> arch/arm/mach-ep93xx/timer-ep93xx.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-ep93xx/timer-ep93xx.c b/arch/arm/mach-ep93xx/timer-ep93xx.c
> index dd4b164d1831..a9efa7bc2fa1 100644
> --- a/arch/arm/mach-ep93xx/timer-ep93xx.c
> +++ b/arch/arm/mach-ep93xx/timer-ep93xx.c
> @@ -9,6 +9,7 @@
> #include <linux/io.h>
> #include <asm/mach/time.h>
> #include "soc.h"
> +#include "platform.h"
>
> /*************************************************************************
> * Timer handling for EP93xx
> @@ -60,7 +61,7 @@ static u64 notrace ep93xx_read_sched_clock(void)
> return ret;
> }
>
> -u64 ep93xx_clocksource_read(struct clocksource *c)
> +static u64 ep93xx_clocksource_read(struct clocksource *c)
> {
> u64 ret;
--
Alexander Sverdlin.
next prev parent reply other threads:[~2023-05-16 15:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230516153109.514251-1-arnd@kernel.org>
[not found] ` <20230516153109.514251-2-arnd@kernel.org>
2023-05-16 15:41 ` [PATCH 01/13] ARM: davinci: fix davinci_cpufreq_init() declaration Bartosz Golaszewski
[not found] ` <20230516153109.514251-3-arnd@kernel.org>
2023-05-16 15:51 ` Alexander Sverdlin [this message]
[not found] ` <20230516153109.514251-4-arnd@kernel.org>
2023-05-16 15:58 ` [PATCH 03/13] ARM: highbank: add missing include Andre Przywara
[not found] ` <20230516153109.514251-10-arnd@kernel.org>
2023-05-16 16:17 ` [PATCH 09/13] ARM: orion5x: fix d2net gpio initialization Andrew Lunn
[not found] ` <20230516153109.514251-8-arnd@kernel.org>
2023-05-16 23:18 ` [PATCH 07/13] ARM: omap1: add missing include Aaro Koskinen
2023-05-17 5:58 ` Tony Lindgren
2023-05-17 5:58 ` Tony Lindgren
[not found] ` <20230516153109.514251-9-arnd@kernel.org>
2023-05-16 23:20 ` [PATCH 08/13] ARM: omap2: fix missing tick_broadcast() prototype Aaro Koskinen
[not found] ` <20230516153109.514251-6-arnd@kernel.org>
2023-05-16 23:34 ` [PATCH 05/13] ARM: imx: remove unused mx25_revision() Fabio Estevam
2023-05-17 6:39 ` Arnd Bergmann
2023-05-17 15:45 ` Martin Kaiser
2023-07-28 15:59 ` Arnd Bergmann
2023-07-30 16:26 ` Martin Kaiser
[not found] ` <20230516153109.514251-13-arnd@kernel.org>
2023-05-17 4:34 ` [PATCH 12/13] ARM: spear: include "pl080.h" for pl080_get_signal() prototype Viresh Kumar
[not found] ` <20230516153109.514251-7-arnd@kernel.org>
2023-05-23 20:17 ` [PATCH 06/13] ARM: lpc32xx: add missing include Vladimir Zapolskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2abeb4d11e8274bc337e504c6b0b42e86899150a.camel@gmail.com \
--to=alexander.sverdlin@gmail.com \
--cc=aaro.koskinen@iki.fi \
--cc=andre.przywara@arm.com \
--cc=andrew@lunn.ch \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=brgl@bgdev.pl \
--cc=daniel@zonque.org \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=gregory.clement@bootlin.com \
--cc=haojian.zhuang@gmail.com \
--cc=hsweeten@visionengravers.com \
--cc=jmkrzyszt@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lpieralisi@kernel.org \
--cc=mturquette@baylibre.com \
--cc=robert.jarzmik@free.fr \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=shawnguo@kernel.org \
--cc=shiraz.linux.kernel@gmail.com \
--cc=soc@kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=sudeep.holla@arm.com \
--cc=tony@atomide.com \
--cc=vireshk@kernel.org \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).