From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31DEEC433E0 for ; Wed, 24 Mar 2021 17:15:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0259F61A1C for ; Wed, 24 Mar 2021 17:15:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237028AbhCXROb (ORCPT ); Wed, 24 Mar 2021 13:14:31 -0400 Received: from fllv0015.ext.ti.com ([198.47.19.141]:45976 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236428AbhCXROP (ORCPT ); Wed, 24 Mar 2021 13:14:15 -0400 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 12OH8xbn002400; Wed, 24 Mar 2021 12:08:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1616605739; bh=+xl74nW14tlASuaYGR2l7ZDsHzZfrFL+BtukpRdGr00=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=ADAOy5hkFA9/vSDY7lHwj9LeXaux9srPlstV0mxmA+pgzGhvx9Rd5AYlFh+pAcblz m3+nsnGiD4g29M/4aO7PRwizqYKfy9tcwYlCeK3dW10vURdhCIBaKqeqI1aWU6LtkK vUeFPaDLT67AFDPVSA2xgBKSlvULXmBKnVjObEJo= Received: from DFLE111.ent.ti.com (dfle111.ent.ti.com [10.64.6.32]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 12OH8xYc080356 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 24 Mar 2021 12:08:59 -0500 Received: from DFLE108.ent.ti.com (10.64.6.29) by DFLE111.ent.ti.com (10.64.6.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Wed, 24 Mar 2021 12:08:59 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DFLE108.ent.ti.com (10.64.6.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2 via Frontend Transport; Wed, 24 Mar 2021 12:08:59 -0500 Received: from [10.250.33.213] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 12OH8wpi125558; Wed, 24 Mar 2021 12:08:58 -0500 Subject: Re: [PATCH] remoteproc: pru: Fix firmware loading crashes on K3 SoCs To: Mathieu Poirier CC: Bjorn Andersson , Grzegorz Jaszczyk , Jan Kiszka , Lokesh Vutla , Vignesh Raghavendra , , , , References: <20210315205859.19590-1-s-anna@ti.com> <20210323232014.GA1782475@xps15> From: Suman Anna Message-ID: <2f8bfc4f-e43d-5e38-fc6d-7045c69af364@ti.com> Date: Wed, 24 Mar 2021 12:08:53 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210323232014.GA1782475@xps15> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org On 3/23/21 6:20 PM, Mathieu Poirier wrote: > On Mon, Mar 15, 2021 at 03:58:59PM -0500, Suman Anna wrote: >> The K3 PRUs are 32-bit processors and in general have some limitations >> in using the standard ARMv8 memcpy function for loading firmware segments, >> so the driver already uses a custom memcpy implementation. This added >> logic however is limited to only IRAMs at the moment, but the loading >> into Data RAMs is not completely ok either and does generate a kernel >> crash for unaligned accesses. >> >> Fix these crashes by removing the existing IRAM logic limitation and >> extending the custom memcpy usage to Data RAMs as well for all K3 SoCs. >> >> Fixes: 1d39f4d19921 ("remoteproc: pru: Add support for various PRU cores on K3 AM65x SoCs") >> Signed-off-by: Suman Anna > > Probably a good idea to CC stable as well... > > Reviewed-by: Mathieu Poirier Thanks Mathieu. This patch is already staged on Bjorn's rproc-fixes branch though and part of linux-next since next-20210319. I have posted an additional 3-patch series for some more PRU fixes. Do you want me to post a v2 for those with stable Cc'd? regards Suman > >> --- >> drivers/remoteproc/pru_rproc.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/remoteproc/pru_rproc.c b/drivers/remoteproc/pru_rproc.c >> index 2667919d76b3..16979c1cd2f4 100644 >> --- a/drivers/remoteproc/pru_rproc.c >> +++ b/drivers/remoteproc/pru_rproc.c >> @@ -585,7 +585,7 @@ pru_rproc_load_elf_segments(struct rproc *rproc, const struct firmware *fw) >> break; >> } >> >> - if (pru->data->is_k3 && is_iram) { >> + if (pru->data->is_k3) { >> ret = pru_rproc_memcpy(ptr, elf_data + phdr->p_offset, >> filesz); >> if (ret) { >> -- >> 2.30.1 >>