Linux-OMAP Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH -next v2] ASoC: ti: omap-mcbsp: use devm_platform_ioremap_resource_byname
@ 2020-09-22  1:51 Qilong Zhang
  2020-10-01 22:47 ` Mark Brown
  2020-10-02 16:06 ` Gustavo A. R. Silva
  0 siblings, 2 replies; 3+ messages in thread
From: Qilong Zhang @ 2020-09-22  1:51 UTC (permalink / raw)
  To: broonie, peter.ujfalusi, jarkko.nikula, lgirdwood, perex, tiwai
  Cc: linux-omap

From: Zhang Qilong <zhangqilong3@huawei.com>

Use the devm_platform_ioremap_resource_byname() helper instead of
calling platform_get_resource_byname() and devm_ioremap_resource()
separately.

Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
---
 sound/soc/ti/omap-mcbsp.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/sound/soc/ti/omap-mcbsp.c b/sound/soc/ti/omap-mcbsp.c
index 6025b30bbe77..186cea91076f 100644
--- a/sound/soc/ti/omap-mcbsp.c
+++ b/sound/soc/ti/omap-mcbsp.c
@@ -620,11 +620,7 @@ static int omap_mcbsp_init(struct platform_device *pdev)
 	spin_lock_init(&mcbsp->lock);
 	mcbsp->free = true;
 
-	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "mpu");
-	if (!res)
-		res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-
-	mcbsp->io_base = devm_ioremap_resource(&pdev->dev, res);
+	mcbsp->io_base = devm_platform_ioremap_resource_byname(pdev, "mpu");
 	if (IS_ERR(mcbsp->io_base))
 		return PTR_ERR(mcbsp->io_base);
 
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH -next v2] ASoC: ti: omap-mcbsp: use devm_platform_ioremap_resource_byname
  2020-09-22  1:51 [PATCH -next v2] ASoC: ti: omap-mcbsp: use devm_platform_ioremap_resource_byname Qilong Zhang
@ 2020-10-01 22:47 ` Mark Brown
  2020-10-02 16:06 ` Gustavo A. R. Silva
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2020-10-01 22:47 UTC (permalink / raw)
  To: peter.ujfalusi, lgirdwood, jarkko.nikula, perex, Qilong Zhang, tiwai
  Cc: linux-omap

On Tue, 22 Sep 2020 09:51:23 +0800, Qilong Zhang wrote:
> Use the devm_platform_ioremap_resource_byname() helper instead of
> calling platform_get_resource_byname() and devm_ioremap_resource()
> separately.

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: ti: omap-mcbsp: use devm_platform_ioremap_resource_byname
      commit: 31e1fc4f11e2ede512221eba9e7291ab19ec66da

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH -next v2] ASoC: ti: omap-mcbsp: use devm_platform_ioremap_resource_byname
  2020-09-22  1:51 [PATCH -next v2] ASoC: ti: omap-mcbsp: use devm_platform_ioremap_resource_byname Qilong Zhang
  2020-10-01 22:47 ` Mark Brown
@ 2020-10-02 16:06 ` Gustavo A. R. Silva
  1 sibling, 0 replies; 3+ messages in thread
From: Gustavo A. R. Silva @ 2020-10-02 16:06 UTC (permalink / raw)
  To: Qilong Zhang, broonie, peter.ujfalusi, jarkko.nikula, lgirdwood,
	perex, tiwai
  Cc: linux-omap



On 9/21/20 20:51, Qilong Zhang wrote:
> From: Zhang Qilong <zhangqilong3@huawei.com>
> 
> Use the devm_platform_ioremap_resource_byname() helper instead of
> calling platform_get_resource_byname() and devm_ioremap_resource()
> separately.
> 
> Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
> ---
>  sound/soc/ti/omap-mcbsp.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/sound/soc/ti/omap-mcbsp.c b/sound/soc/ti/omap-mcbsp.c
> index 6025b30bbe77..186cea91076f 100644
> --- a/sound/soc/ti/omap-mcbsp.c
> +++ b/sound/soc/ti/omap-mcbsp.c
> @@ -620,11 +620,7 @@ static int omap_mcbsp_init(struct platform_device *pdev)
>  	spin_lock_init(&mcbsp->lock);
>  	mcbsp->free = true;
>  
> -	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "mpu");
> -	if (!res)
> -		res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -
> -	mcbsp->io_base = devm_ioremap_resource(&pdev->dev, res);
> +	mcbsp->io_base = devm_platform_ioremap_resource_byname(pdev, "mpu");
>  	if (IS_ERR(mcbsp->io_base))
>  		return PTR_ERR(mcbsp->io_base);
>  
> 

And then what happens with the code below?

        mcbsp->phys_base = res->start;
        mcbsp->reg_cache_size = resource_size(res);


Now, you end up with an uninitialized pointer read.

This is wrong.

--
Gustavo

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-22  1:51 [PATCH -next v2] ASoC: ti: omap-mcbsp: use devm_platform_ioremap_resource_byname Qilong Zhang
2020-10-01 22:47 ` Mark Brown
2020-10-02 16:06 ` Gustavo A. R. Silva

Linux-OMAP Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-omap/0 linux-omap/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-omap linux-omap/ https://lore.kernel.org/linux-omap \
		linux-omap@vger.kernel.org
	public-inbox-index linux-omap

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-omap


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git