Linux-OMAP Archive on lore.kernel.org
 help / color / Atom feed
From: Guillaume Tucker <guillaume.tucker@collabora.com>
To: Suman Anna <s-anna@ti.com>, Tony Lindgren <tony@atomide.com>
Cc: Tero Kristo <t-kristo@ti.com>,
	devicetree@vger.kernel.org, linux-omap@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, kernelci-results@groups.io
Subject: Re: [PATCH 06/13] ARM: dts: omap4-panda-common: Add CMA pools and enable IPU & DSP
Date: Wed, 12 Aug 2020 06:31:27 +0100
Message-ID: <3e44fc46-07ac-6103-5c4d-8c7389453b87@collabora.com> (raw)
In-Reply-To: <20200709231954.1973-7-s-anna@ti.com>

On 10/07/2020 00:19, Suman Anna wrote:
> The CMA reserved memory nodes have been added for the IPU and DSP
> remoteproc devices on all the OMAP4-based Panda boards. These nodes
> are assigned to the respective rproc device nodes, and both the
> IPU and DSP remote processors are enabled for all these boards.
> 
> The current CMA pools and sizes are defined statically for each device.
> The starting addresses are fixed to meet current dependencies on the
> remote processor firmwares, and will go away when the remote-side
> code has been improved to gather this information runtime during
> its initialization.
> 
> An associated pair of the rproc node and its CMA node can be disabled
> later on if there is no use-case defined to use that remote processor.
> 
> Signed-off-by: Suman Anna <s-anna@ti.com>
> ---
>  arch/arm/boot/dts/omap4-panda-common.dtsi | 30 +++++++++++++++++++++++
>  1 file changed, 30 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/omap4-panda-common.dtsi b/arch/arm/boot/dts/omap4-panda-common.dtsi
> index 55ea8b6189af..ef79028fc95f 100644
> --- a/arch/arm/boot/dts/omap4-panda-common.dtsi
> +++ b/arch/arm/boot/dts/omap4-panda-common.dtsi
> @@ -12,6 +12,26 @@ memory@80000000 {
>  		reg = <0x80000000 0x40000000>; /* 1 GB */
>  	};
>  
> +	reserved-memory {
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +		ranges;
> +
> +		dsp_memory_region: dsp-memory@98000000 {
> +			compatible = "shared-dma-pool";
> +			reg = <0x98000000 0x800000>;
> +			reusable;
> +			status = "okay";
> +		};
> +
> +		ipu_memory_region: ipu-memory@98800000 {
> +			compatible = "shared-dma-pool";
> +			reg = <0x98800000 0x7000000>;
> +			reusable;
> +			status = "okay";
> +		};
> +	};
> +
>  	chosen {
>  		stdout-path = &uart3;
>  	};
> @@ -571,3 +591,13 @@ hdmi_out: endpoint {
>  		};
>  	};
>  };
> +
> +&dsp {
> +	status = "okay";
> +	memory-region = <&dsp_memory_region>;
> +};
> +
> +&ipu {
> +	status = "okay";
> +	memory-region = <&ipu_memory_region>;
> +};
> 

This appears to be causing some BUG alert messages:

  BUG: Bad page state in process swapper/0  pfn:9c801

as reported on kernelci.org:

  https://kernelci.org/test/case/id/5f326c6661360154c452c1c9/

I've run a bisection and it landed on this commit.  If you fix it
with another patch, please add:

  Reported-by: "kernelci.org bot" <bot@kernelci.org>

Hope this helps!

Thanks,
Guillaume


  reply index

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-09 23:19 [PATCH 00/13] Add IPU & DSP remoteprocs on OMAP4 and OMAP5 Suman Anna
2020-07-09 23:19 ` [PATCH 01/13] ARM: dts: omap4: Add timer_sys_ck clocks for timers Suman Anna
2020-07-09 23:19 ` [PATCH 02/13] ARM: dts: omap5: " Suman Anna
2020-07-09 23:19 ` [PATCH 03/13] ARM: dts: omap4: Update the DSP node Suman Anna
2020-07-09 23:19 ` [PATCH 04/13] ARM: dts: omap4: Add IPU DT node Suman Anna
2020-07-09 23:19 ` [PATCH 05/13] ARM: dts: omap4: Add aliases for rproc nodes Suman Anna
2020-07-09 23:19 ` [PATCH 06/13] ARM: dts: omap4-panda-common: Add CMA pools and enable IPU & DSP Suman Anna
2020-08-12  5:31   ` Guillaume Tucker [this message]
2020-08-14 14:32     ` Guillaume Tucker
2020-08-14 15:26       ` Suman Anna
2020-08-14 16:33         ` Guillaume Tucker
2020-08-14 19:33           ` Suman Anna
2020-08-20  9:17             ` Guillaume Tucker
2020-07-09 23:19 ` [PATCH 07/13] ARM: dts: omap4-panda-common:: Add system timers to DSP and IPU Suman Anna
2020-07-09 23:19 ` [PATCH 08/13] ARM: dts: omap5: Add DSP and IPU nodes Suman Anna
2020-07-09 23:19 ` [PATCH 09/13] ARM: dts: omap5: Add aliases for rproc nodes Suman Anna
2020-07-09 23:19 ` [PATCH 10/13] ARM: dts: omap5-uevm: Add CMA pools and enable IPU & DSP Suman Anna
2020-07-09 23:19 ` [PATCH 11/13] ARM: dts: omap5-uevm: Add system timers to DSP and IPU Suman Anna
2020-07-09 23:19 ` [PATCH 12/13] ARM: dts: omap4-panda-common: Add watchdog timers for IPU and DSP Suman Anna
2020-07-09 23:19 ` [PATCH 13/13] ARM: dts: omap5-uevm: " Suman Anna
2020-07-10 16:58 ` [PATCH 00/13] Add IPU & DSP remoteprocs on OMAP4 and OMAP5 Tony Lindgren
2020-07-10 17:17   ` Suman Anna
2020-07-10 17:28     ` Suman Anna
2020-07-10 17:59       ` Tony Lindgren
2020-07-10 18:29         ` Suman Anna
2020-07-10 20:45           ` Suman Anna
2020-07-10 22:08             ` Tony Lindgren
2020-07-10 17:40     ` Tony Lindgren
2020-07-10 18:24       ` Suman Anna
2020-07-13 18:24 ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3e44fc46-07ac-6103-5c4d-8c7389453b87@collabora.com \
    --to=guillaume.tucker@collabora.com \
    --cc=devicetree@vger.kernel.org \
    --cc=kernelci-results@groups.io \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=s-anna@ti.com \
    --cc=t-kristo@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-OMAP Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-omap/0 linux-omap/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-omap linux-omap/ https://lore.kernel.org/linux-omap \
		linux-omap@vger.kernel.org
	public-inbox-index linux-omap

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-omap


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git