linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Roger Quadros <rogerq@ti.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
	YueHaibing <yuehaibing@huawei.com>
Cc: <tony@atomide.com>, <ladis@linux-mips.org>,
	<bbrezillon@kernel.org>, <peter.ujfalusi@ti.com>,
	<linux-omap@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] memory: omap-gpmc: Fix build error without CONFIG_OF
Date: Thu, 27 Aug 2020 19:37:18 +0300	[thread overview]
Message-ID: <45d3fa05-01e8-c879-e314-ae627ca4c266@ti.com> (raw)
In-Reply-To: <20200827132154.GB4384@kozik-lap>



On 27/08/2020 16:21, Krzysztof Kozlowski wrote:
> On Thu, Aug 27, 2020 at 08:53:16PM +0800, YueHaibing wrote:
>> If CONFIG_OF is n, gcc fails:
>>
>> drivers/memory/omap-gpmc.o: In function `gpmc_omap_onenand_set_timings':
>> omap-gpmc.c:(.text+0x2a88): undefined reference to `gpmc_read_settings_dt'
>>
>> Add gpmc_read_settings_dt() helper function, which zero the gpmc_settings
>> so the caller doesn't proceed with random/invalid settings.
>>
>> Fixes: a758f50f10cf ("mtd: onenand: omap2: Configure driver from DT")
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>> ---
>> v3: zero gpmc_settings
>> v2: add gpmc_read_settings_dt() stub
>> ---
>>   drivers/memory/omap-gpmc.c | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c
>> index cd9e80748591..e026b4cd3612 100644
>> --- a/drivers/memory/omap-gpmc.c
>> +++ b/drivers/memory/omap-gpmc.c
>> @@ -2310,6 +2310,10 @@ static void gpmc_probe_dt_children(struct platform_device *pdev)
>>   	}
>>   }
>>   #else
>> +void gpmc_read_settings_dt(struct device_node *np, struct gpmc_settings *p)
>> +{
>> +	memset(p, 0, sizeof(struct gpmc_settings));
> 
> sizeof(*p) but if patch is otherwise ok (got review/ack) then I can fix
> it while applying.
> 
> If there is resend, please fix it as well.

With the sizeof(*p) change.

Acked-by: Roger Quadros <rogerq@ti.com>

cheers,
-roger
-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

  reply	other threads:[~2020-08-27 16:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-18 12:53 [PATCH] memory: omap-gpmc: Fix build error without CONFIG_OF YueHaibing
2020-08-18 13:00 ` Krzysztof Kozlowski
2020-08-26 12:59 ` [PATCH v2] " YueHaibing
2020-08-27  9:27   ` Roger Quadros
2020-08-27 12:53   ` [PATCH v3] " YueHaibing
2020-08-27 13:21     ` Krzysztof Kozlowski
2020-08-27 16:37       ` Roger Quadros [this message]
2020-08-27 19:31         ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45d3fa05-01e8-c879-e314-ae627ca4c266@ti.com \
    --to=rogerq@ti.com \
    --cc=bbrezillon@kernel.org \
    --cc=krzk@kernel.org \
    --cc=ladis@linux-mips.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=peter.ujfalusi@ti.com \
    --cc=tony@atomide.com \
    --cc=yuehaibing@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).