linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Koen Kooi <koen@dominion.thruhere.net>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: "linux-omap@vger.kernel.org List" <linux-omap@vger.kernel.org>,
	Tomi Valkeinen <tomi.valkeinen@nokia.com>,
	Tony Lindgren <tony@atomide.com>
Subject: Re: [PATCH v9] board-omap3-beagle: add DSS2 support
Date: Thu, 6 May 2010 11:53:19 +0200	[thread overview]
Message-ID: <4C3B4B84-D66F-457A-8002-9A77B74DC13D@dominion.thruhere.net> (raw)
In-Reply-To: <l2l94a0d4531005020858l1a79e4f3hf632a7fab4e4ff33@mail.gmail.com>


Op 2 mei 2010, om 17:58 heeft Felipe Contreras het volgende geschreven:
> 
> I also have these changes in one of my trees backported from Tomi
> Valkeinen's tree. I'm attaching the diff; some of these are cosmetic,
> but I think the gpio changes make sense, although I don't know if
> omap_mux_init_gpio is really needed.
> 
> I think the current proposed patch should go in already, I don't know
> what we are waiting for.
> 
> --- a/arch/arm/mach-omap2/board-omap3beagle.c
> +++ b/arch/arm/mach-omap2/board-omap3beagle.c
> 
> +#if 0
> +	/* is this really needed? */
> +	omap_mux_init_gpio(beagle_dvi_device.reset_gpio, OMAP_PIN_INPUT);
> +#endif
> 	r = gpio_request(beagle_dvi_device.reset_gpio, "DVI reset");
> 
> -	omap_mux_init_gpio(170, OMAP_PIN_INPUT);
> -	gpio_request(170, "DVI_nPD");
> -	/* REVISIT leave DVI powered down until it's needed ... */
> -	gpio_direction_output(170, true);
> -

I have a similar change queued since the new beagle xM moves DVI reset to gpio129, but I'm holding off on sending beagle patches here till the hardware design is finalized.

regards,

Koen

  reply	other threads:[~2010-05-06  9:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-22  8:23 [PATCH v9] board-omap3-beagle: add DSS2 support Koen Kooi
2010-04-27  7:58 ` Koen Kooi
2010-04-27 13:27   ` Thomas Weber
2010-05-02 15:58   ` Felipe Contreras
2010-05-06  9:53     ` Koen Kooi [this message]
2010-05-03 14:15 ` Tomi Valkeinen
2010-05-05  6:46   ` Koen Kooi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C3B4B84-D66F-457A-8002-9A77B74DC13D@dominion.thruhere.net \
    --to=koen@dominion.thruhere.net \
    --cc=felipe.contreras@gmail.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=tomi.valkeinen@nokia.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).