From: Kim Kyuwon <chammoru@gmail.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: OMAP <linux-omap@vger.kernel.org>,
Kevin Hilman <khilman@deeprootsystems.com>,
kyungmin.park@samsung.com, Tony Lindgren <tony@atomide.com>,
bhmin@samsung.com
Subject: Re: [PATCH] OMAP3 clock: Access only available clock bits
Date: Mon, 23 Mar 2009 10:23:31 +0900 [thread overview]
Message-ID: <4d34a0a70903221823o40bcc347y433447664571c2c6@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.00.0903201523220.4676@utopia.booyaka.com>
Hi Paul,
On Sat, Mar 21, 2009 at 6:48 AM, Paul Walmsley <paul@pwsan.com> wrote:
> Hello Kyuwon,
>
> On Fri, 20 Mar 2009, Kim Kyuwon wrote:
>
>> I found a problem on PM Branch with OMAP3430 ES3.1 Board when enabling
>> OMAP_RESET_CLOCKS feature.
>> In clk_disable_unsed() function, as soon as sad2d_ick is disabled,
>> prcm interrupt is generated and its handler can't exit loop at next
>> statement!
>>
>> while (prm_read_mod_reg(OCP_MOD, OMAP2_PRM_IRQSTATUS_MPU_OFFSET));
>
> We encountered a similar problem a few months ago. The problem is
> probably the pad mux settings on the d2d_mstdby and d2d_swakeup pads.
> These are usually configured by the bootloader. My recollection is that
> they should be pulled up, but I don't recall for sure. Yes, we should
> have a patch in the PM branch to at least detect whether these pads are
> configured incorrectly...
Thank you for letting me know the better solution. I confirmed that
this problem can be fixed by configuring the d2d_mstdby and
d2d_swakeup pads. (As you said, swakeup -> pulled down & mstdby ->
pulled up.)
>> I also found that sad2d_ick is available only OMAP3430 ES1. I fixed
>> this problem with below patch.
>
> Thanks for your patch, but, sad2d_ick is indeed present on ES2+. TI
> removed the documenation from the main TRM and moved it to the "OMAP34xx
> Stacked Mode Addendum" (SWCU048). Ill-advised, in my opinion!
>
I have only the "OMAP34xx ES3.0 Stacked Mode Addendum" and I can see
EN_SAD2D is available in this document. ES3.1 is maybe same.
I think this patch is not needed anymore. Thank you so much for your help!
Regards,
Kyuwon
next prev parent reply other threads:[~2009-03-23 1:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-20 3:15 [PATCH] OMAP3 clock: Access only available clock bits Kim Kyuwon
2009-03-20 21:48 ` Paul Walmsley
2009-03-20 21:56 ` Paul Walmsley
2009-03-23 1:23 ` Kim Kyuwon [this message]
2009-03-23 6:40 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d34a0a70903221823o40bcc347y433447664571c2c6@mail.gmail.com \
--to=chammoru@gmail.com \
--cc=bhmin@samsung.com \
--cc=khilman@deeprootsystems.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).