From: Florian Vaussard <florian.vaussard@epfl.ch>
To: Mugunthan V N <mugunthanvnm@ti.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
devicetree-discuss@lists.ozlabs.org, linux-omap@vger.kernel.org,
benoit.cousson@linaro.org, paul@pwsan.com
Subject: Re: [net-next PATCH v4 3/5] ARM: dts: AM33XX: Add pinmux configuration for CPSW to beaglebone
Date: Thu, 06 Jun 2013 09:06:21 +0200 [thread overview]
Message-ID: <51B034ED.7040603@epfl.ch> (raw)
In-Reply-To: <1370452099-24026-4-git-send-email-mugunthanvnm@ti.com>
Hello,
On 06/05/2013 07:08 PM, Mugunthan V N wrote:
> Add pinmux configurations for MII based CPSW ethernet to am335x-bone.
> In this patch, only single named mode/state is added and these pins
> are configured during pinctrl driver initialization.
>
> Default mode is nothing but the values required for the module during
> active state. With this configurations module is functional as
> expected.
>
> Todo:
> - if an idle state is available for pins, add support for it.
>
> Signed-off-by: Mugunthan V N <mugunthanvnm@ti.com>
> ---
> arch/arm/boot/dts/am335x-bone.dts | 38 +++++++++++++++++++++++++++++++++++++
> 1 file changed, 38 insertions(+)
>
> diff --git a/arch/arm/boot/dts/am335x-bone.dts b/arch/arm/boot/dts/am335x-bone.dts
> index 4b5a8e0..008a13b 100644
> --- a/arch/arm/boot/dts/am335x-bone.dts
> +++ b/arch/arm/boot/dts/am335x-bone.dts
> @@ -36,6 +36,33 @@
> 0x60 0x17 /* gpmc_a8.gpio1_24, OUTPUT_PULLUP | MODE7 */
> >;
> };
> +
> + cpsw_default: cpsw_default {
> + pinctrl-single,pins = <
> + /* Slave 1 */
> + 0x110 0x20 /* mii1_rxerr.mii1_rxerr, MODE0 | INPUT */
Here I guess that the comment should be INPUT_PULLDOWN, instead of INPUT.
> + 0x114 0x0 /* mii1_txen.mii1_txen, MODE0 | OUTPUT */
As bit PULLUDENABLE is 0, the pulldown is enabled according to the TRM,
right?
Is this a desirable behaviour, as it will consume power when outputting
a high level?
And consequently, the comment should probably be OUTPUT_PULLDOWN, no?
> + 0x118 0x20 /* mii1_rxdv.mii1_rxdv, MODE0 | INPUT_PULLDOWN */
> + 0x11c 0x0 /* mii1_txd3.mii1_txd3, MODE0 | OUTPUT */
> + 0x120 0x0 /* mii1_txd2.mii1_txd2, MODE0 | OUTPUT */
> + 0x124 0x0 /* mii1_txd1.mii1_txd1, MODE0 | OUTPUT */
> + 0x128 0x0 /* mii1_txd0.mii1_txd0, MODE0 | OUTPUT */
Same questions here.
> + 0x12c 0x20 /* mii1_txclk.mii1_txclk, MODE0 | INPUT_PULLDOWN */
> + 0x130 0x20 /* mii1_rxclk.mii1_rxclk, MODE0 | INPUT_PULLDOWN */
> + 0x134 0x20 /* mii1_rxd3.mii1_rxd3, MODE0 | INPUT_PULLDOWN */
> + 0x138 0x20 /* mii1_rxd2.mii1_rxd2, MODE0 | INPUT_PULLDOWN */
> + 0x13c 0x20 /* mii1_rxd1.mii1_rxd1, MODE0 | INPUT_PULLDOWN */
> + 0x140 0x20 /* mii1_rxd0.mii1_rxd0, MODE0 | INPUT_PULLDOWN */
> + >;
> + };
> +
> + davinci_mdio_default: davinci_mdio_default {
> + pinctrl-single,pins = <
> + /* MDIO */
> + 0x148 0x30 /* mdio_data.mdio_data, MODE0 | INPUT_PULLUP */
> + 0x14c 0x10 /* mdio_clk.mdio_clk, MODE0 | OUTPUT_PULLUP */
> + >;
> + };
> };
>
> ocp {
> @@ -138,3 +165,14 @@
> phy_id = <&davinci_mdio>, <1>;
> phy-mode = "mii";
> };
> +
> +&mac {
> + pinctrl-names = "default";
> + pinctrl-0 = <&cpsw_default>;
> +
> +};
> +
> +&davinci_mdio {
> + pinctrl-names = "default";
> + pinctrl-0 = <&davinci_mdio_default>;
> +};
>
Regards,
Florian
next prev parent reply other threads:[~2013-06-06 7:06 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-05 17:08 [net-next PATCH v4 0/5] Adding pinctrl PM support for CPSW and MDIO Mugunthan V N
2013-06-05 17:08 ` [net-next PATCH v4 1/5] net: cpsw: enhance pinctrl support Mugunthan V N
[not found] ` <1370452099-24026-2-git-send-email-mugunthanvnm-l0cyMroinI0@public.gmane.org>
2013-06-05 19:23 ` Mark Brown
2013-06-06 5:59 ` Mugunthan V N
2013-06-06 8:50 ` Mark Brown
2013-06-07 7:31 ` Linus Walleij
2013-06-07 7:42 ` David Miller
2013-06-07 14:49 ` Mugunthan V N
2013-06-10 15:48 ` Linus Walleij
2013-06-13 9:54 ` David Miller
2013-06-05 17:08 ` [net-next PATCH v4 2/5] net: davinci_mdio: " Mugunthan V N
2013-06-05 17:08 ` [net-next PATCH v4 3/5] ARM: dts: AM33XX: Add pinmux configuration for CPSW to beaglebone Mugunthan V N
2013-06-06 7:06 ` Florian Vaussard [this message]
[not found] ` <51B034ED.7040603-p8DiymsW2f8@public.gmane.org>
2013-06-06 8:21 ` Mugunthan V N
2013-06-05 17:08 ` [net-next PATCH v4 4/5] ARM: dts: AM33XX: Add pinmux configuration for CPSW to EVMsk Mugunthan V N
2013-06-05 17:08 ` [net-next PATCH v4 5/5] ARM: dts: AM33XX: Add pinmux configuration for CPSW to am335x EVM Mugunthan V N
2013-06-06 7:42 ` [net-next PATCH v4 0/5] Adding pinctrl PM support for CPSW and MDIO Benoit Cousson
2013-06-06 8:27 ` Mugunthan V N
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B034ED.7040603@epfl.ch \
--to=florian.vaussard@epfl.ch \
--cc=benoit.cousson@linaro.org \
--cc=davem@davemloft.net \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linux-omap@vger.kernel.org \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
--cc=paul@pwsan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).