Linux-OMAP Archive on lore.kernel.org
 help / color / Atom feed
From: Suman Anna <s-anna@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: <linux-omap@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	Tero Kristo <t-kristo@ti.com>
Subject: Re: [PATCH 00/13] Add IPU & DSP remoteprocs on OMAP4 and OMAP5
Date: Fri, 10 Jul 2020 15:45:42 -0500
Message-ID: <557ebada-4a2f-32ed-fbea-2daba8daa073@ti.com> (raw)
In-Reply-To: <bc05fbe7-be02-e44e-3461-69f7c06b7d34@ti.com>

On 7/10/20 1:29 PM, Suman Anna wrote:
> On 7/10/20 12:59 PM, Tony Lindgren wrote:
>> * Suman Anna <s-anna@ti.com> [200710 17:29]:
>>> FYI, the following one-line removal is enough for me to not see the 
>>> error.
>>>
>>> diff --git a/arch/arm/mach-omap2/vc.c b/arch/arm/mach-omap2/vc.c
>>> index 86f1ac4c2412..b80c9dff81c4 100644
>>> --- a/arch/arm/mach-omap2/vc.c
>>> +++ b/arch/arm/mach-omap2/vc.c
>>> @@ -44,7 +44,6 @@
>>>   #define OMAP4_VDD_DEFAULT_VAL  \
>>>          (OMAP4430_VDD_I2C_DISABLE_MASK | \
>>>           OMAP4430_VDD_IVA_PRESENCE | OMAP4430_VDD_MPU_PRESENCE | \
>>> -        OMAP4430_AUTO_CTRL_VDD_IVA(OMAP4430_AUTO_CTRL_VDD_RET) | \
>>>           OMAP4430_AUTO_CTRL_VDD_MPU(OMAP4430_AUTO_CTRL_VDD_RET) | \
>>>           OMAP4430_AUTO_CTRL_VDD_CORE(OMAP4430_AUTO_CTRL_VDD_RET))
>>>
>>
>> OK.
>>
>> Below is an untested attempt to sync the 4460 opp values with
>> what earlier TI kernels had. Not sure if this help, might be worth
>> testing :) My pandaboard-es seems to have a corrupt sdio card.
> 
> Yeah, mine is the regular pandaboard with 4430, so the below patch will 
> not make any difference.
> 
> regards
> Suman
> 
>>
>> Regards,
>>
>> Tony
>>
>> 8< ---------------------
>> diff --git a/arch/arm/mach-omap2/opp4xxx_data.c 
>> b/arch/arm/mach-omap2/opp4xxx_data.c
>> --- a/arch/arm/mach-omap2/opp4xxx_data.c
>> +++ b/arch/arm/mach-omap2/opp4xxx_data.c
>> @@ -66,21 +66,23 @@ struct omap_volt_data 
>> omap443x_vdd_core_volt_data[] = {
>>   };
>>   #define OMAP4460_VDD_MPU_OPP50_UV        1025000
>> -#define OMAP4460_VDD_MPU_OPP100_UV        1200000
>> -#define OMAP4460_VDD_MPU_OPPTURBO_UV        1313000
>> -#define OMAP4460_VDD_MPU_OPPNITRO_UV        1375000
>> +#define OMAP4460_VDD_MPU_OPP100_UV        1203000
>> +#define OMAP4460_VDD_MPU_OPPTURBO_UV        1317000
>> +#define OMAP4460_VDD_MPU_OPPNITRO_UV        1380000
>> +#define OMAP4460_VDD_MPU_OPPNITROSB_UV        1390000

I am not sure about this, I see it as 1380 for both OPPNITRO and OPPNITROSB.

>>   struct omap_volt_data omap446x_vdd_mpu_volt_data[] = {
>>       VOLT_DATA_DEFINE(OMAP4460_VDD_MPU_OPP50_UV, 
>> OMAP44XX_CONTROL_FUSE_MPU_OPP50, 0xf4, 0x0c),
>>       VOLT_DATA_DEFINE(OMAP4460_VDD_MPU_OPP100_UV, 
>> OMAP44XX_CONTROL_FUSE_MPU_OPP100, 0xf9, 0x16),
>>       VOLT_DATA_DEFINE(OMAP4460_VDD_MPU_OPPTURBO_UV, 
>> OMAP44XX_CONTROL_FUSE_MPU_OPPTURBO, 0xfa, 0x23),
>>       VOLT_DATA_DEFINE(OMAP4460_VDD_MPU_OPPNITRO_UV, 
>> OMAP44XX_CONTROL_FUSE_MPU_OPPNITRO, 0xfa, 0x27),
>> +    VOLT_DATA_DEFINE(OMAP4460_VDD_MPU_OPPNITROSB_UV, 
>> OMAP44XX_CONTROL_FUSE_MPU_OPPNITROSB, 0xfa, 0x27),
>>       VOLT_DATA_DEFINE(0, 0, 0, 0),
>>   };
>> -#define OMAP4460_VDD_IVA_OPP50_UV        1025000
>> -#define OMAP4460_VDD_IVA_OPP100_UV        1200000
>> -#define OMAP4460_VDD_IVA_OPPTURBO_UV        1313000
>> +#define OMAP4460_VDD_IVA_OPP50_UV         950000
>> +#define OMAP4460_VDD_IVA_OPP100_UV        1140000

Btw, this should be 1114000

>> +#define OMAP4460_VDD_IVA_OPPTURBO_UV        1291000
>>   #define OMAP4460_VDD_IVA_OPPNITRO_UV        1375000
>>   struct omap_volt_data omap446x_vdd_iva_volt_data[] = {
>> @@ -91,8 +93,8 @@ struct omap_volt_data omap446x_vdd_iva_volt_data[] = {
>>       VOLT_DATA_DEFINE(0, 0, 0, 0),
>>   };
>> -#define OMAP4460_VDD_CORE_OPP50_UV        1025000
>> -#define OMAP4460_VDD_CORE_OPP100_UV        1200000
>> +#define OMAP4460_VDD_CORE_OPP50_UV         962000
>> +#define OMAP4460_VDD_CORE_OPP100_UV        1127000
>>   #define OMAP4460_VDD_CORE_OPP100_OV_UV        1250000
>>   struct omap_volt_data omap446x_vdd_core_volt_data[] = {
>>
> 

Atleast this update and the previous OMAP4430 patch matches up to what I 
can see from the Data Manual. So, guess you can add an official version 
of this patch.

regards
Suman


  reply index

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-09 23:19 Suman Anna
2020-07-09 23:19 ` [PATCH 01/13] ARM: dts: omap4: Add timer_sys_ck clocks for timers Suman Anna
2020-07-09 23:19 ` [PATCH 02/13] ARM: dts: omap5: " Suman Anna
2020-07-09 23:19 ` [PATCH 03/13] ARM: dts: omap4: Update the DSP node Suman Anna
2020-07-09 23:19 ` [PATCH 04/13] ARM: dts: omap4: Add IPU DT node Suman Anna
2020-07-09 23:19 ` [PATCH 05/13] ARM: dts: omap4: Add aliases for rproc nodes Suman Anna
2020-07-09 23:19 ` [PATCH 06/13] ARM: dts: omap4-panda-common: Add CMA pools and enable IPU & DSP Suman Anna
2020-08-12  5:31   ` Guillaume Tucker
2020-08-14 14:32     ` Guillaume Tucker
2020-08-14 15:26       ` Suman Anna
2020-08-14 16:33         ` Guillaume Tucker
2020-08-14 19:33           ` Suman Anna
2020-08-20  9:17             ` Guillaume Tucker
2020-07-09 23:19 ` [PATCH 07/13] ARM: dts: omap4-panda-common:: Add system timers to DSP and IPU Suman Anna
2020-07-09 23:19 ` [PATCH 08/13] ARM: dts: omap5: Add DSP and IPU nodes Suman Anna
2020-07-09 23:19 ` [PATCH 09/13] ARM: dts: omap5: Add aliases for rproc nodes Suman Anna
2020-07-09 23:19 ` [PATCH 10/13] ARM: dts: omap5-uevm: Add CMA pools and enable IPU & DSP Suman Anna
2020-07-09 23:19 ` [PATCH 11/13] ARM: dts: omap5-uevm: Add system timers to DSP and IPU Suman Anna
2020-07-09 23:19 ` [PATCH 12/13] ARM: dts: omap4-panda-common: Add watchdog timers for IPU and DSP Suman Anna
2020-07-09 23:19 ` [PATCH 13/13] ARM: dts: omap5-uevm: " Suman Anna
2020-07-10 16:58 ` [PATCH 00/13] Add IPU & DSP remoteprocs on OMAP4 and OMAP5 Tony Lindgren
2020-07-10 17:17   ` Suman Anna
2020-07-10 17:28     ` Suman Anna
2020-07-10 17:59       ` Tony Lindgren
2020-07-10 18:29         ` Suman Anna
2020-07-10 20:45           ` Suman Anna [this message]
2020-07-10 22:08             ` Tony Lindgren
2020-07-10 17:40     ` Tony Lindgren
2020-07-10 18:24       ` Suman Anna
2020-07-13 18:24 ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=557ebada-4a2f-32ed-fbea-2daba8daa073@ti.com \
    --to=s-anna@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=t-kristo@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-OMAP Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-omap/0 linux-omap/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-omap linux-omap/ https://lore.kernel.org/linux-omap \
		linux-omap@vger.kernel.org
	public-inbox-index linux-omap

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-omap


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git