From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56211C10DAA for ; Wed, 9 Sep 2020 08:59:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D3FAB21919 for ; Wed, 9 Sep 2020 08:59:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=st.com header.i=@st.com header.b="f6RMNWkM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730158AbgIII65 (ORCPT ); Wed, 9 Sep 2020 04:58:57 -0400 Received: from mx07-00178001.pphosted.com ([185.132.182.106]:41570 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730140AbgIII6z (ORCPT ); Wed, 9 Sep 2020 04:58:55 -0400 Received: from pps.filterd (m0046037.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 0898uYub012708; Wed, 9 Sep 2020 10:58:43 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=st.com; h=subject : from : to : cc : references : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=STMicroelectronics; bh=8Q8hbmpKmLDr8ySOBVadqHaRhu/OOLiYjRmW/bi0PCk=; b=f6RMNWkM5LQ8NMtOe+rRJny/CX5p7ZlMjBWaPYrKkEbrMJVst5FO5kfHvk6KK3fQtZOB PT7g6TSdN9lsS2mUuDPylGhzO8MKBEUexZ4e+ZJdaKRZyHAgt0Rq96FRLx/0+0yF68dS 5FQm4qHI/r+ayP0NiiOuZCnMU2XGwA1V3bw8tY5/TbMYMqBYiZdRrp+UeuVkLJ8HK7hY APXMtcgn99CypqC287n/8a7QbqkPdh099xDJgjAt5eKfq+etzufKVafBZhk/zHf9kbE+ 3VQ8gEr34mldcIbOqmfKyXLwjrEkDWfVjjWjt32/Od4kDKD+L2c0cQDbY/K10Y5kEWsH Pw== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 33c0euuwx6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 09 Sep 2020 10:58:43 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id B15C210002A; Wed, 9 Sep 2020 10:58:40 +0200 (CEST) Received: from Webmail-eu.st.com (gpxdag3node5.st.com [10.75.127.72]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 5B26621F679; Wed, 9 Sep 2020 10:58:40 +0200 (CEST) Received: from lmecxl0995.lme.st.com (10.75.127.50) by GPXDAG3NODE5.st.com (10.75.127.72) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 9 Sep 2020 10:58:39 +0200 Subject: Re: [balbi-usb:testing/next 32/38] drd.c:undefined reference to `usb_role_switch_get_drvdata' From: Amelie DELAUNAY To: Felipe Balbi , kernel test robot CC: "kbuild-all@lists.01.org" , "linux-usb@vger.kernel.org" , "linux-omap@vger.kernel.org" References: <202009090044.0oZdDUmk%lkp@intel.com> <87eenbld3z.fsf@kernel.org> <91a69ea7-71b8-be3c-19ad-980306681b2c@st.com> Message-ID: <55abf0b6-2b21-faf2-7581-9be7da4475f2@st.com> Date: Wed, 9 Sep 2020 10:58:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <91a69ea7-71b8-be3c-19ad-980306681b2c@st.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.75.127.50] X-ClientProxiedBy: SFHDAG2NODE3.st.com (10.75.127.6) To GPXDAG3NODE5.st.com (10.75.127.72) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235,18.0.687 definitions=2020-09-09_03:2020-09-08,2020-09-09 signatures=0 Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org On 9/9/20 9:33 AM, Amelie DELAUNAY wrote: > Hi, > > On 9/9/20 7:42 AM, Felipe Balbi wrote: >> >> Hi, >> >> kernel test robot writes: >>> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git >>> testing/next >>> head:   3c9722514c3fb74bbe0af87c20bc6b4c47121287 >>> commit: a0f0bc95705446b8b1476338056bf869271ba36a [32/38] usb: dwc2: >>> override PHY input signals with usb role switch support >>> config: arc-randconfig-r016-20200908 (attached as .config) >>> compiler: arceb-elf-gcc (GCC) 9.3.0 >>> reproduce (this is a W=1 build): >>>          wget >>> https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross >>> -O ~/bin/make.cross >>>          chmod +x ~/bin/make.cross >>>          git checkout a0f0bc95705446b8b1476338056bf869271ba36a >>>          # save the attached .config to linux build tree >>>          COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 >>> make.cross ARCH=arc >>> >>> If you fix the issue, kindly add following tag as appropriate >>> Reported-by: kernel test robot >>> >>> All errors (new ones prefixed by >>): >>> >>>     arceb-elf-ld: lib/stackdepot.o: in function `filter_irq_stacks': >>>     stackdepot.c:(.text+0x5a): undefined reference to >>> `__irqentry_text_start' >>>     arceb-elf-ld: stackdepot.c:(.text+0x5a): undefined reference to >>> `__irqentry_text_start' >>>     arceb-elf-ld: stackdepot.c:(.text+0x62): undefined reference to >>> `__irqentry_text_end' >>>     arceb-elf-ld: stackdepot.c:(.text+0x62): undefined reference to >>> `__irqentry_text_end' >>>     arceb-elf-ld: stackdepot.c:(.text+0x6a): undefined reference to >>> `__softirqentry_text_start' >>>     arceb-elf-ld: stackdepot.c:(.text+0x6a): undefined reference to >>> `__softirqentry_text_start' >>>     arceb-elf-ld: stackdepot.c:(.text+0x72): undefined reference to >>> `__softirqentry_text_end' >>>     arceb-elf-ld: stackdepot.c:(.text+0x72): undefined reference to >>> `__softirqentry_text_end' >>>     arceb-elf-ld: drivers/usb/dwc2/drd.o: in function >>> `dwc2_drd_role_sw_set': >>>>> drd.c:(.text+0x82): undefined reference to >>>>> `usb_role_switch_get_drvdata' >>>>> arceb-elf-ld: drd.c:(.text+0x82): undefined reference to >>>>> `usb_role_switch_get_drvdata' >>>     arceb-elf-ld: drivers/usb/dwc2/drd.o: in function `dwc2_drd_init': >>>>> drd.c:(.text+0x1c0): undefined reference to `usb_role_switch_register' >>>>> arceb-elf-ld: drd.c:(.text+0x1c0): undefined reference to >>>>> `usb_role_switch_register' >>>     arceb-elf-ld: drivers/usb/dwc2/drd.o: in function `dwc2_drd_exit': >>>>> drd.c:(.text+0x2c4): undefined reference to >>>>> `usb_role_switch_unregister' >>>>> arceb-elf-ld: drd.c:(.text+0x2c4): undefined reference to >>>>> `usb_role_switch_unregister' >> >> Amelie? Have you seen this? Is it ARC-specific? >> > Never seen this before. But looking at DWC2 Kconfig and Makefile, I > should have add the 'select USB_ROLE_SWITCH' as it is in DWC3 Kconfig. > Because in my patch, USB_ROLE_SWITCH is selected if USB_DWC2_DUAL_ROLE, > but drd.c (using USB role switch API) is compiled if CONFIG_USB_DWC2 is > enabled, whatever DWC2 mode. > > So, an update of DWC2 Kconfig/Makefile as DWC3 seems required. > I send a v6 or a fixup of "usb: dwc2: override PHY input signals with > usb role switch support" can be done ? ARC DWC2/USB_ROLE_SWITCH config is: CONFIG_USB_DWC2=y CONFIG_USB_DWC2_DUAL_ROLE=n CONFIG_USB_DWC2_HOST=y CONFIG_USB_DWC2_PERIPHERAL=n CONFIG_USB_ROLE_SWITCH=m I succeed to reproduce the issue with this configuration. I'm preparing a fix.