From: Suman Anna <s-anna@ti.com>
To: Rob Herring <robh+dt@kernel.org>,
Jassi Brar <jaswinder.singh@linaro.org>
Cc: Tony Lindgren <tony@atomide.com>, Nishanth Menon <nm@ti.com>,
Jan Kiszka <jan.kiszka@siemens.com>, <devicetree@vger.kernel.org>,
<linux-omap@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2] dt-bindings: mailbox: Convert omap-mailbox.txt binding to YAML
Date: Fri, 28 May 2021 10:00:03 -0500 [thread overview]
Message-ID: <574767de-9a05-f8c1-9673-1df63f626a47@ti.com> (raw)
In-Reply-To: <20210520234348.4479-1-s-anna@ti.com>
Hi Rob,
On 5/20/21 6:43 PM, Suman Anna wrote:
> Convert the current OMAP Mailbox binding from text format to YAML
> format/DT schema, and delete the legacy text binding file.
>
> The new YAML binding conversion is an updated version compared to
> the original. The descriptions for certain properties have been
> improved to provide more clarity. Constraints are added to the
> properties 'ti,mbox-num-users', 'ti,mbox-num-fifos' and 'interrupts'.
> The 'ti,hwmods' is a legacy property and is retained only to reflect
> the existing usage on some older OMAP2 and OMAP3 platforms.
>
> All the existing examples have also been updated to reflect the
> latest dts nodes (ti,hwmods removed from OMAP4 and AM33xx examples,
> and interrupts value updated for AM65x SoCs).
>
> Signed-off-by: Suman Anna <s-anna@ti.com>
> ---
> v2: Address Rob's comments
> - Replace definitions with $defs
> - Dropping the trailing | character after all description keywords
> - Marked ti,hwmods as deprecated
> - Updated #mbox-cells description
> v1:
> http://patchwork.ozlabs.org/project/devicetree-bindings/patch/20210518172022.10562-1-s-anna@ti.com/
>
> Note that this would continue to generate the checkpatch warning
> "DT binding docs and includes should be a separate patch" for the
> deleted text file. The fixes for dtbs_check warnings on mailbox nodes
> with this yaml file are posted as well, please see v1 patch for links.
>
Just following up on this, the mailbox nodes dtbs_check warning fixes are now
staged for v5.14, and are present in next as of next-20210528.
> regards
> Suman
>
> .../bindings/mailbox/omap-mailbox.txt | 184 -----------
> .../bindings/mailbox/ti,omap-mailbox.yaml | 308 ++++++++++++++++++
> 2 files changed, 308 insertions(+), 184 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/mailbox/omap-mailbox.txt
> create mode 100644 Documentation/devicetree/bindings/mailbox/ti,omap-mailbox.yaml
>
[snip]
regards
Suman
next prev parent reply other threads:[~2021-05-28 15:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-20 23:43 [PATCH v2] dt-bindings: mailbox: Convert omap-mailbox.txt binding to YAML Suman Anna
2021-05-28 15:00 ` Suman Anna [this message]
2021-06-02 19:45 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=574767de-9a05-f8c1-9673-1df63f626a47@ti.com \
--to=s-anna@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=jan.kiszka@siemens.com \
--cc=jaswinder.singh@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).