From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chanwoo Choi Subject: Re: [PATCH v1 2/5] extcon: Return -EPROBE_DEFER when extcon device is not found Date: Thu, 15 Nov 2018 10:16:53 +0900 Message-ID: <5BECC905.4060802@samsung.com> References: <20181110181101.24557-1-andriy.shevchenko@linux.intel.com> <20181110181101.24557-2-andriy.shevchenko@linux.intel.com> <5BE8C821.5080002@samsung.com> <5BEB63C3.1020504@samsung.com> <5BEBE741.6050101@samsung.com> <20181114093652.GK10650@smile.fi.intel.com> <5BEBEF7C.7060003@samsung.com> <5BEC018E.8020102@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8BIT Return-path: In-reply-to: Sender: linux-kernel-owner@vger.kernel.org To: Andy Shevchenko Cc: MyungJoo Ham , USB , Felipe Balbi , Guenter Roeck , "Krogerus, Heikki" , rogerq@ti.com, Linux PM , "Rafael J. Wysocki" , Sebastian Reichel , Linux OMAP Mailing List , Darren Hart , Platform Driver , Greg Kroah-Hartman , Linux Kernel Mailing List , Chen-Yu Tsai , Hans de Goede List-Id: linux-omap@vger.kernel.org On 2018년 11월 14일 23:04, Andy Shevchenko wrote: > On Wed, Nov 14, 2018 at 1:17 PM Andy Shevchenko > wrote: >> On Wed, Nov 14, 2018 at 1:05 PM Chanwoo Choi wrote: > >>>> Changing NULL to -ENODEV is a trading bad to worse. > >> P.S. I still disagree with your arguments in relation to de facto use of an API. > > I spoke to colleagues of mine and they are agree that semantically > -EPROBE_DEFER is a wrong error code from API that matches against some > list. > On the other hand, they agree with me that changing NULL to -ENODEV is > a trading bad to worse. > > So, I withdraw mine complaints against API. > OK. Thanks. -- Best Regards, Chanwoo Choi Samsung Electronics