linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Florian Fainelli <f.fainelli@gmail.com>
To: Vladimir Oltean <olteanv@gmail.com>,
	Jakub Kicinski <kuba@kernel.org>,
	"David S. Miller" <davem@davemloft.net>
Cc: Andrew Lunn <andrew@lunn.ch>,
	Vivien Didelot <vivien.didelot@gmail.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	bridge@lists.linux-foundation.org,
	Roopa Prabhu <roopa@nvidia.com>,
	Nikolay Aleksandrov <nikolay@nvidia.com>,
	Jiri Pirko <jiri@resnulli.us>, Ido Schimmel <idosch@idosch.org>,
	Claudiu Manoil <claudiu.manoil@nxp.com>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	UNGLinuxDriver@microchip.com, Vadym Kochan <vkochan@marvell.com>,
	Taras Chornyi <tchornyi@marvell.com>,
	Grygorii Strashko <grygorii.strashko@ti.com>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Ioana Ciornei <ioana.ciornei@nxp.com>,
	Ivan Vecera <ivecera@redhat.com>,
	linux-omap@vger.kernel.org
Subject: Re: [PATCH v5 net-next 03/10] net: bridge: don't print in br_switchdev_set_port_flag
Date: Fri, 12 Feb 2021 10:07:14 -0800	[thread overview]
Message-ID: <6097810e-9b74-df81-ccc4-3a4b47b94b67@gmail.com> (raw)
In-Reply-To: <20210212151600.3357121-4-olteanv@gmail.com>



On 2/12/2021 7:15 AM, Vladimir Oltean wrote:
> From: Vladimir Oltean <vladimir.oltean@nxp.com>
> 
> For the netlink interface, propagate errors through extack rather than
> simply printing them to the console. For the sysfs interface, we still
> print to the console, but at least that's one layer higher than in
> switchdev, which also allows us to silently ignore the offloading of
> flags if that is ever needed in the future.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>

I suppose the slight "loss" of information on which port failed the
operation is okay since it was implied by either the path (sysfs) or the
bridge command.
-- 
Florian

  parent reply	other threads:[~2021-02-12 18:08 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-12 15:15 [PATCH v5 net-next 00/10] Cleanup in brport flags switchdev offload for DSA Vladimir Oltean
2021-02-12 15:15 ` [PATCH v5 net-next 01/10] net: switchdev: propagate extack to port attributes Vladimir Oltean
2021-02-12 16:00   ` Nikolay Aleksandrov
2021-02-12 17:03   ` Grygorii Strashko
2021-02-12 15:15 ` [PATCH v5 net-next 02/10] net: bridge: offload all port flags at once in br_setport Vladimir Oltean
2021-02-12 15:57   ` Nikolay Aleksandrov
2021-02-12 18:05   ` Florian Fainelli
2021-02-12 15:15 ` [PATCH v5 net-next 03/10] net: bridge: don't print in br_switchdev_set_port_flag Vladimir Oltean
2021-02-12 15:59   ` Nikolay Aleksandrov
2021-02-12 18:07   ` Florian Fainelli [this message]
2021-02-12 15:15 ` [PATCH v5 net-next 04/10] net: dsa: configure better brport flags when ports leave the bridge Vladimir Oltean
2021-02-12 15:15 ` [PATCH v5 net-next 05/10] net: switchdev: pass flags and mask to both {PRE_,}BRIDGE_FLAGS attributes Vladimir Oltean
2021-02-12 17:06   ` Grygorii Strashko
2021-02-12 18:10   ` Florian Fainelli
2021-02-12 15:15 ` [PATCH v5 net-next 06/10] net: dsa: act as passthrough for bridge port flags Vladimir Oltean
2021-02-12 18:19   ` Florian Fainelli
2021-02-12 15:15 ` [PATCH v5 net-next 07/10] net: dsa: felix: restore multicast flood to CPU when NPI tagger reinitializes Vladimir Oltean
2021-02-12 18:12   ` Florian Fainelli
2021-02-12 15:15 ` [PATCH v5 net-next 08/10] net: mscc: ocelot: use separate flooding PGID for broadcast Vladimir Oltean
2021-02-12 15:15 ` [PATCH v5 net-next 09/10] net: mscc: ocelot: offload bridge port flags to device Vladimir Oltean
2021-02-12 15:16 ` [PATCH v5 net-next 10/10] net: dsa: sja1105: " Vladimir Oltean
2021-02-13  1:20 ` [PATCH v5 net-next 00/10] Cleanup in brport flags switchdev offload for DSA patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6097810e-9b74-df81-ccc4-3a4b47b94b67@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=andrew@lunn.ch \
    --cc=bridge@lists.linux-foundation.org \
    --cc=claudiu.manoil@nxp.com \
    --cc=davem@davemloft.net \
    --cc=grygorii.strashko@ti.com \
    --cc=idosch@idosch.org \
    --cc=ioana.ciornei@nxp.com \
    --cc=ivecera@redhat.com \
    --cc=jiri@resnulli.us \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nikolay@nvidia.com \
    --cc=olteanv@gmail.com \
    --cc=roopa@nvidia.com \
    --cc=tchornyi@marvell.com \
    --cc=vigneshr@ti.com \
    --cc=vivien.didelot@gmail.com \
    --cc=vkochan@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).