From: Grygorii Strashko <grygorii.strashko@ti.com>
To: David Miller <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>, <kuba@kernel.org>, <vigneshr@ti.com>,
<m-karicheri2@ti.com>, <nsekhar@ti.com>,
<linux-kernel@vger.kernel.org>, <linux-omap@vger.kernel.org>
Subject: Re: [PATCH net-next v2 2/9] net: ethernet: ti: ale: add static configuration
Date: Wed, 9 Sep 2020 19:51:01 +0300 [thread overview]
Message-ID: <61332531-0166-c5af-0475-1c338d2ea043@ti.com> (raw)
In-Reply-To: <20200908.192845.1191873689940729972.davem@davemloft.net>
On 09/09/2020 05:28, David Miller wrote:
> From: Grygorii Strashko <grygorii.strashko@ti.com>
> Date: Mon, 7 Sep 2020 17:31:36 +0300
>
>> + ale_dev_id = cpsw_ale_match_id(cpsw_ale_id_match, params->dev_id);
>> + if (ale_dev_id) {
>> + params->ale_entries = ale_dev_id->tbl_entries;
>> + params->major_ver_mask = ale_dev_id->major_ver_mask;
> ...
>> - if (!ale->params.major_ver_mask)
>> - ale->params.major_ver_mask = 0xff;
>
> This is exactly the kind of change that causes regressions.
>
> The default for the mask if no dev_id is found is now zero, whereas
> before the default mask would be 0xff.
>
> Please don't make changes like this, they are very risky.
>
> In every step of these changes, existing behavior should be maintained
> as precisely as possible. Be as conservative as possible.
>
Sorry and thank you for catching it.
This part belongs to Patch 6. I'll fix it.
--
Best regards,
grygorii
next prev parent reply other threads:[~2020-09-09 16:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-07 14:31 [PATCH net-next v2 0/9] net: ethernet: ti: ale: add static configuration Grygorii Strashko
2020-09-07 14:31 ` [PATCH net-next v2 1/9] net: ethernet: ti: ale: add cpsw_ale_get_num_entries api Grygorii Strashko
2020-09-07 14:31 ` [PATCH net-next v2 2/9] net: ethernet: ti: ale: add static configuration Grygorii Strashko
2020-09-09 2:28 ` David Miller
2020-09-09 16:51 ` Grygorii Strashko [this message]
2020-09-07 14:31 ` [PATCH net-next v2 3/9] net: ethernet: ti: cpsw: use dev_id for ale configuration Grygorii Strashko
2020-09-07 14:31 ` [PATCH net-next v2 4/9] net: netcp: ethss: " Grygorii Strashko
2020-09-07 14:31 ` [PATCH net-next v2 5/9] net: ethernet: ti: am65-cpsw: " Grygorii Strashko
2020-09-07 14:31 ` [PATCH net-next v2 6/9] net: ethernet: ti: ale: make usage of ale dev_id mandatory Grygorii Strashko
2020-09-07 14:31 ` [PATCH net-next v2 7/9] net: ethernet: ti: am65-cpsw: enable hw auto ageing Grygorii Strashko
2020-09-07 14:31 ` [PATCH net-next v2 8/9] net: ethernet: ti: ale: switch to use tables for vlan entry description Grygorii Strashko
2020-09-07 14:31 ` [PATCH net-next v2 9/9] net: ethernet: ti: ale: add support for multi port k3 cpsw versions Grygorii Strashko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61332531-0166-c5af-0475-1c338d2ea043@ti.com \
--to=grygorii.strashko@ti.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=m-karicheri2@ti.com \
--cc=netdev@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).