From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C01D4C55178 for ; Thu, 5 Nov 2020 17:15:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2B0942083B for ; Thu, 5 Nov 2020 17:15:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=goldelico.com header.i=@goldelico.com header.b="eDTXshoP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731560AbgKERPT (ORCPT ); Thu, 5 Nov 2020 12:15:19 -0500 Received: from mo4-p01-ob.smtp.rzone.de ([85.215.255.53]:33904 "EHLO mo4-p01-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731203AbgKERPT (ORCPT ); Thu, 5 Nov 2020 12:15:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1604596515; s=strato-dkim-0002; d=goldelico.com; h=To:References:Message-Id:Cc:Date:In-Reply-To:From:Subject: X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender; bh=I3jp2DXngOUd771qBmgMPjOf9JRw6NMTj1GnaaPguow=; b=eDTXshoPuuX+bSwCsU7N5JHZxcHdBKGX0td6Uhgb/O6z/cH+XP+TZAF7RStv65KSEk SC+LOtvSPsg61eMC6ZUDM/c3eEtg1UvRUqsuI2zxWIIizIY/+/cW6v2FzLUZJ/iUaVjA RPqew5mzBFxoJAk9H6U2KtkIniPEXDGGL8z+CyLB1EuNUfkF56VG9gy0T9Ol5sscdnzQ V0Hr7i/Q/pQ3UflDYJpopVT1cWKq3xle2dmLiSCjhrbi8MZp/tGw7oNyqE2X8VJBzZUO 9uKjNDpX8zOweg4rvgB8huVaUVId2c7FofS5Bg9Pxitd/BDmmYoicNWrdJtuMOYVwm22 kLFQ== X-RZG-AUTH: ":JGIXVUS7cutRB/49FwqZ7WcJeFKiMgPgp8VKxflSZ1P34KBj5Qpw97WFDlSfXA0MwM0=" X-RZG-CLASS-ID: mo00 Received: from imac.fritz.box by smtp.strato.de (RZmta 47.3.2 DYNA|AUTH) with ESMTPSA id L07f74wA5HF10Yf (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (curve X9_62_prime256v1 with 256 ECDH bits, eq. 3072 bits RSA)) (Client did not present a certificate); Thu, 5 Nov 2020 18:15:01 +0100 (CET) Subject: Re: [PATCH v3 00/56] Convert DSI code to use drm_mipi_dsi and drm_panel Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: text/plain; charset=us-ascii From: "H. Nikolaus Schaller" In-Reply-To: <20201105120333.947408-1-tomi.valkeinen@ti.com> Date: Thu, 5 Nov 2020 18:15:00 +0100 Cc: Sebastian Reichel , Laurent Pinchart , Nikhil Devshatwar , linux-omap@vger.kernel.org, dri-devel@lists.freedesktop.org, Sekhar Nori , Tony Lindgren Content-Transfer-Encoding: 7bit Message-Id: <61C04176-4654-4D2D-A55B-31FBB6D2E5AA@goldelico.com> References: <20201105120333.947408-1-tomi.valkeinen@ti.com> To: Tomi Valkeinen X-Mailer: Apple Mail (2.3124) Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org Hi Tomi, > Am 05.11.2020 um 13:02 schrieb Tomi Valkeinen : > > Hi, > > This is third version of the series sent by Sebastian in February: > > https://www.spinics.net/lists/linux-omap/msg153465.html > > I took the patches from his git tree, and rebased on 5.10-rc2. There > were some conflicts and compilation errors, and one bug that made dsi to > not work (videomode variable was not initialized to 0). > > I then fixed the few checkpatch and sparse issues. Overall, Sebastian's > patches are pretty much as they were previously. I did drop Laurent's > reviewed-bys, as it's been a long time since the previous series, and > the patches are not identical anyway. > > The topmost 5 patches are new ones, cleanups enabled by the DSI > conversion. They could be handled separately, but it's such a nice > cleanup, and I've been waiting for years to get this done, so here they > are. That said, there are still a _lot_ of cleanups to do. > > Almost all of the patches are omapdrm changes. The two non-omapdrm > changes are: > - After converting panel-dsi-cm to common DRM panel model, it is moved > to drm's panel directory. > - Add MIPI_DSI_MODE_ULPS_IDLE flag > > I have tested these with OMAP4 SDP, AM5 EVM and OMAP4 Panda. SDP has > command mode panel, and I don't have any videomode panels. > > Sebastian, I hope you're ok with all this? I did send you an email, but > didn't get a reply yet, so I thought to just proceed. If you want to > handle this in some other way, or don't want your > authorship/signed-off-by in some of the commits, just tell. That all is great. I was able to apply the patch set cleanly and compile. Next, I migrated my long waiting mipi_dsi/drm_panel driver conversion for the panel of the Pyra handheld (omap 5 based) to compile on 5.10-rc2. And I followed the latest existing panel-orisetech-otm8009a.c which uses a similar video mode controller and mipi-dsi. That one seems to be used by arch/arm/boot/dts/stm32f469-disco.dts. Unfortunately my panel driver is not even loaded by drm/omap so I can't debug. Does this set of drm/omap drivers need a modification of the device tree? If yes, which one? BR and thanks, Nikolaus