From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90DA3C433DF for ; Thu, 6 Aug 2020 18:44:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A0A51221E2 for ; Thu, 6 Aug 2020 18:44:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=ds0.me header.i=@ds0.me header.b="Zi6x/QrP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726420AbgHFSoa (ORCPT ); Thu, 6 Aug 2020 14:44:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32894 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726197AbgHFSoa (ORCPT ); Thu, 6 Aug 2020 14:44:30 -0400 Received: from ds0.me (ds0.me [IPv6:2602:ffc5::f9bc:b4ce]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 41066C061574 for ; Thu, 6 Aug 2020 11:44:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ds0.me; s=mail; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID; bh=sXtKKoiM6eqhDQ65XTdyH+SbkaR+8zUWup2R2W34teE=; b=Zi6x/QrPcnvvbQTkt0vMaqxnRwG6rgNP7LQW1yfDFWJjnBb5LHa4S8jdjxu1wwnjb/f+f1+dBs4+PpUN5TRRxPIWIJpRrqjwFmoGDNG8nAnAtsglT8dpPFX5KboQdV9+IaalJB1xk7IPsdn0fCMGq7FpPvcSskqXuVO6sjK+hKU=; Received: from 97e0b068.skybroadband.com ([151.224.176.104] helo=archlinux) by ds0.me with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1k3ksL-00041c-1z; Thu, 06 Aug 2020 14:44:25 -0400 Message-ID: <63501267004c35bd1dc6971cb9cddda07c967303.camel@ds0.me> Subject: Re: [Letux-kernel] module_mipi_dsi_driver panel with omapdrm? From: David Shah To: Discussions about the Letux Kernel , Tomi Valkeinen , "H. Nikolaus Schaller" , Sebastian Reichel Cc: Linux-OMAP , Laurent Pinchart , Jyri Sarha , kernel@pyra-handheld.com Date: Thu, 06 Aug 2020 19:44:17 +0100 In-Reply-To: <1ec9febeb685c7fa866b14b0a4c2a5026f0a3461.camel@ds0.me> References: <20200706143613.GS37466@atomide.com> <20200707180115.GB5849@atomide.com> <6E0A9415-9AB5-48D9-9E61-12D20655D04D@goldelico.com> <20200724012411.GJ21353@pendragon.ideasonboard.com> <7023EB05-DC29-4D42-84C8-F0D14B50467D@goldelico.com> <20200801232259.hitcfosiq6f2i57y@earth.universe> <4F1BD997-B791-4570-92B9-552C9BFF1350@goldelico.com> <20200805112831.akufm5wxkwqehiff@earth.universe> <0DDD1D3E-4F63-44B4-91CA-1B5B853837BC@goldelico.com> <64416676-a2ea-f11e-4d07-51a3efb55cdd@ti.com> <7ef4e081c1a0db81fd98f9e94afc6228a9b68703.camel@ds0.me> <1ec9febeb685c7fa866b14b0a4c2a5026f0a3461.camel@ds0.me> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.4 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org Following a bit of testing, the DSI issues are fixed by https://github.com/daveshah1/pyra-kernel-devel/commit/3161275854a0f2cd44a55b8eb039bd201f894486 (I will prepare a proper patch set shortly). This makes the display work with HDMI disabled. There also seems to be a race condition between the hdmi0 connector and tpd12s015 "encoder". This results in the tpd12s015 permanently returning EPROBE_DEFER and the display subsystem never successfully probing. Reversing the order of the encoder and connector in the device tree (omap5-board-common.dtsi) makes the display work again with HDMI enabled; as does adding some printks to the display-connector driver. On Thu, 2020-08-06 at 17:04 +0100, David Shah wrote: > Sorry, my error. I forgot the Pyra is LPAE and therefore using 64-bit > physical addresses. > > The start is indeed a correct physical address, 0x58005000, but off > by > 0x1000 from what the DSI driver is expecting. > > On Thu, 2020-08-06 at 16:50 +0100, David Shah wrote: > > I had a moment to give letux-5.7.y a test on the Pyra hardware. > > > > I notice an error in dmesg: > > > > DSI: omapdss DSI error: unsupported DSI module > > > > which comes from this code (with a small patch added by me): > > > > d = dsi->data->modules; > > while (d->address != 0 && d->address != dsi_mem->start) > > d++; > > > > if (d->address == 0) { > > DSSERR("unsupported DSI module (start: %08x)\n", > > dsi_mem->start); > > return -ENODEV; > > } > > > > "start" here is c0b3ba5c - a kernel virtual address - which > > definitely > > doesn't seem right as it would never match. > > > > Not sure my kernel-fu is quite up to tracking this down yet, but I > > will > > keep trying to trace out what is happening. > > > > Best > > > > Davidg > > > > On Wed, 2020-08-05 at 15:08 +0300, Tomi Valkeinen wrote: > > > On 05/08/2020 14:49, H. Nikolaus Schaller wrote: > > > > Hi, > > > > > > > > > Am 05.08.2020 um 13:28 schrieb Sebastian Reichel < > > > > > sebastian.reichel@collabora.com>: > > > > > > > > > > Hi, > > > > > > > > > > On Wed, Aug 05, 2020 at 11:19:20AM +0200, H. Nikolaus > > > > > Schaller > > > > > wrote: > > > > > > What I do not yet understand is how Laurent's patch should > > > > > > be > > > > > > able > > > > > > to break it. > > > > > > > > > > omapdrm will not probe successfully if any DT enabled > > > > > component > > > > > does not probe correctly. Since the patch you identified > > > > > touched > > > > > HDMI and VENC and you are probably using HDMI, I suggest > > > > > looking > > > > > there first. > > > > > > > > Yes, that is a very good explanation. > > > > > > > > Maybe there is a subtle change in how the HDMI connector has to > > > > be > > > > defined > > > > which is missing in our (private) DTB. Maybe the OMAP5-uEVM DTS > > > > gives a hint. > > > > > > > > A quick check shows last hdmi specific change for omap5-board- > > > > common or uevm > > > > was in 2017 but I may have missed something. > > > > > > > > There are 715a5a978733f0 and 671ab615bd507f which arrived in > > > > v5.7- > > > > rc1 as well > > > > and are related to hdmi clocks. So this may be (or not) and > > > > influencing factor. > > > > > > HDMI should "just work", and has been tested. But maybe there's > > > some > > > conflict with HDMI and DSI. > > > > > > Tomi > > > > > > > _______________________________________________ > > https://projects.goldelico.com/p/gta04-kernel/ > > Letux-kernel mailing list > > Letux-kernel@openphoenux.org > > http://lists.goldelico.com/mailman/listinfo.cgi/letux-kernel > > _______________________________________________ > Kernel mailing list > Kernel@pyra-handheld.com > http://pyra-handheld.com/cgi-bin/mailman/listinfo/kernel