From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60983C4167B for ; Thu, 10 Dec 2020 08:19:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 220A123D58 for ; Thu, 10 Dec 2020 08:19:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387780AbgLJITX (ORCPT ); Thu, 10 Dec 2020 03:19:23 -0500 Received: from fllv0016.ext.ti.com ([198.47.19.142]:51546 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387781AbgLJITP (ORCPT ); Thu, 10 Dec 2020 03:19:15 -0500 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 0BA8HJ3g090088; Thu, 10 Dec 2020 02:17:19 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1607588239; bh=aq30/Nsk4XW/atnB6va78QseWw7cJP4bpMBbViEyW2Y=; h=Subject:From:To:CC:References:Date:In-Reply-To; b=whAFRW1IfqUovpGNCsxflfJiZdnRCfK3E9oVUZLSN9HH29opk7L4lLcXYkpx+UYvx lU+b6x1TltJQZOgjKIGZYQ/uHrU6ojgVxPhByE+4j30/fGpalbWd13li5iHkYWnA1d L3WqWTDm0Vg3/hUFy3HxlTP0OZQSMyQx1Vp/Uud4= Received: from DFLE114.ent.ti.com (dfle114.ent.ti.com [10.64.6.35]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 0BA8HJhv053315 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 10 Dec 2020 02:17:19 -0600 Received: from DFLE111.ent.ti.com (10.64.6.32) by DFLE114.ent.ti.com (10.64.6.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Thu, 10 Dec 2020 02:17:19 -0600 Received: from fllv0040.itg.ti.com (10.64.41.20) by DFLE111.ent.ti.com (10.64.6.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Thu, 10 Dec 2020 02:17:19 -0600 Received: from [192.168.2.6] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 0BA8HG0F095817; Thu, 10 Dec 2020 02:17:17 -0600 Subject: Re: [PATCH v5 29/29] drm/omap: dsi: allow DSI commands to be sent early From: Tomi Valkeinen To: Laurent Pinchart CC: Sebastian Reichel , Nikhil Devshatwar , , , Sekhar Nori , Tony Lindgren , , Sam Ravnborg References: <20201208122855.254819-1-tomi.valkeinen@ti.com> <20201208122855.254819-30-tomi.valkeinen@ti.com> Message-ID: <64bbe541-53fb-2bd0-0069-c0a28a064a17@ti.com> Date: Thu, 10 Dec 2020 10:17:16 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org On 10/12/2020 09:34, Tomi Valkeinen wrote: > But we don't have anything stopping omap_dsi_host_transfer being called after the whole bridge has > been detached (or called before attach). So, if we have a guarantee that the panels won't be doing > dsi transfers before/during bridge attach or after/during bridge detach, we have no issue. If we > don't have such a guarantee, it's broken. > > I'll try to figure out if there's such a guarantee, but maybe it's safer to add a flag to indicate > if the bridge is available, and check that during omap_dsi_host_transfer. I don't think this can happen. I mixed up the bridge attach/detach and the dsi host attach/detach. The cancel_delayed_work_sync happens in omap_dsi_host_detach, and I think it's a sensible expectation that the panel won't first do mipi_dsi_detach(), and then try to do DSI transfers. Tomi -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki