From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E32DFC43457 for ; Thu, 8 Oct 2020 23:23:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7F3702224B for ; Thu, 8 Oct 2020 23:23:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="bJ876ZGy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730943AbgJHXXZ (ORCPT ); Thu, 8 Oct 2020 19:23:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54632 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728996AbgJHXXZ (ORCPT ); Thu, 8 Oct 2020 19:23:25 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B71BDC0613D2 for ; Thu, 8 Oct 2020 16:23:24 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id m6so8353146wrn.0 for ; Thu, 08 Oct 2020 16:23:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=3EtKmKMy3vG8i3h8NClcxP5zyMtCd9LJjxAVLf9GMYQ=; b=bJ876ZGyQ9SPlHdrPZbdemybrbsKrafGpMMela3/WxH/fFzPWEtY16uq61ogRFXtyd 0jXWiFV94Puw0OvdeqqlJCnQpv+eDeQneNXpZfq3jrnRBVBCBAqaS2oEl7cPB68LNOEz izWppDmNLm05MJDjO2HvyqIKCLEHz9crTHwXHraK6YVoc65g18FYY6tKaBwqU/nNCzJm zZE2gaevKL9ZYbEEp+z7zADUsG1nkBcy/skduLDiHmjKneMdH2F6JNTAAvwBTGGAwYYc D7GddT1ShWiakiZmuziySZlC11TvfpRBVSwyFMk1LFAwVFOh/4h+hmHIrE14ne7mDIB9 61vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=3EtKmKMy3vG8i3h8NClcxP5zyMtCd9LJjxAVLf9GMYQ=; b=CyhcpwvdKBUmHYdlHHDqN90e+K1aHp/mxGRHuVzBSwPX/Gv3rmBlsnNKrHN1JlrU/D Qc+zIMSw+IIE9JjggEv7XsBOmVDkokvufp6RRp2tHkw/Ge1IL6wzA3Jtu2viXNVX1kRa sqrkXrD3+D2YELl7Krr6NpJgXO1vZE1bNO6qaP866N7gm1wbBJ1Udx6YhHB+fZZcyvhI HqLU+fVBheabykOCRPUZ6YmDeRDVUPXjIn7BKwoSrO+r7W4ASiSp/vDBLmn9LaVienpX s1rQCRdPsbUeWcD+ICMRE5ccoqA46AtsGLqAkuWKMZmu1GYm6OOHZK96DPpbzHaciUTq 3M5A== X-Gm-Message-State: AOAM532l+VIwJsywb9APYOHpY2ZTFnJw9BQoW7bbS8JqHIouqehmJGxT amf5A64mbeaD1g4bQ6yP+IIsMwV+swYeUA== X-Google-Smtp-Source: ABdhPJxIXqFQj7qMPz5xQdrQsmT3y3a8g6giamxY4mF3euvwh/OmVP7cA7oWsihHSt+aI6DDeuodSA== X-Received: by 2002:adf:bc14:: with SMTP id s20mr12488513wrg.220.1602199403185; Thu, 08 Oct 2020 16:23:23 -0700 (PDT) Received: from ?IPv6:2a01:e34:ed2f:f020:bcbd:c839:6352:ebcd? ([2a01:e34:ed2f:f020:bcbd:c839:6352:ebcd]) by smtp.googlemail.com with ESMTPSA id v128sm8820729wme.2.2020.10.08.16.23.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Oct 2020 16:23:22 -0700 (PDT) Subject: Re: [PATCH 1/2] thermal: ti-soc-thermal: Enable addition power management To: Adam Ford , linux-pm@vger.kernel.org, linux-omap@vger.kernel.org Cc: aford@beaconembedded.com, kernel test robot , Andreas Kemnade , Tony Lindgren , Russell King , Eduardo Valentin , Keerthy , Zhang Rui , Amit Kucheria , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20200911123157.759379-1-aford173@gmail.com> From: Daniel Lezcano Message-ID: <6acd7e51-0c77-fa30-9e8c-d2cf727e512c@linaro.org> Date: Fri, 9 Oct 2020 01:23:21 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200911123157.759379-1-aford173@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org On 11/09/2020 14:31, Adam Ford wrote: > The bandgap sensor can be idled when the processor is too, but it > isn't currently being done, so the power consumption of OMAP3 > boards can elevated if the bangap sensor is enabled. > > This patch attempts to use some additional power management > to idle the clock to the bandgap when not needed. > > Signed-off-by: Adam Ford > Reported-by: kernel test robot > Tested-by: Andreas Kemnade # GTA04 > --- [ ... ] > - /* First thing is to remove sensor interfaces */ > + cpu_pm_unregister_notifier(&bgp->nb); > + > + /* Remove sensor interfaces */ > for (i = 0; i < bgp->conf->sensor_count; i++) { > if (bgp->conf->sensors[i].unregister_cooling) > bgp->conf->sensors[i].unregister_cooling(bgp, i); > @@ -1150,9 +1167,43 @@ static int ti_bandgap_suspend(struct device *dev) > if (TI_BANDGAP_HAS(bgp, CLK_CTRL)) > clk_disable_unprepare(bgp->fclock); > > + bgp->is_suspended = true; Is this flag really needed? -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog