From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 870F2C47420 for ; Tue, 29 Sep 2020 05:25:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 47ED3221E7 for ; Tue, 29 Sep 2020 05:25:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="u9RTZSY0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725815AbgI2FZG (ORCPT ); Tue, 29 Sep 2020 01:25:06 -0400 Received: from fllv0015.ext.ti.com ([198.47.19.141]:56482 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725300AbgI2FZG (ORCPT ); Tue, 29 Sep 2020 01:25:06 -0400 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 08T5NNdV076112; Tue, 29 Sep 2020 00:23:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1601357003; bh=lsVV+WiqwympooMTHM7zY4Y8lKNeYX3fBUBfCVJ/Lnk=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=u9RTZSY0p8VY3yd+DO/wPxiDmHvgLQOv/9YyP5Bfl/tblOAubCsvONbhwUbgLjdbZ /cKGeAx5m0FGThnxI/nhlD7bUNB6726QeZ1KmtFTV+0GoBh7x9Bqi8kn2kw+XnRSJ+ /r1DJzmnQoK8W/Xv9PAXZUBvtkpZnJ/GFO0hybSw= Received: from DLEE104.ent.ti.com (dlee104.ent.ti.com [157.170.170.34]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 08T5NNpG047481 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 29 Sep 2020 00:23:23 -0500 Received: from DLEE103.ent.ti.com (157.170.170.33) by DLEE104.ent.ti.com (157.170.170.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Tue, 29 Sep 2020 00:23:22 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE103.ent.ti.com (157.170.170.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Tue, 29 Sep 2020 00:23:22 -0500 Received: from [10.250.232.147] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 08T5NAKG078844; Tue, 29 Sep 2020 00:23:11 -0500 Subject: Re: [PATCH v2 00/40] PCI: dwc: Driver clean-ups To: Michael Walle , Rob Herring CC: "Gross, Andy" , Bjorn Helgaas , Bjorn Andersson , Dilip Kota , Fabio Estevam , Gustavo Pimentel , Kunihiko Hayashi , Richard Zhu , Jerome Brunet , Jesper Nilsson , Jingoo Han , Jon Hunter , Jonathan Chocron , Sascha Hauer , Kukjin Kim , Kevin Hilman , Krzysztof Kozlowski , Lucas Stach , "open list:ARM/Amlogic Meson..." , , linux-arm-kernel , linux-arm-msm , NXP Linux Team , linux-omap , PCI , linux-samsung-soc , linux-tegra , Lorenzo Pieralisi , Murali Karicheri , Martin Blumenstingl , Marc Zyngier , Neil Armstrong , Pratyush Anand , Sascha Hauer , Shawn Guo , Shawn Guo , Song Xiaowei , Stanimir Varbanov , Thierry Reding , Wangbinghui , Masahiro Yamada , Yue Wang References: <20200821035420.380495-1-robh@kernel.org> <20200915091218.28737-1-michael@walle.cc> <346b694e43b1b6b86e4f3164e6589d25@walle.cc> From: Kishon Vijay Abraham I Message-ID: <6b776dda-e575-74f0-5575-0e5d30641522@ti.com> Date: Tue, 29 Sep 2020 10:53:09 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <346b694e43b1b6b86e4f3164e6589d25@walle.cc> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org Hi, On 16/09/20 1:24 pm, Michael Walle wrote: > Am 2020-09-16 00:02, schrieb Rob Herring: >> Can you try this? The link up check seemed unnecessary as it is racy. >> What happens if the link goes down right after checking? That's the >> only thing in the change that sticks out. >> >> diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c >> b/drivers/pci/controller/dwc/pcie-designware-host.c >> index 317ff512f8df..afee1a0e8883 100644 >> --- a/drivers/pci/controller/dwc/pcie-designware-host.c >> +++ b/drivers/pci/controller/dwc/pcie-designware-host.c >> @@ -441,6 +441,9 @@ static void __iomem >> *dw_pcie_other_conf_map_bus(struct pci_bus *bus, >>         struct pcie_port *pp = bus->sysdata; >>         struct dw_pcie *pci = to_dw_pcie_from_pp(pp); >> >> +       if (!dw_pcie_link_up(pci)) >> +               return NULL; >> + >>         busdev = PCIE_ATU_BUS(bus->number) | >> PCIE_ATU_DEV(PCI_SLOT(devfn)) | >>                  PCIE_ATU_FUNC(PCI_FUNC(devfn)); > > This will fix the issue. This fix is required to get DRA7 EVM booting again in linux-next. Thanks Kishon