From: linruizhe <linruizhe@huawei.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>,
Tony Lindgren <tony@atomide.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
"rui.zhang@intel.com" <rui.zhang@intel.com>,
"edubezval@gmail.com" <edubezval@gmail.com>,
"j-keerthy@ti.com" <j-keerthy@ti.com>,
"amitk@kernel.org" <amitk@kernel.org>,
"eballetbo@gmail.com" <eballetbo@gmail.com>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: 答复: [PATCH v3] thermal: ti-soc-thermal: Remove unused variable 'val'
Date: Thu, 22 Apr 2021 12:39:29 +0000 [thread overview]
Message-ID: <7871516e6f824f35929c4ed87cbc08c4@huawei.com> (raw)
In-Reply-To: <3116672d-4ff3-a065-f76c-1ae820e1ff95@linaro.org>
Hi Daniel,
Do I need to make more changes to this patch?
Thanks
-Lin Ruizhe
-----邮件原件-----
发件人: Daniel Lezcano [mailto:daniel.lezcano@linaro.org]
发送时间: 2021年4月21日 19:37
收件人: Tony Lindgren <tony@atomide.com>
抄送: Greg KH <gregkh@linuxfoundation.org>; linruizhe <linruizhe@huawei.com>; rui.zhang@intel.com; edubezval@gmail.com; j-keerthy@ti.com; amitk@kernel.org; eballetbo@gmail.com; linux-pm@vger.kernel.org; linux-omap@vger.kernel.org; linux-kernel@vger.kernel.org
主题: Re: [PATCH v3] thermal: ti-soc-thermal: Remove unused variable 'val'
Hi Tony,
thanks for testing
-- Daniel
On 21/04/2021 11:37, Tony Lindgren wrote:
> * Daniel Lezcano <daniel.lezcano@linaro.org> [210421 09:07]:
>> On 21/04/2021 10:49, Greg KH wrote:
>>> On Wed, Apr 21, 2021 at 04:42:56PM +0800, Lin Ruizhe wrote:
>>>> The variable 'val'in function ti_bandgap_restore_ctxt is the
>>>> register value of read bandgap registers. This function is to
>>>> restore the context. But there is no operation on the return value
>>>> of this register, so this block is redundant. Hulk robot scans this
>>>> warning.This commit remove the dead code.
>>>>
>>>> Reported-by: Hulk Robot <hulkci@huawei.com>
>>>> Fixes: b87ea759a4cc ("staging: omap-thermal: fix context restore
>>>> function")
>>>> Signed-off-by: Lin Ruizhe <linruizhe@huawei.com>
>>>> ---
>>>> v3:
>>>> -Add Fixes tag and more accurate commit message in this patch.
>>>> v2:
>>>> -As suggest remove the whole unuesed block in fuction
>>>> ti_bandgap_restore_ctxt
>>>>
>>>> drivers/thermal/ti-soc-thermal/ti-bandgap.c | 4 ----
>>>> 1 file changed, 4 deletions(-)
>>>>
>>>> diff --git a/drivers/thermal/ti-soc-thermal/ti-bandgap.c
>>>> b/drivers/thermal/ti-soc-thermal/ti-bandgap.c
>>>> index d81af89166d2..684ffb645aa9 100644
>>>> --- a/drivers/thermal/ti-soc-thermal/ti-bandgap.c
>>>> +++ b/drivers/thermal/ti-soc-thermal/ti-bandgap.c
>>>> @@ -1142,14 +1142,10 @@ static int ti_bandgap_restore_ctxt(struct ti_bandgap *bgp)
>>>> for (i = 0; i < bgp->conf->sensor_count; i++) {
>>>> struct temp_sensor_registers *tsr;
>>>> struct temp_sensor_regval *rval;
>>>> - u32 val = 0;
>>>>
>>>> rval = &bgp->regval[i];
>>>> tsr = bgp->conf->sensors[i].registers;
>>>>
>>>> - if (TI_BANDGAP_HAS(bgp, COUNTER))
>>>> - val = ti_bandgap_readl(bgp, tsr->bgap_counter);
>>>
>>> Are you sure that this hardware does not require this read to happen
>>> in order for it to work properly?
>>
>> Yes, initially we had the same concern but we were unable to find
>> anything specific in the history. The commit mentioned above removed
>> the user of the 'val' code but without removing this block of code.
>>
>> When looking at the current code, it really looks like an oversight.
>
> Yes so it seems.
>
>> There is nothing in the commit's changelog referring to a need of
>> reading the counter register but perhaps I'm wrong because I'm not
>> sure to understand correctly the changelog.
>>
>>> Lots of hardware does need this, have you tested this?
>
> I just tested this on omap3 logicpd torpedo devkit that can do off
> during idle and reading /sys/class/thermal/thermal_zone0/temp works.
> So feel free to add:
>
> Reviewed-by: Tony Lindgren <tony@atomide.com>
> Tested-by: Tony Lindgren <tony@atomide.com>
Thanks for testing
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2021-04-22 12:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-21 8:42 [PATCH v3] thermal: ti-soc-thermal: Remove unused variable 'val' Lin Ruizhe
2021-04-21 8:49 ` Greg KH
2021-04-21 9:06 ` Daniel Lezcano
2021-04-21 9:37 ` Tony Lindgren
2021-04-21 11:36 ` Daniel Lezcano
2021-04-22 12:39 ` linruizhe [this message]
2021-04-22 13:50 ` 答复: " Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7871516e6f824f35929c4ed87cbc08c4@huawei.com \
--to=linruizhe@huawei.com \
--cc=amitk@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=eballetbo@gmail.com \
--cc=edubezval@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=j-keerthy@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rui.zhang@intel.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).