From: Grygorii Strashko <grygorii.strashko@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Ivan Jelincic <parazyd@dyne.org>, <linux-omap@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/2] ARM: omap2plus_defconfig: Enable Netfilter components as modules.
Date: Fri, 5 Feb 2021 16:01:38 +0200 [thread overview]
Message-ID: <7ab0268d-7dcf-494f-0120-c8ac42f47d70@ti.com> (raw)
In-Reply-To: <YB1JEu8cfcy1Ixwb@atomide.com>
On 05/02/2021 15:33, Tony Lindgren wrote:
> * Grygorii Strashko <grygorii.strashko@ti.com> [210205 13:18]:
>> On 03/02/2021 13:34, Ivan Jelincic wrote:
>>> Enable the majority of the Netfilter components as loadable modules
>>> in the omap2plus_defconfig file.
> ...
>>> diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig
>>> index f250bf1cc022..9847502d2c97 100644
>>> --- a/arch/arm/configs/omap2plus_defconfig
>>> +++ b/arch/arm/configs/omap2plus_defconfig
>>> @@ -87,6 +87,155 @@ CONFIG_IP_PNP_DHCP=y
>>> CONFIG_IP_PNP_BOOTP=y
>>> CONFIG_IP_PNP_RARP=y
>>> CONFIG_NETFILTER=y
>>> +CONFIG_NF_CONNTRACK=m
>>> +CONFIG_NF_LOG_NETDEV=m
>>> +CONFIG_NF_CONNTRACK_ZONES=y
>>> +CONFIG_NF_CONNTRACK_EVENTS=y
>>> +CONFIG_NF_CONNTRACK_TIMEOUT=y
>>> +CONFIG_NF_CONNTRACK_TIMESTAMP=y
>>> +CONFIG_NF_CT_NETLINK=m
>>
>> [..]
>>
>> Do we really want to enable all these not TI specific configs?
>> The main purpose of omap2plus_defconfig is to enable TI specific HW and HW features and
>> config options required to tests/demonstrate these features - like support for some networking
>> HW offloads.
>
> Well these are loadable modules. And I'd like to have omap2plus_defconfig
> and multi_v7_defconfig usable as a base config for distros to use.
>
> For built-in options I agree. We should only enable absolute minimum
> for built-in optoins as otherwise things get even more bloated.
Ok. Up to you.
--
Best regards,
grygorii
prev parent reply other threads:[~2021-02-05 22:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-03 11:34 [PATCH 1/2] ARM: omap2plus_defconfig: Enable Netfilter components as modules Ivan Jelincic
2021-02-03 11:34 ` [PATCH 2/2] ARM: omap2plus_defconfig: Update for dropped options Ivan Jelincic
2021-02-04 6:56 ` Tony Lindgren
2021-02-05 13:15 ` Grygorii Strashko
2021-02-05 13:17 ` Ivan J.
2021-02-05 13:30 ` Tony Lindgren
2021-02-05 14:25 ` Grygorii Strashko
2021-02-05 14:46 ` Tony Lindgren
2021-02-05 15:04 ` Grygorii Strashko
2021-02-05 15:04 ` Grygorii Strashko
2021-02-06 7:23 ` Tony Lindgren
2021-02-05 13:18 ` [PATCH 1/2] ARM: omap2plus_defconfig: Enable Netfilter components as modules Grygorii Strashko
2021-02-05 13:33 ` Tony Lindgren
2021-02-05 14:01 ` Grygorii Strashko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ab0268d-7dcf-494f-0120-c8ac42f47d70@ti.com \
--to=grygorii.strashko@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=parazyd@dyne.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).