From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E649C433B4 for ; Wed, 5 May 2021 14:22:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 14AFB61057 for ; Wed, 5 May 2021 14:22:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232704AbhEEOXj (ORCPT ); Wed, 5 May 2021 10:23:39 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:55677 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232079AbhEEOXi (ORCPT ); Wed, 5 May 2021 10:23:38 -0400 Received: from mail-qk1-f198.google.com ([209.85.222.198]) by youngberry.canonical.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1leIQD-00027c-9G for linux-omap@vger.kernel.org; Wed, 05 May 2021 14:22:41 +0000 Received: by mail-qk1-f198.google.com with SMTP id b19-20020a05620a0893b02902e956b29f5dso1217841qka.16 for ; Wed, 05 May 2021 07:22:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=p2p0gJ55l2BrIuGW3fGJbblLcGMFAVclXvZPsg/9734=; b=idIFnfjw9VGMb5Rq3TW+nqW0bf76oJ3aINxyqq4scxwFi7PNjApCtS6VhA71sT0v0V XBaO6+xMzvFEu6O4qEdXOb3UGigvAEprONxTox7Evi5Gjxtp6dd7IeuoNe4yiJaUjUA+ 1QH5GB+HPK3kDCaSVcc5HZ0WDHSsJzIMaN0GDf0mIB5Bf6e6SWDgO6iryMYcn+OXqpkk 0CJvV17+QRa6hd9vD1ZGz8hANtl0SgxYkBVJza2QLCMKa5xLz8XWbETu4KTbfMkircqZ O70rumT5CWcR2nDgqG6WRS96lx4c5OdSSyULYRI1vCD5fjUU9wOJzIA8kGROLgzU6Fg8 ZWUA== X-Gm-Message-State: AOAM532LUVU4oAvk8FJr5KWPo5oLQB2KcrKEa6FZm9ZtiRpVx8HIS9Xe plmzqqZJA9CKU6zWnb3vWbPPB2F7rdkiEGk/XhHHNr6Isl316ZcVsqNugNQsv8xfRW68dyH6Imv FuWm7a30jLsFEIosJsHbiaaC3PdB4LVCqQzH23a8= X-Received: by 2002:a37:e11:: with SMTP id 17mr24576833qko.499.1620224560354; Wed, 05 May 2021 07:22:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxpQ3TLPSdk4w5AAovg0o+kr9jYYchgdMLem+pb6Sh/mSEWGzgGWWL46ISf/llPTJXMza6lWw== X-Received: by 2002:a37:e11:: with SMTP id 17mr24576805qko.499.1620224560113; Wed, 05 May 2021 07:22:40 -0700 (PDT) Received: from [192.168.1.4] ([45.237.49.1]) by smtp.gmail.com with ESMTPSA id r16sm1041922qtx.36.2021.05.05.07.22.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 May 2021 07:22:39 -0700 (PDT) Subject: Re: [PATCH] ARM: dts: am5729-beagleboneai: drop unused Broadcom WiFi properties To: Robert Nelson , alexey.roslyakov@gmail.com, Drew Fustini , Jason Kridner Cc: =?UTF-8?Q?Beno=c3=aet_Cousson?= , Tony Lindgren , Rob Herring , linux-omap , devicetree , linux kernel , linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com References: <20210505140015.60013-1-krzysztof.kozlowski@canonical.com> From: Krzysztof Kozlowski Message-ID: <7ced6d2f-7107-e612-6787-63e38e5e3edd@canonical.com> Date: Wed, 5 May 2021 10:22:37 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org On 05/05/2021 10:15, Robert Nelson wrote: > On Wed, May 5, 2021 at 9:04 AM Krzysztof Kozlowski > wrote: >> >> The brcm,sd-head-align, brcm,sd_head_align and brcm,sd_sgentry_align are >> not used by the driver and not present in dtschema: >> >> arch/arm/boot/dts/am5729-beagleboneai.dt.yaml: wifi@1: >> 'brcm,sd-head-align', 'brcm,sd_head_align', 'brcm,sd_sgentry_align' do not match any of the regexes: 'pinctrl-[0-9]+' >> >> Signed-off-by: Krzysztof Kozlowski >> --- >> arch/arm/boot/dts/am5729-beagleboneai.dts | 4 ---- >> 1 file changed, 4 deletions(-) >> >> diff --git a/arch/arm/boot/dts/am5729-beagleboneai.dts b/arch/arm/boot/dts/am5729-beagleboneai.dts >> index 149cfafb90bf..d3b2e87a6266 100644 >> --- a/arch/arm/boot/dts/am5729-beagleboneai.dts >> +++ b/arch/arm/boot/dts/am5729-beagleboneai.dts >> @@ -582,10 +582,6 @@ brcmf: wifi@1 { >> reg = <1>; >> compatible = "brcm,bcm4329-fmac"; >> >> - brcm,sd-head-align = <4>; >> - brcm,sd_head_align = <4>; >> - brcm,sd_sgentry_align = <512>; >> - >> interrupt-parent = <&gpio3>; >> interrupts = <23 IRQ_TYPE_LEVEL_LOW>; >> interrupt-names = "host-wake"; >> -- >> 2.25.1 >> > > NAK, for what it is worth.. > > This is a plain old shitty situation, that everyone that mistakenly > chooses a BRCM based chipset in a design faces, then learns to NEVER > touch that chipset again.. > > These nodes have been posted before for mainline inclusion but always > get killed off: > > https://lkml.org/lkml/2018/3/18/356 > > The TI AM57xx SDIO needs these flags for the brcmfmac driver to actually work. > > I don't see the brcmfmac developers actually fixing it, as "out of > tree" work for brcmfmac is 100+ patches long: Thanks for explanation. I understand these are actually used by out-of-tree driver? That's a valid reason to add them to the binding then... > > https://www.cypress.com/documentation/software-and-drivers-archive/wifi-bt-linux-archive?source=search&cat=other Requires login - I am not able to get the sources. Best regards, Krzysztof