From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Andreas Kemnade <andreas@kemnade.info>,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
tony@atomide.com, afd@ti.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH v6 1/2] dt-bindings: omap: Convert omap.txt to yaml
Date: Thu, 6 Apr 2023 10:36:36 +0200 [thread overview]
Message-ID: <7f43953c-d326-f517-d896-cbb060d8092a@linaro.org> (raw)
In-Reply-To: <eb4cf82d-f523-d5af-be18-25c37678a95a@linaro.org>
On 06/04/2023 10:32, Krzysztof Kozlowski wrote:
> On 05/04/2023 18:19, Andreas Kemnade wrote:
>> From: Andrew Davis <afd@ti.com>
>>
>> Convert omap.txt to yaml.
>>
>
>
>> + - description: TI AM43 SoC based platforms
>> + items:
>> + - enum:
>> + - compulab,am437x-cm-t43
>> + - ti,am437x-gp-evm
>> + - ti,am437x-idk-evm
>> + - ti,am437x-sk-evm
>> + - pattern: '^ti,am4372[26789]$'
>> + - const: ti,am43
>> +
>> + - description: TI AM57 SoC based platforms
>> + items:
>> + - enum:
>> + - beagle,am5729-beagleboneai
>> + - compulab,cl-som-am57x
>> + - ti,am5718-idk
>> + - ti,am5728-idk
>> + - ti,am5748-idk
>> + - pattern: '^ti,am57[0124][689]$'
>
> I don't think my comments were resolved. I asked if it is possible to
> make a board called "ti,am5718-idk" with "ti,am5749" or with "ti,am5708"?
Hm, I cannot find my concern, so maybe it never left my outbox. Anyway,
it looks like you allow here many incorrect patterns and combinations.
>
> What's more, you dropped several variations and compatibles against
> original binding (all the "dra") and it is not explained in commit msg
> at all.
All changes against original bindings should be explained.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-04-06 8:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-05 16:19 [PATCH v6 0/2] dt-bindings: omap: Convert omap.txt to yaml Andreas Kemnade
2023-04-05 16:19 ` [PATCH v6 1/2] " Andreas Kemnade
2023-04-06 8:32 ` Krzysztof Kozlowski
2023-04-06 8:36 ` Krzysztof Kozlowski [this message]
2023-04-06 18:35 ` Andreas Kemnade
2023-04-06 18:46 ` Krzysztof Kozlowski
2023-05-11 21:28 ` Andreas Kemnade
2023-04-05 16:19 ` [PATCH v6 2/2] MAINTAINERS: add board bindings list to OMAP2+ files Andreas Kemnade
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f43953c-d326-f517-d896-cbb060d8092a@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=afd@ti.com \
--cc=andreas@kemnade.info \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).