From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FFBFC433DF for ; Mon, 22 Jun 2020 14:16:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7103120738 for ; Mon, 22 Jun 2020 14:16:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="D+KXfpeN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729136AbgFVOQY (ORCPT ); Mon, 22 Jun 2020 10:16:24 -0400 Received: from mail29.static.mailgun.info ([104.130.122.29]:29015 "EHLO mail29.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728937AbgFVOQY (ORCPT ); Mon, 22 Jun 2020 10:16:24 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1592835384; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=f6kTGE+qZlvFQEy4s+N9cwPFbTCG0vmbcHOxUcyLzHE=; b=D+KXfpeNFByJv4B0zCe/IIRDZd4Eqzn5upbIJ+GWhw4nsKbo1BDSJOPg1Oyz7dwoNUEiJR/5 DUIXxSKN5mG6Yy6PfgYD82kmCcfmSU7x4nPL1xnE1E86zvjIqmK1HPlkdwUFAGu5DJPwf/zk BhdSBJPVlQ3qFO9lpuvr00jeeDg= X-Mailgun-Sending-Ip: 104.130.122.29 X-Mailgun-Sid: WyIwZGJlNiIsICJsaW51eC1vbWFwQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n05.prod.us-east-1.postgun.com with SMTP id 5ef0bd2a567385e8e70b36bb (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Mon, 22 Jun 2020 14:16:10 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id F2E91C433CA; Mon, 22 Jun 2020 14:16:09 +0000 (UTC) Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 34852C433C6; Mon, 22 Jun 2020 14:16:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 34852C433C6 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Tony Lindgren Cc: Eyal Reizer , Guy Mishol , linux-wireless@vger.kernel.org, linux-omap@vger.kernel.org Subject: Re: [PATCH 2/4] wlcore: Use spin_trylock in wlcore_irq() to see if we need to queue tx References: <20200617212505.62519-1-tony@atomide.com> <20200617212505.62519-3-tony@atomide.com> Date: Mon, 22 Jun 2020 17:16:05 +0300 In-Reply-To: <20200617212505.62519-3-tony@atomide.com> (Tony Lindgren's message of "Wed, 17 Jun 2020 14:25:03 -0700") Message-ID: <871rm7gp96.fsf@codeaurora.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org Tony Lindgren writes: > We need the spinlock to check if we need to queue tx in wlcore_irq(). > Let's use spin_trylock instead and always queue tx unless we know there's > nothing to do. > > Let's also update the comment a bit while at it. > > Signed-off-by: Tony Lindgren Same question as in patch 1, the background for this is not clear. -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches