From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AF45C433DF for ; Mon, 22 Jun 2020 14:14:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 31C0E206E2 for ; Mon, 22 Jun 2020 14:14:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="R4tiX/ql" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729125AbgFVOOx (ORCPT ); Mon, 22 Jun 2020 10:14:53 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:51205 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728954AbgFVOOx (ORCPT ); Mon, 22 Jun 2020 10:14:53 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1592835292; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=F9ZYPJqnwR7qLas1OFPPs1HFrhNZLi85hn9x30GxDr4=; b=R4tiX/qlVxmDcS7TuqvTX04F3yb2nJDrxV5WBLbu99GZlPXOuL1TaSt2cVKUJ+4tXKO3Fy5q 314X12mijrvSFM0WnqvECyWMtNQk7Is6de7BUi2NceyAv/0CpOukRJvYqmreJo2/jVFS9gsr Y286bOhocCSqSkGlMmK5mdOHhGM= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyIwZGJlNiIsICJsaW51eC1vbWFwQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n11.prod.us-west-2.postgun.com with SMTP id 5ef0bcd4117610c7ff28d250 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Mon, 22 Jun 2020 14:14:44 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 42D91C433CB; Mon, 22 Jun 2020 14:14:44 +0000 (UTC) Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 5F49FC433C6; Mon, 22 Jun 2020 14:14:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 5F49FC433C6 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Tony Lindgren Cc: Eyal Reizer , Guy Mishol , linux-wireless@vger.kernel.org, linux-omap@vger.kernel.org Subject: Re: [PATCH 1/4] wlcore: Use spin_trylock in wlcore_irq_locked() for running the queue References: <20200617212505.62519-1-tony@atomide.com> <20200617212505.62519-2-tony@atomide.com> Date: Mon, 22 Jun 2020 17:14:40 +0300 In-Reply-To: <20200617212505.62519-2-tony@atomide.com> (Tony Lindgren's message of "Wed, 17 Jun 2020 14:25:02 -0700") Message-ID: <875zbjgpbj.fsf@codeaurora.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org Tony Lindgren writes: > We need the spinlock to check if we need to run the queue. Let's use > spin_trylock instead and always run the queue unless we know there's > nothing to do. Why? What's the problem you are solving here? -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches