linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@deeprootsystems.com>
To: Kim Kyuwon <chammoru@gmail.com>
Cc: OMAP <linux-omap@vger.kernel.org>, 박경민 <kyungmin.park@samsung.com>
Subject: Re: [PATCH 1/2] OMAP3: PM: Fix compile error with 'CONFIG_OMAP_PM_SRF=y'
Date: Tue, 31 Mar 2009 17:13:57 -0700	[thread overview]
Message-ID: <87k565tem2.fsf@deeprootsystems.com> (raw)
In-Reply-To: <4d34a0a70903200107j65ae61fay9a954e71b8910348@mail.gmail.com> (Kim Kyuwon's message of "Fri\, 20 Mar 2009 17\:07\:32 +0900")

Kim Kyuwon <chammoru@gmail.com> writes:

> This patch fixes below compile error. The header file
> 'mach/omap34xx.h' declared all needed symbols.
>
>   CC      arch/arm/mach-omap2/pm.o
>   CC      arch/arm/mach-omap2/resource34xx.o
> arch/arm/mach-omap2/resource34xx.c: In function 'resource_access_opp_lock':
> arch/arm/mach-omap2/resource34xx.c:174: error: 'VDD1_OPP' undeclared
> (first use in this function)
> arch/arm/mach-omap2/resource34xx.c:177: error: 'VDD2_OPP' undeclared
> (first use in this function)
> arch/arm/mach-omap2/resource34xx.c:209: error: 'MAX_VDD1_OPP'
> undeclared (first use in this function)
> <snip>
> make[1]: *** [arch/arm/mach-omap2/resource34xx.o] Error 1
> arch/arm/mach-omap2/pm.c: In function 'vdd_opp_show':
> arch/arm/mach-omap2/pm.c:140: error: 'VDD1_OPP' undeclared (first use
> in this function)
> arch/arm/mach-omap2/pm.c:140: error: (Each undeclared identifier is
> reported only once
> <snip>
> make[1]: *** [arch/arm/mach-omap2/pm.o] Error 1
>
> Signed-off-by: Kim Kyuwon <q1.kim@samsung.com>

Thanks, pushing to PM branch.

Kevin

> ---
>  arch/arm/mach-omap2/pm.c           |    1 +
>  arch/arm/mach-omap2/resource34xx.c |    1 +
>  2 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/pm.c b/arch/arm/mach-omap2/pm.c
> index e64a80e..c0f1ae8 100644
> --- a/arch/arm/mach-omap2/pm.c
> +++ b/arch/arm/mach-omap2/pm.c
> @@ -34,6 +34,7 @@
>  #include <mach/powerdomain.h>
>  #include <mach/omapdev.h>
>  #include <mach/resource.h>
> +#include <mach/omap34xx.h>
>
>  #include "prm-regbits-34xx.h"
>  #include "pm.h"
> diff --git a/arch/arm/mach-omap2/resource34xx.c
> b/arch/arm/mach-omap2/resource34xx.c
> index 2328323..4db9289 100644
> --- a/arch/arm/mach-omap2/resource34xx.c
> +++ b/arch/arm/mach-omap2/resource34xx.c
> @@ -20,6 +20,7 @@
>  #include <linux/cpufreq.h>
>  #include <mach/powerdomain.h>
>  #include <mach/clockdomain.h>
> +#include <mach/omap34xx.h>
>  #include "smartreflex.h"
>  #include "resource34xx.h"
>  #include "pm.h"
> -- 
> 1.5.2.5
>
>
> -- 
> Kim Kyuwon

      reply	other threads:[~2009-04-01  0:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-20  8:07 [PATCH 1/2] OMAP3: PM: Fix compile error with 'CONFIG_OMAP_PM_SRF=y' Kim Kyuwon
2009-04-01  0:13 ` Kevin Hilman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k565tem2.fsf@deeprootsystems.com \
    --to=khilman@deeprootsystems.com \
    --cc=chammoru@gmail.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).