From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB33EC433C1 for ; Mon, 22 Mar 2021 15:59:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AB1856187E for ; Mon, 22 Mar 2021 15:59:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230188AbhCVP6j (ORCPT ); Mon, 22 Mar 2021 11:58:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40566 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230324AbhCVP6g (ORCPT ); Mon, 22 Mar 2021 11:58:36 -0400 Received: from mail-lj1-x230.google.com (mail-lj1-x230.google.com [IPv6:2a00:1450:4864:20::230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5737BC061762 for ; Mon, 22 Mar 2021 08:58:35 -0700 (PDT) Received: by mail-lj1-x230.google.com with SMTP id 15so21785260ljj.0 for ; Mon, 22 Mar 2021 08:58:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=waldekranz-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=GZRr9jbufQ2tgNzlMNa/gP7G4K2WltzYEPBk861waJk=; b=jVR0sTkiVcqaZRx+UXHzi8dHe+SKO0rtuDL24tK9m6dlT+xYdpD/ZI1H6FHD8aNpl1 5Oeo0dtdsXZ32Oblvv27BGRIK4YFjMq33zF4046Ub9wid9WIxFaV+Cz2XpqFLQ5qnDos F/9/FzE32bWgNXcNTcOGumxN3Nun0N0NCXTlORpKUBQbTXSGDXmUnNu+QfecT6Wb/d0k o2tcDK/xsEAhJqm8q56HWpXVNZ96d4ODSdtEm3X9kBPS2zeUN2/QjfUyQfqoDII/rEUE PO8S/j18zEGKAgmfndKPccSo5DY3nyLc1VQYQsbYs/4xgkAyvaTCsT9uaoPubzeoZd4t sn2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=GZRr9jbufQ2tgNzlMNa/gP7G4K2WltzYEPBk861waJk=; b=DLIB/ngKVnhp6NebE57gJvDoLL+kQ2dm1Ny/qweRLs7J4EtLOj8hNkQJbtfYfh/YWp aX2tBe8DDvWkltsyYCi973LMrwuJySCf7e8GOZUgJPkimU7GqMIQFQGUPwRDC/F3MlDS g6PWt36s+iajnm/3hGJNsNghL3YXbmDQi1yWKfFz9yVa+t6ywWInc2BOSgNVSXIl+pyu 1a+I+1/iXdu4x1G4lTHxxafoTOXziU3YhrLhgMJIRC/9oiZD6WaovLW0/MquOD6Cd0qw 2eCOmXteDUD+NyV0h60+QQ0Xt+ZYF8OtJH6xmV4I3EQBwZUU9lzp01/CuzpcwYSjeif9 TgZg== X-Gm-Message-State: AOAM532oopW3KsqEfJMCqDk7SBSbvBtqvMFFbBlfR2ZQ9DeBu2hlrRXT r+rBfBf/oDYTvgxkTiFqivcWww== X-Google-Smtp-Source: ABdhPJzcynmtRN64W8T6iFzfVhW8EJA/FfnkdIzyMTQMViP+DIpTp5jzwa4IQF0SoXBc66IlchtItg== X-Received: by 2002:a2e:22c6:: with SMTP id i189mr183085lji.346.1616428713695; Mon, 22 Mar 2021 08:58:33 -0700 (PDT) Received: from wkz-x280 (static-193-12-47-89.cust.tele2.se. [193.12.47.89]) by smtp.gmail.com with ESMTPSA id t142sm1597443lff.255.2021.03.22.08.58.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Mar 2021 08:58:33 -0700 (PDT) From: Tobias Waldekranz To: Vladimir Oltean , Jakub Kicinski , "David S. Miller" Cc: Andrew Lunn , Vivien Didelot , Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Roopa Prabhu , Nikolay Aleksandrov , Jiri Pirko , Ido Schimmel , Alexandre Belloni , UNGLinuxDriver@microchip.com, Vadym Kochan , Taras Chornyi , Grygorii Strashko , Vignesh Raghavendra , Ioana Ciornei , Ivan Vecera , linux-omap@vger.kernel.org, Vladimir Oltean Subject: Re: [RFC PATCH v2 net-next 15/16] net: dsa: return -EOPNOTSUPP when driver does not implement .port_lag_join In-Reply-To: <20210318231829.3892920-16-olteanv@gmail.com> References: <20210318231829.3892920-1-olteanv@gmail.com> <20210318231829.3892920-16-olteanv@gmail.com> Date: Mon, 22 Mar 2021 16:58:32 +0100 Message-ID: <87tup3mb87.fsf@waldekranz.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org On Fri, Mar 19, 2021 at 01:18, Vladimir Oltean wrote: > From: Vladimir Oltean > > The DSA core has a layered structure, and even though we end up > returning 0 (success) to user space when setting a bonding/team upper > that can't be offloaded, some parts of the framework actually need to > know that we couldn't offload that. > > For example, if dsa_switch_lag_join returns 0 as it currently does, > dsa_port_lag_join has no way to tell a successful offload from a > software fallback, and it will call dsa_port_bridge_join afterwards. > Then we'll think we're offloading the bridge master of the LAG, when in > fact we're not even offloading the LAG. In turn, this will make us set > skb->offload_fwd_mark = true, which is incorrect and the bridge doesn't > like it. > > Signed-off-by: Vladimir Oltean > --- Reviewed-by: Tobias Waldekranz