From: Hans Verkuil <hverkuil-cisco@xs4all.nl>
To: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
linux-media@vger.kernel.org
Cc: Tony Lindgren <tony@atomide.com>, Sekhar Nori <nsekhar@ti.com>,
dri-devel@lists.freedesktop.org,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
linux-omap@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCHv2 6/6] drm/omapdrm/dss/hdmi5: add CEC support
Date: Wed, 3 Mar 2021 08:51:28 +0100 [thread overview]
Message-ID: <95ec6807-49d1-d9e0-005b-25c65e85ea9b@xs4all.nl> (raw)
In-Reply-To: <fe8eefe2-16d0-5d15-8a88-508d71a1f505@ideasonboard.com>
On 03/03/2021 08:47, Tomi Valkeinen wrote:
> On 02/03/2021 18:24, Hans Verkuil wrote:
>> Add HDMI CEC support for OMAP5.
>>
>> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
>> ---
>> drivers/gpu/drm/omapdrm/Kconfig | 8 +
>> drivers/gpu/drm/omapdrm/Makefile | 1 +
>> drivers/gpu/drm/omapdrm/dss/hdmi.h | 1 +
>> drivers/gpu/drm/omapdrm/dss/hdmi5.c | 63 +++++--
>> drivers/gpu/drm/omapdrm/dss/hdmi5_cec.c | 209 +++++++++++++++++++++++
>> drivers/gpu/drm/omapdrm/dss/hdmi5_cec.h | 42 +++++
>> drivers/gpu/drm/omapdrm/dss/hdmi5_core.c | 35 +++-
>> drivers/gpu/drm/omapdrm/dss/hdmi5_core.h | 33 +++-
>> 8 files changed, 373 insertions(+), 19 deletions(-)
>> create mode 100644 drivers/gpu/drm/omapdrm/dss/hdmi5_cec.c
>> create mode 100644 drivers/gpu/drm/omapdrm/dss/hdmi5_cec.h
>
> <snip>
>
>> diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi5_core.h b/drivers/gpu/drm/omapdrm/dss/hdmi5_core.h
>> index 070cbf5fb57d..a83b634f6011 100644
>> --- a/drivers/gpu/drm/omapdrm/dss/hdmi5_core.h
>> +++ b/drivers/gpu/drm/omapdrm/dss/hdmi5_core.h
>> @@ -30,8 +30,18 @@
>> #define HDMI_CORE_IH_PHY_STAT0 0x00410
>> #define HDMI_CORE_IH_I2CM_STAT0 0x00414
>> #define HDMI_CORE_IH_CEC_STAT0 0x00418
>> +#define CEC_STAT_DONE BIT(0)
>> +#define CEC_STAT_EOM BIT(1)
>> +#define CEC_STAT_NACK BIT(2)
>> +#define CEC_STAT_ARBLOST BIT(3)
>> +#define CEC_STAT_ERROR_INIT BIT(4)
>> +#define CEC_STAT_ERROR_FOLL BIT(5)
>> +#define CEC_STAT_WAKEUP BIT(6)
>> +
>> #define HDMI_CORE_IH_VP_STAT0 0x0041C
>> #define HDMI_CORE_IH_I2CMPHY_STAT0 0x00420
>> +#define HDMI_CORE_IH_MUTE_I2CM_STAT0 0x00614
>
> The line above has indentation in spaces, but everything else uses tabs.
Well spotted!
I've fixed that in my tree.
>
> Other than that:
>
> Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Thanks!
Hans
>
> Tomi
>
prev parent reply other threads:[~2021-03-04 0:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-02 16:23 [PATCHv2 0/6] drm/omap: hdmi: improve hdmi4 CEC, add CEC for hdmi5 Hans Verkuil
2021-03-02 16:23 ` [PATCHv2 1/6] drm: drm_bridge: add connector_attach/detach bridge ops Hans Verkuil
2021-04-16 7:46 ` Tomi Valkeinen
2021-04-28 12:10 ` Hans Verkuil
2021-03-02 16:23 ` [PATCHv2 2/6] drm/omapdrm/dss/hdmi4: switch to the connector " Hans Verkuil
2021-04-16 7:55 ` Tomi Valkeinen
2021-03-02 16:24 ` [PATCHv2 3/6] drm/omapdrm/dss/hdmi4: simplify CEC Phys Addr handling Hans Verkuil
2021-03-02 16:24 ` [PATCHv2 4/6] dt-bindings: display: ti: ti,omap5-dss.txt: add cec clock Hans Verkuil
2021-03-03 7:40 ` Tomi Valkeinen
2021-03-08 18:59 ` [PATCHv2 4/6] dt-bindings: display: ti: ti, omap5-dss.txt: " Rob Herring
2021-03-02 16:24 ` [PATCHv2 5/6] dra7.dtsi/omap5.dtsi: " Hans Verkuil
2021-03-03 7:44 ` Tomi Valkeinen
2021-03-02 16:24 ` [PATCHv2 6/6] drm/omapdrm/dss/hdmi5: add CEC support Hans Verkuil
2021-03-03 7:47 ` Tomi Valkeinen
2021-03-03 7:51 ` Hans Verkuil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=95ec6807-49d1-d9e0-005b-25c65e85ea9b@xs4all.nl \
--to=hverkuil-cisco@xs4all.nl \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).