* [PATCH] memory: omap-gpmc: Fix compile test on SPARC
@ 2020-09-11 14:32 Krzysztof Kozlowski
2020-09-11 14:48 ` Roger Quadros
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-11 14:32 UTC (permalink / raw)
To: Roger Quadros, Tony Lindgren, Krzysztof Kozlowski, linux-omap,
linux-kernel
SPARC comes without CONFIG_OF_ADDRESS thus compile testing fails on
linking:
/usr/bin/sparc64-linux-gnu-ld: drivers/memory/omap-gpmc.o: in function `gpmc_probe_generic_child':
omap-gpmc.c:(.text.unlikely+0x14ec): undefined reference to `of_platform_device_create'
Fixes: ea0c0ad6b6eb ("memory: Enable compile testing for most of the drivers")
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/memory/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/memory/Kconfig b/drivers/memory/Kconfig
index 8072204bc21a..00e013b14703 100644
--- a/drivers/memory/Kconfig
+++ b/drivers/memory/Kconfig
@@ -104,6 +104,7 @@ config TI_EMIF
config OMAP_GPMC
bool "Texas Instruments OMAP SoC GPMC driver" if COMPILE_TEST
+ depends on OF_ADDRESS
select GPIOLIB
help
This driver is for the General Purpose Memory Controller (GPMC)
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] memory: omap-gpmc: Fix compile test on SPARC
2020-09-11 14:32 [PATCH] memory: omap-gpmc: Fix compile test on SPARC Krzysztof Kozlowski
@ 2020-09-11 14:48 ` Roger Quadros
2020-09-11 14:55 ` Krzysztof Kozlowski
2020-09-15 7:46 ` Roger Quadros
2020-09-16 17:42 ` Krzysztof Kozlowski
2 siblings, 1 reply; 6+ messages in thread
From: Roger Quadros @ 2020-09-11 14:48 UTC (permalink / raw)
To: Krzysztof Kozlowski, Tony Lindgren, linux-omap, linux-kernel
Hi Krzysztof,
On 11/09/2020 17:32, Krzysztof Kozlowski wrote:
> SPARC comes without CONFIG_OF_ADDRESS thus compile testing fails on
> linking:
>
> /usr/bin/sparc64-linux-gnu-ld: drivers/memory/omap-gpmc.o: in function `gpmc_probe_generic_child':
> omap-gpmc.c:(.text.unlikely+0x14ec): undefined reference to `of_platform_device_create'
>
> Fixes: ea0c0ad6b6eb ("memory: Enable compile testing for most of the drivers")
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> drivers/memory/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/memory/Kconfig b/drivers/memory/Kconfig
> index 8072204bc21a..00e013b14703 100644
> --- a/drivers/memory/Kconfig
> +++ b/drivers/memory/Kconfig
> @@ -104,6 +104,7 @@ config TI_EMIF
>
> config OMAP_GPMC
> bool "Texas Instruments OMAP SoC GPMC driver" if COMPILE_TEST
> + depends on OF_ADDRESS
but of_platform_device_create() is defined in platform.c which gets built
irrespective of OF_ADDRESS.
Maybe we need to just depend on CONFIG_OF ?
> select GPIOLIB
> help
> This driver is for the General Purpose Memory Controller (GPMC)
>
cheers,
-roger
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] memory: omap-gpmc: Fix compile test on SPARC
2020-09-11 14:48 ` Roger Quadros
@ 2020-09-11 14:55 ` Krzysztof Kozlowski
2020-09-15 7:46 ` Roger Quadros
0 siblings, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-11 14:55 UTC (permalink / raw)
To: Roger Quadros; +Cc: Tony Lindgren, linux-omap, linux-kernel
On Fri, 11 Sep 2020 at 16:48, Roger Quadros <rogerq@ti.com> wrote:
>
> Hi Krzysztof,
>
> On 11/09/2020 17:32, Krzysztof Kozlowski wrote:
> > SPARC comes without CONFIG_OF_ADDRESS thus compile testing fails on
> > linking:
> >
> > /usr/bin/sparc64-linux-gnu-ld: drivers/memory/omap-gpmc.o: in function `gpmc_probe_generic_child':
> > omap-gpmc.c:(.text.unlikely+0x14ec): undefined reference to `of_platform_device_create'
> >
> > Fixes: ea0c0ad6b6eb ("memory: Enable compile testing for most of the drivers")
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > ---
> > drivers/memory/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/memory/Kconfig b/drivers/memory/Kconfig
> > index 8072204bc21a..00e013b14703 100644
> > --- a/drivers/memory/Kconfig
> > +++ b/drivers/memory/Kconfig
> > @@ -104,6 +104,7 @@ config TI_EMIF
> >
> > config OMAP_GPMC
> > bool "Texas Instruments OMAP SoC GPMC driver" if COMPILE_TEST
> > + depends on OF_ADDRESS
>
> but of_platform_device_create() is defined in platform.c which gets built
> irrespective of OF_ADDRESS.
>
> Maybe we need to just depend on CONFIG_OF ?
No, the of_platform_device_create() is defined there within #ifdef
CONFIG_OF_ADDRESS
The CONFIG_OF was already selected and was not enough.
Other solution is "depends on !SPARC"...
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] memory: omap-gpmc: Fix compile test on SPARC
2020-09-11 14:55 ` Krzysztof Kozlowski
@ 2020-09-15 7:46 ` Roger Quadros
0 siblings, 0 replies; 6+ messages in thread
From: Roger Quadros @ 2020-09-15 7:46 UTC (permalink / raw)
To: Krzysztof Kozlowski; +Cc: Tony Lindgren, linux-omap, linux-kernel
On 11/09/2020 17:55, Krzysztof Kozlowski wrote:
> On Fri, 11 Sep 2020 at 16:48, Roger Quadros <rogerq@ti.com> wrote:
>>
>> Hi Krzysztof,
>>
>> On 11/09/2020 17:32, Krzysztof Kozlowski wrote:
>>> SPARC comes without CONFIG_OF_ADDRESS thus compile testing fails on
>>> linking:
>>>
>>> /usr/bin/sparc64-linux-gnu-ld: drivers/memory/omap-gpmc.o: in function `gpmc_probe_generic_child':
>>> omap-gpmc.c:(.text.unlikely+0x14ec): undefined reference to `of_platform_device_create'
>>>
>>> Fixes: ea0c0ad6b6eb ("memory: Enable compile testing for most of the drivers")
>>> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>>> ---
>>> drivers/memory/Kconfig | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/memory/Kconfig b/drivers/memory/Kconfig
>>> index 8072204bc21a..00e013b14703 100644
>>> --- a/drivers/memory/Kconfig
>>> +++ b/drivers/memory/Kconfig
>>> @@ -104,6 +104,7 @@ config TI_EMIF
>>>
>>> config OMAP_GPMC
>>> bool "Texas Instruments OMAP SoC GPMC driver" if COMPILE_TEST
>>> + depends on OF_ADDRESS
>>
>> but of_platform_device_create() is defined in platform.c which gets built
>> irrespective of OF_ADDRESS.
>>
>> Maybe we need to just depend on CONFIG_OF ?
>
> No, the of_platform_device_create() is defined there within #ifdef
> CONFIG_OF_ADDRESS
>
> The CONFIG_OF was already selected and was not enough.
>
> Other solution is "depends on !SPARC"...
>
OK. In that case this patch is better.
cheers,
-roger
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] memory: omap-gpmc: Fix compile test on SPARC
2020-09-11 14:32 [PATCH] memory: omap-gpmc: Fix compile test on SPARC Krzysztof Kozlowski
2020-09-11 14:48 ` Roger Quadros
@ 2020-09-15 7:46 ` Roger Quadros
2020-09-16 17:42 ` Krzysztof Kozlowski
2 siblings, 0 replies; 6+ messages in thread
From: Roger Quadros @ 2020-09-15 7:46 UTC (permalink / raw)
To: Krzysztof Kozlowski, Tony Lindgren, linux-omap, linux-kernel
On 11/09/2020 17:32, Krzysztof Kozlowski wrote:
> SPARC comes without CONFIG_OF_ADDRESS thus compile testing fails on
> linking:
>
> /usr/bin/sparc64-linux-gnu-ld: drivers/memory/omap-gpmc.o: in function `gpmc_probe_generic_child':
> omap-gpmc.c:(.text.unlikely+0x14ec): undefined reference to `of_platform_device_create'
>
> Fixes: ea0c0ad6b6eb ("memory: Enable compile testing for most of the drivers")
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Roger Quadros <rogerq@ti.com>
> ---
> drivers/memory/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/memory/Kconfig b/drivers/memory/Kconfig
> index 8072204bc21a..00e013b14703 100644
> --- a/drivers/memory/Kconfig
> +++ b/drivers/memory/Kconfig
> @@ -104,6 +104,7 @@ config TI_EMIF
>
> config OMAP_GPMC
> bool "Texas Instruments OMAP SoC GPMC driver" if COMPILE_TEST
> + depends on OF_ADDRESS
> select GPIOLIB
> help
> This driver is for the General Purpose Memory Controller (GPMC)
>
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] memory: omap-gpmc: Fix compile test on SPARC
2020-09-11 14:32 [PATCH] memory: omap-gpmc: Fix compile test on SPARC Krzysztof Kozlowski
2020-09-11 14:48 ` Roger Quadros
2020-09-15 7:46 ` Roger Quadros
@ 2020-09-16 17:42 ` Krzysztof Kozlowski
2 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-16 17:42 UTC (permalink / raw)
To: Roger Quadros, Tony Lindgren, linux-omap, linux-kernel
On Fri, Sep 11, 2020 at 04:32:51PM +0200, Krzysztof Kozlowski wrote:
> SPARC comes without CONFIG_OF_ADDRESS thus compile testing fails on
> linking:
>
> /usr/bin/sparc64-linux-gnu-ld: drivers/memory/omap-gpmc.o: in function `gpmc_probe_generic_child':
> omap-gpmc.c:(.text.unlikely+0x14ec): undefined reference to `of_platform_device_create'
>
> Fixes: ea0c0ad6b6eb ("memory: Enable compile testing for most of the drivers")
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> drivers/memory/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
Applied.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-09-16 19:12 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-11 14:32 [PATCH] memory: omap-gpmc: Fix compile test on SPARC Krzysztof Kozlowski
2020-09-11 14:48 ` Roger Quadros
2020-09-11 14:55 ` Krzysztof Kozlowski
2020-09-15 7:46 ` Roger Quadros
2020-09-15 7:46 ` Roger Quadros
2020-09-16 17:42 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).